RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login

    Video View For All Themes

    Scheduled Pinned Locked Moved Projects and Themes
    themevideoemulationstatio
    91 Posts 15 Posters 41.0k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • fieldofcowsF
      fieldofcows @Nismo
      last edited by

      @Nismo I haven't made any changes to support the <version> tags yet :) But when/if that change is made the use of the tags will be purely optional: if you want to support non-video ES then you can use the tags, if you don't want to support non-video ES then you can leave them out.

      N 1 Reply Last reply Reply Quote 0
      • N
        Nismo @fieldofcows
        last edited by Nismo

        @fieldofcows And what happen when apart from video view you use things like this (from carbon with video support):

        <view name="basic, detailed, video">

        I use it on my theme too, and don't remember but in pixel theme uses it too...

        I suposse we need to divide the views to make it backward compatible and place the version tag...

        Anyway i think your solution it's the best one for all...

        fieldofcowsF 1 Reply Last reply Reply Quote 0
        • fieldofcowsF
          fieldofcows @Nismo
          last edited by

          @Nismo said in Video View For All Themes:

          @fieldofcows And what happen when apart from video view you use things like this (from carbon with video support):

          <view name="basic, detailed, video">

          I believe that is already ignored by the non-video ES.

          N 1 Reply Last reply Reply Quote 0
          • N
            Nismo @fieldofcows
            last edited by

            @fieldofcows Yeah I imagine that, we need to separate views in order to place the "version" tag. It's a little bit more work but that way we can have the compatibility we are looking for...

            1 Reply Last reply Reply Quote 0
            • N
              Nismo
              last edited by

              So I think if finally we use the "version" workaround, the themes uploaded to github must be backward compatible so no problems for anybody...

              1 Reply Last reply Reply Quote 0
              • fieldofcowsF
                fieldofcows
                last edited by

                I've made the change to my ES to support the <version> tag to try it out and it works fine. I've set the current version of the theme to '4' whereas the non-video ES uses version '3'. This means this code works on the video supported ES (with my fix which is currently not in the RetroPie fork) but is ignored on older versions of ES:

                <version minimum="4">
                   [video config]
                </version>
                

                What does everyone else think of this solution? Is it the right way to fix this?

                lilbudL herb_fargusH N mattrixkM 4 Replies Last reply Reply Quote 0
                • lilbudL
                  lilbud @fieldofcows
                  last edited by

                  @fieldofcows I'm thinking this would be the right way. Having to add video support to 80+ systems is not the way I'd imagne spending an afternoon.

                  Creator of the Radiocade: https://retropie.org.uk/forum/topic/6077/radiocade

                  Backlog: http://backloggery.com/lilbud

                  1 Reply Last reply Reply Quote 0
                  • herb_fargusH
                    herb_fargus administrators @fieldofcows
                    last edited by

                    @fieldofcows looks like the best option to me. I suppose if grid view is ever incorporated this will be a solution for that too.

                    If you read the documentation it will answer 99% of your questions: https://retropie.org.uk/docs/

                    Also if you want a solution to your problems read this first: https://retropie.org.uk/forum/topic/3/read-this-first

                    1 Reply Last reply Reply Quote 0
                    • N
                      Nismo @fieldofcows
                      last edited by

                      @fieldofcows I'm not totally sure but version 4 is not for kids support?

                      fieldofcowsF 1 Reply Last reply Reply Quote 0
                      • mattrixkM
                        mattrixk @fieldofcows
                        last edited by mattrixk

                        @fieldofcows Any theme that supports @Zigurana's child-friendly icons also needs to be version 4. Does that mean those themes also need to support video previews?

                        Edit: Hehe, @Nismo beat me to it by 30 seconds.

                        My ES themes: MetaPixel | Spare | Io | Indent

                        N RookervikR 2 Replies Last reply Reply Quote 0
                        • N
                          Nismo @mattrixk
                          last edited by Nismo

                          @mattrixk lol, yes @fieldofcows commit must be changed to version 5...

                          And for me, yes it's the right way...

                          1 Reply Last reply Reply Quote 0
                          • fieldofcowsF
                            fieldofcows @Nismo
                            last edited by

                            @Nismo said in Video View For All Themes:

                            @fieldofcows I'm not totally sure but version 4 is not for kids support?

                            Well, this is the problem with multiple ES forks. The RetroPie fork is still on version 3:

                            https://github.com/RetroPie/EmulationStation/blob/master/es-core/src/ThemeData.cpp#L98

                            This would naturally go up to 4 to support this change. However, if there are themes out there for a different fork then it is going to cause problems...

                            N 1 Reply Last reply Reply Quote 0
                            • N
                              Nismo @fieldofcows
                              last edited by Nismo

                              @fieldofcows Yes, it's a mess... but I'm still thinking it's the best way to solve the issue...

                              1 Reply Last reply Reply Quote 0
                              • fieldofcowsF
                                fieldofcows
                                last edited by

                                Another thought. Instead of checking version numbers we could use something like this:

                                <feature supported="video">
                                  [configuration if ES supports video]
                                </feature>
                                
                                <feature supported="grid">
                                  [configuration if ES supports grid]
                                </feature>
                                
                                N Z mattrixkM 3 Replies Last reply Reply Quote 3
                                • N
                                  Nismo @fieldofcows
                                  last edited by

                                  @fieldofcows Omg you are a genius, that's totally amazing...

                                  Will that thing cause troubles with older versions of ES?

                                  herb_fargusH fieldofcowsF 2 Replies Last reply Reply Quote 0
                                  • herb_fargusH
                                    herb_fargus administrators @Nismo
                                    last edited by

                                    @Nismo I agree, I think it makes more sense with all the forks...

                                    If you read the documentation it will answer 99% of your questions: https://retropie.org.uk/docs/

                                    Also if you want a solution to your problems read this first: https://retropie.org.uk/forum/topic/3/read-this-first

                                    1 Reply Last reply Reply Quote 0
                                    • fieldofcowsF
                                      fieldofcows @Nismo
                                      last edited by

                                      @Nismo said in Video View For All Themes:

                                      @fieldofcows Omg you are a genius, that's totally amazing...

                                      Will that thing cause troubles with older versions of ES?

                                      No, it won't cause trouble with older versions. Ok, I'll make it so.

                                      N 1 Reply Last reply Reply Quote 2
                                      • herb_fargusH
                                        herb_fargus administrators
                                        last edited by

                                        As an aside at some point it might be good to add the theming docs for video view to the GitHub themes.md

                                        If you read the documentation it will answer 99% of your questions: https://retropie.org.uk/docs/

                                        Also if you want a solution to your problems read this first: https://retropie.org.uk/forum/topic/3/read-this-first

                                        1 Reply Last reply Reply Quote 0
                                        • N
                                          Nismo @fieldofcows
                                          last edited by

                                          @fieldofcows Yes, I think that's better than the version thing because can be compatible between different forks and doesn't interfere with child icons.

                                          1 Reply Last reply Reply Quote 0
                                          • N
                                            Nismo
                                            last edited by Nismo

                                            @fieldofcows I forgot to ask to you, will be that tag mandatory or optional if you make the commit?

                                            I think it will be mandatory for backwards compatibility... but optional for non backwards compatibility.

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post

                                            Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                            Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.