Flat Theme

sergioad

@lilbud maybe @Rookervik could help you to add the option of sound

herb_fargus

@sergioad just look at themes that have sound and copy the respective code in the XML.

lilbud

@herb_fargus No, it only works on the official ES with video support. It would work on @Zigurana ES-Kids branch, but the video tags crash the theme on his ES.

herb_fargus

@lilbud little bird tells me if it's done this way it is backward compatible with non video ES:

https://github.com/jrassa/es-theme-carbon/commit/e388e3d5c10be4218fc6c3b3ec1157d35543111e

lilbud

@herb_fargus updated both themes like that

sergioad

@herb_fargus ok

herb_fargus

@lilbud thanks I'll give it a test when I get time :)

sergioad

@herb_fargus sadly I broke the theme 😂 but that is the way someone learms 😤

herb_fargus

@lilbud This is how it currently looks with the video view. not quite sure what is causing it or how to fix currently (your theme supports an awful lot of experimental stuff!:

https://snag.gy/QbpDEY.jpg

lilbud

@herb_fargus Not quite sure, the only thing I added was,
<feature supported = video>

jdrassa

@herb_fargus are you using @mattrixk's toolkit to test this? I think there is an issue with the marquee images in it. The marquee images were generated to mimic the mix profile from UXS. It is an interesting idea, but if the theme isn't expecting it the positioning could be off. I have been meaning to test it some more to fully gauge the impact. I believe you saw the same thing in carbon. I didn't realize what it was until I saw it myself a few days later.

Regardless the position is still a bit off. I can try to look at it this weekend if @lilbud hasn't figured it out himself.

lilbud

@jdrassa I won't have much time this weekend, i'll be out for most of it. I'm genuinely not sure what is happening.

mattrixk

@jdrassa That's actually something I've been meaning to ask the community about: I'm curious what types of images people use for the <image> and <marquee> tags with video preview.

I have the Toolkit set up this way:

<image> = Screenshot.
<marquee> = A Mix image that includes Logo, 3D Box-art and a Game Cartridge.

I chose the screenshot for <image> because <image> is what you see when there is no <video>, and they are usually the same size as each other. Now that I can test for <maxSize> instead of just <size> I'll probably have to change the values a bit.

What would most people put in the <marquee>? Just the Logo? Obviously if they just use the single Logo image, it would need different values for <size>/<maxSize> and <pos> than the full Mix image.

I like the Mix image as the <marquee> because it gives more game artwork than just a single image. I realise most people probably won't want to rescrape their whole collection just to make the images look pretty, but if they need to scrape the Logos anyway, why not scrape the full Mix image?

herb_fargus

@jdrassa yes I was testing with the toolkit. It's only the video that is offset, the regular images etc line up fine, but nothing I changed in the video tag made any difference so I was confused as to what was happening. I still don't know, haven't been able to test more due to limited time

mattrixk

@herb_fargus I think the <video> and <image> tags kind of get tied up together on Video View, so maybe your <image> tag was getting in the way?

Nismo

@mattrixk Originally marquee tag was created to display the marquee of an arcade cabinet in arcade systems (mame, fba) theme.

So usually marquee it's for displaying marquees in arcade or logos in console systems.

Of course it's another image so you can use it like you want.

Regards.

Nismo

@herb_fargus @lilbud Adding sounds it's pretty simple.

Example for sound when switching between systems:

<view name="system">
	
     <sound name="systemSound">
         <path>./art/systemsound.wav</path>
     </sound>
</view>

Example for gamelist sound:

<textlist name="gamelist">

	<scrollSound>./art/listscroll.wav</scrollSound>
</textlist>

As you can see it's pretty simple to add sounds...

Regards.

mattrixk

Thanks @Nismo, that explains why it's called "marquee" I guess. Also, I didn't know you could already do System switching sounds. I thought Gamelist cycle was the only one that worked. Is that a newer development or has it always been that way?

Nismo

@mattrixk It was a request I did to @fieldofcows lot of months ago, before video view was implemented in the main branch, it's working for me in windows, you can see it working in one of my videos here:

I don't know if it's working in the main branch (unfortunately I don't have a raspberry pi), because he removed a lot of features to add only video support to the main branch, but you can test it because it doesn't break the theme . My theme have that code and the sounds works in windows and nobody told me the theme it's broken in their rpi.

If system sound it's not working in main branch tell me and we can ask to @fieldofcows to make a pull request, so the code it's done and working very good, only that he removed some features for better testing if video implementation on main branch could cause bugs, don't need to worry about other commits.

Anyway you can add the tags for windows users because your theme should still working like before.

lilbud

@Nismo could you submit a PR to the repository? I am away from my computer at the moment.

Thanks in advance.