• Recent
  • Tags
  • Popular
  • Home
  • Docs
  • Register
  • Login
RetroPie forum home
  • Recent
  • Tags
  • Popular
  • Home
  • Docs
  • Register
  • Login

How to help ES pull requests get approved?

Scheduled Pinned Locked Moved Ideas and Development
githubpull requestemulationstatio
9 Posts 3 Posters 2.3k Views
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • T
    TMNTturtlguy
    last edited by 23 Apr 2017, 15:17

    First off, I understand everyone does all of this work on their own time, and for that I am very greatful! I am simply bored without access to my pi to work in it so I am doing a lot of reading and learning and was wondering what we can do in terms of testing or commenting to help get PR's approved on github for emulationstation?

    @pjft helped create a great improvement to allow metadata to work on games within folders. We tested it extensively and have been running it for over a month now and it worked very nicely. It is part of the random screensaver/omx build. When I want to run my personal setup on the main branch of ES I run to to issues where I cannot test several systems because they have games within sub folders and this code has not been accepted in the main branch. Her is pr#109 by @pjft
    Again, thanks to everyone who works really hard on all of this, I really appreciate it!

    P 1 Reply Last reply 23 Apr 2017, 15:19 Reply Quote 0
    • P
      pjft @TMNTturtlguy
      last edited by 23 Apr 2017, 15:19

      @TMNTturtlguy I think it's really much up to everyone's free time and ability to review the work.

      A question: any reason that the merged build I provide doesn't suffice in the interim? i.e. is there any key reason why you need to be on the main ES build at the moment?

      Thanks!

      T 1 Reply Last reply 23 Apr 2017, 16:11 Reply Quote 0
      • T
        TMNTturtlguy @pjft
        last edited by 23 Apr 2017, 16:11

        @pjft I use the main build when testing my themes and modifications. Right now thanks to your awesome work your build is up to date with the main branch so everything is perfect and no current need for the main branch. During the week this week when we were working on the max size video settings and I was testing on your updates I had to go back and forth between your previous build, your update build and the main branch to compare functionality. I ended up buying another SD card so I can run a main branch build as a testing build and then my main gaming build has your screensaver build in it. I am just guessing as ES continues to evolve (maybe video on the system view, and other things I have seen) and you progress with other exciting developments you might not want to always keep your branch up to date right away, so this lets me test and build while I wait for a hopeful update from you!

        P 1 Reply Last reply 23 Apr 2017, 20:05 Reply Quote 0
        • P
          pjft @TMNTturtlguy
          last edited by 23 Apr 2017, 20:05

          @TMNTturtlguy I see. That particular PR isn't big enough that it won't be approved before any larger ones are, hopefully, so I suspect that in the interim you're good with my merged build and by the time something new comes to the main one hopefully that'll have been merged. :)

          T 1 Reply Last reply 23 Apr 2017, 21:18 Reply Quote 0
          • T
            TMNTturtlguy @pjft
            last edited by 23 Apr 2017, 21:18

            @pjft you bet! I am all set for my main build with your ES! Thanks

            1 Reply Last reply Reply Quote 0
            • B
              BuZz administrators
              last edited by BuZz 24 Apr 2017, 14:24

              Did you feed back any test results on that particular PR? I tested it, but was hoping to get more feedback.

              [Edit ] Looking at PR I asked for people to test, but got no feedback.

              To help us help you - please make sure you read the sticky topics before posting - https://retropie.org.uk/forum/topic/3/read-this-first

              T 1 Reply Last reply 24 Apr 2017, 18:03 Reply Quote 1
              • T
                TMNTturtlguy @BuZz
                last edited by 24 Apr 2017, 18:03

                @BuZz yes, I was part of the process in helping @pjft create the PR. I had reached out to the forum with an issue and @pjft came up with the solution and I did extensive testing for him. Here is a link to the testing original post
                The entire history of the issue and all the testing I performed is in the thread. I have been using @pjft random select screensaver ES build which has this incorporated for over a month and it works perfectly. Thanks

                B 1 Reply Last reply 24 Apr 2017, 18:04 Reply Quote 0
                • B
                  BuZz administrators @TMNTturtlguy
                  last edited by 24 Apr 2017, 18:04

                  @TMNTturtlguy thanks.

                  To help us help you - please make sure you read the sticky topics before posting - https://retropie.org.uk/forum/topic/3/read-this-first

                  1 Reply Last reply Reply Quote 0
                  • T
                    TMNTturtlguy
                    last edited by 25 Apr 2017, 00:34

                    Yay! This was accepted, Thank you!

                    1 Reply Last reply Reply Quote 0
                    9 out of 9
                    • First post
                      9/9
                      Last post

                    Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                    Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.

                      This community forum collects and processes your personal information.
                      consent.not_received