How to help ES pull requests get approved?
-
First off, I understand everyone does all of this work on their own time, and for that I am very greatful! I am simply bored without access to my pi to work in it so I am doing a lot of reading and learning and was wondering what we can do in terms of testing or commenting to help get PR's approved on github for emulationstation?
@pjft helped create a great improvement to allow metadata to work on games within folders. We tested it extensively and have been running it for over a month now and it worked very nicely. It is part of the random screensaver/omx build. When I want to run my personal setup on the main branch of ES I run to to issues where I cannot test several systems because they have games within sub folders and this code has not been accepted in the main branch. Her is pr#109 by @pjft
Again, thanks to everyone who works really hard on all of this, I really appreciate it! -
@TMNTturtlguy I think it's really much up to everyone's free time and ability to review the work.
A question: any reason that the merged build I provide doesn't suffice in the interim? i.e. is there any key reason why you need to be on the main ES build at the moment?
Thanks!
-
@pjft I use the main build when testing my themes and modifications. Right now thanks to your awesome work your build is up to date with the main branch so everything is perfect and no current need for the main branch. During the week this week when we were working on the max size video settings and I was testing on your updates I had to go back and forth between your previous build, your update build and the main branch to compare functionality. I ended up buying another SD card so I can run a main branch build as a testing build and then my main gaming build has your screensaver build in it. I am just guessing as ES continues to evolve (maybe video on the system view, and other things I have seen) and you progress with other exciting developments you might not want to always keep your branch up to date right away, so this lets me test and build while I wait for a hopeful update from you!
-
@TMNTturtlguy I see. That particular PR isn't big enough that it won't be approved before any larger ones are, hopefully, so I suspect that in the interim you're good with my merged build and by the time something new comes to the main one hopefully that'll have been merged. :)
-
@pjft you bet! I am all set for my main build with your ES! Thanks
-
Did you feed back any test results on that particular PR? I tested it, but was hoping to get more feedback.
[Edit ] Looking at PR I asked for people to test, but got no feedback.
To help us help you - please make sure you read the sticky topics before posting - https://retropie.org.uk/forum/topic/3/read-this-first
-
@BuZz yes, I was part of the process in helping @pjft create the PR. I had reached out to the forum with an issue and @pjft came up with the solution and I did extensive testing for him. Here is a link to the testing original post
The entire history of the issue and all the testing I performed is in the thread. I have been using @pjft random select screensaver ES build which has this incorporated for over a month and it works perfectly. Thanks -
@TMNTturtlguy thanks.
-
Yay! This was accepted, Thank you!
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.