White flicker on moving through UI after update to 4.2.3

josete2k

@pjft yeah, I've set your newest emulationstation as permanent and no flickering issue.

pjft

@josete2k wow, that was quick. Great to hear!

Let me know if you encounter any unpleasant side effects from using it.

josete2k

I see new settings

Multithreaded image load
Re-use theme images

Both ON, is this correct?

pjft

@josete2k oh. I thought the build I had shared didn't have those options visible. :)

Anyway, yes, both on will be how it'll be in the main build. So don't change them :)

josete2k

I don't know why but there is one controller.svg that doesn't show properly.

Fisrt time it was the arcade controller, but now is the SNES controller...

TMNTturtlguy

@josete2k after testing out you should add comments to @pjft pull request on github verifying you tested and if it works! github PR

pjft

@josete2k OK, well that's a problem. :)

I'll look into that. Any steps to replicate/video would be helpful.

If you disable both options, then, it should work for you, though that's not ideal.

Thanks for testing!

josete2k

@TMNTturtlguy I don't have github account, but I'll di. Thanks for the tip.

images:
before
http://i.imgur.com/87N2Ltv.jpg

after
http://i.imgur.com/fO2tIbn.jpg

With both options disabled all controllers are shown properly, but flickering returns (of course)

pjft

Oh, I see.

Correct, I can replicate it as well, as you leave the game. It happens because Carbon uses the SVGs in two different sizes, and when it gets back the first one it renders is the smaller version. Well caught.

I didn't expect you to have flicker with both options, in that the case, though.

Back to looking into this.

pjft

@josete2k If you turn both options off, and restart ES, surely you shouldn't see a flicker, do you?

You may see a slight stutter, as the images are now loaded before they're shown, but not a flicker as before. Do you confirm?

Also, what transition are you using - slide or fade?

josete2k

@pjft yes sorry, the white flickering was becuse I updated ES from the retropie menu.

Now, with both options in OFF the SVG loads a little slow than ON but is not noticeable.

TMNTturtlguy

@pjft do you suspect that is because the .svg has the same name? If it used two different names it would not be the case at it would "remember" them each independently?

Does this happen only within the same system you entered a rom in? Or all systems after entering a rom, exiting, and then switching systems?

pjft

@josete2k Correct. It should low slightly slower first time around (instead of flickering, it ensures it's loaded).

@TMNTturtlguy If the theme used two different names, that would likely work, but that would kind of subvert the purpose of having a SVG in the first place, which is to be able to resize it at will without quality loss - and if you can re-use it in the same theme, that should still be supported. Not to mention that it would take up double the memory, which is what the "re-use" option attempts to fix :)

I'll see what I can do about this.

I like to know that ON/ON and OFF/OFF are suitable solutions for different kinds of problems people have with themes, but I'd like to avoid OFF/OFF, precisely because of the performance hit.

Thanks a lot everyone! I'm calling it a night.

TMNTturtlguy

@pjft thanks for your hard work! Get some rest and have a nice night!

RedBatman

I'm just glad people here are so helpful

DarkWolf

@RedBatman
This community "offers" some very kind people! I love it

pjft

@josete2k I should have fixed it now. I'm trying to force the SVG to be kept in memory to always be the highest resolution used in the theme.

Hopefully this fixes things. Changes have been made both to this build as well as to the OMX branch.

Download and test using the exact same instructions as before - it's the same link. You'll know you're in the right one as it will no longer have the Multithreaded and Re-Use SVGs options.

To ensure you're using it right, though, you may want to remove the two new option values from your ES-Settings (multithreaded images, and re-use SVGs), or set them to "true, true" in your current build before reinstalling as they are now gone from the menu, and defaulted to "true, true".

All of you testing, let me know how it goes. And thanks a lot for catching that one yesterday, @josete2k !

Edit: I've been testing a bit more, and while it seems to be fairly improved, it's still not eradicated. I'll keep digging into this.

josete2k

@pjft yes flickering is still there.

TMNTturtlguy

@pjft I will be on late tonight, probably while you are getting some rest. I plan to test on my comic book theme and carbon theme. I will test with my 12 systems and then load up 20 or so and see what happens.

If there are any specific tests or things you want time to look into let me know here or on the PR comments. I will check both and report back. Thanks!

pjft

@josete2k hopefully the issue with the system logos has disappeared, though? And the flickering should hopefully not be as bad as it was before?

@TMNTturtlguy thanks. I'm trying one final thing - hoping it solves it, but compilation takes quite a bit, so still waiting.