Mortal Kombat 2/3/UMK3 Audio
-
this is now merged! if you rebuild lr-mame2003 from source (takes about 30 minutes) you will have it. can anyone test, please? i played mk2 for 10 minutes and got no distortion, but I didn't have a chance to test longer/other games.
-
I am at work today but I will get home and test MK2, MK3, UMK3, and I THINK Rampage WT did it too so I'll check 'em and post my results. Probably extensive play to make sure this is squashed.
-
@dankcushions said in Mortal Kombat 2/3/UMK3 Audio:
if you rebuild lr-mame2003 from source (takes about 30 minutes)
How do I do this, I never did this?
-
@greenhawk84 said in Mortal Kombat 2/3/UMK3 Audio:
@dankcushions said in Mortal Kombat 2/3/UMK3 Audio:
if you rebuild lr-mame2003 from source (takes about 30 minutes)
How do I do this, I never did this?
manage packages > main > lr-mame2003 > source
-
Eureka! It works!
-
Has the binary been updated in retropie with this fix yet?
-
Is it normal, when going into update the lr-mame2003 via source to get a black and white command prompt style screen full of garbage continually scrolling?
-
@darkmenace yes
-
Whilst I think things improved a bit with the sound, I was still getting a bit of crackling and crustyness. Is there any easy way for me to verify that I successfully updated lr-mame2003 package to the version with the fixed audio?
-
@darkmenace if you updated via source, you have the fix. if you go to the retroarch menu (hotkey + retropad X) in game, you can make a note of the version string at the bottom left and we can verify.
before the fix the sound would a garbled mess and out of sync after 10 minutes of play. anything other than that is a different issue.
-
@darkmenace yes the sound is not perfect in general but this was a fix for a large issue that occurred after ~10min of playtime.
As for the general crackle at times, that will have to be resolved separately, but not enough (IMO) for another community fund.
-
@dankcushions so I won't need to update any roms or rebuild my set, just the emulator from source and that's it?! Sweet!
-
It's the older DCS sound cores which cause the crackles in the sound this is gone by MAME84 and DCS was updated again come MAME85
but of course those versions lack the speedhacks however they can always be added back in to regain the performance boosts. -
The bug is re-introduced again in the latest lr-mame2003. Maybe someone can look at it.
For those who want to play now and without any issues, I've forked the Git project and created a branch named "mk3fix", which points to the revision, where the bug was actually fixed.
So you should open file RetroPie-Setup/scriptmodules/libretrocores/lr-mame2003.sh and replace
gitPullOrClone "$md_build" https://github.com/libretro/mame2003-libretro.gitwith
gitPullOrClone "$md_build" https://github.com/genius8086/mame2003-libretro mk3fixThen please build from source again.
-
your code base is seven months old the code changed since then youll introduce heap overflows.
The most likely cause of this is the dcs speedhack change now works it didnt before. The setting done nothing before
test your current code with mame2003 src/vidhrdw/midtunit_vidhrdw.c
(note fast dma is off by default now it used to be (both the hack and fastdma where on by default) I was against changing this
-
@grant2258 It is obvious that the code is outdated, I was trying to search the other forums to find out the commit e6bf01a531ec151ccec9f78dfaf87586574ee966 with fix. But the recent master has this "every 10 minutes cracking sounds" issue again. Maybe you can point to the commit, which we can use.
"dcs speedhack" - is it a core option which can be disabled?
-
yes it a core option is but it wasnt hooked up right on mame2003 in your revision. Basically both where on by default.
try mame2003+ i never changed it there
-
c3eaee3dc965f03b3b43d06b230ca7c99222ba08
abec426b21aa3ef06628402485078daa3c250e46are the commit changes your looking at for the mk change
fast dma and dcs hack used the old way was both where always on the new way fast_dma is off unless you the turn it on again this wasnt my choice like I said before. I personally think the fast_dma should be in a toggle switch as well instead of a pre-processor define
-
you can see when the dcs hack is working and when its not shadows will go on and off in mk2. you see in your revision of code it does nothing
-
had a quick look in all honest i havent been keeping up with mame2003 ive done a fix please test this when you have the time should fix any issues. The fix before worked but corrupted the heap for some games.
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.