Long standing ES bugs

[ruckage]

@jdrassa said in Long standing ES bugs:

@ruckage Posting here since it will be included with these fixes. I implemented image support for the the selector bar in the gamelist.

I have implemented two additional theme options. <selectorImagePath>allows you to set the path to the image. <selectorImageTile> allows you to specify if the image should be tiled. The image size is automatically set to the same size as selector bar. In addition, <selectorColor> will be applied to the image.

Any feedback/suggestions is welcomed.

Code is available here for anyone that wants to build it themselves.
https://github.com/jrassa/EmulationStation/tree/gamelist-fixes

Windows build available here:
https://ci.appveyor.com/api/buildjobs/mq89003fj8ai8v36/artifacts/EmulationStation-Win32.zip

And after all my hard work using overlays to theme the selector bar...... ;)

I'll test this out shortly but I'm sure it's going to be great. It will open up even more options to make unique looking themes.

[Syhles]

@jdrassa
Looking forward to these fixes and the selector image making it to the main branch, I'll test out your branch sometime this weekend.

Also off topic are you still working on variables for themes?

[ruckage]

@jdrassa said in Long standing ES bugs:

@ruckage Posting here since it will be included with these fixes. I implemented image support for the the selector bar in the gamelist.

I have implemented two additional theme options. <selectorImagePath>allows you to set the path to the image. <selectorImageTile> allows you to specify if the image should be tiled. The image size is automatically set to the same size as selector bar. In addition, <selectorColor> will be applied to the image.

Any feedback/suggestions is welcomed.

Code is available here for anyone that wants to build it themselves.
https://github.com/jrassa/EmulationStation/tree/gamelist-fixes

Windows build available here:
https://ci.appveyor.com/api/buildjobs/mq89003fj8ai8v36/artifacts/EmulationStation-Win32.zip

I'm getting a runtime error, am I doing something wrong?

I put this in the text list:
<selectorImagePath>./art/selector1.png</selectorImagePath>

[jdrassa]

@ruckage Sorry, poor testing on my part. The code is not properly handling the case where there isn't a selectorImageTile element. Just specify it as false and it should work. I will get that fixed soon.

<selectorImageTile>false</selectorImageTile>

@Syhles the variable work is pretty much done. I just need to finish writing up the documentation for it, but I keep getting distracting by other interesting ideas.

[Syhles]

@jdrassa
I'll probably install this branch tomorrow sometime. I'll post here how it goes.

I look forward to these changes making it to the main branch and the variables as well.

[ruckage]

@jdrassa said in Long standing ES bugs:

@ruckage Sorry, poor testing on my part. The code is not properly handling the case where there isn't a selectorImageTile element. Just specify it as false and it should work. I will get that fixed soon.

<selectorImageTile>false</selectorImageTile>

Doh! - I nearly tried adding that in as well but thought that couldn't possibly be the problem.

Just did a very quick test and it works brilliantly - look at all those pretty colours :D

I have one suggestion regarding this, currently <selectorScale> is a ratio of the line/text height which isn't very intuitive. Would it be possible for this to be a ratio of the screen height instead (like most other elements) or would that cause problems?

One quick point unrelated to the selector bar - it seems that the video snapshot scaling is broken in this build (see screenshot above - it's squashed) , not sure if you realised.

[lilbud]

@ruckage Has this been added to the Retropie ES?

[Syhles]

@lilbud
No these features haven't been added ​to the main branch (RetroPie's ES), you can test them to speed along the process of them getting added though.

@jdrassa
Tested this build, everything seems to be working as intended. Had no issues during testing and the selector image seemed to work perfectly fine. Also I have no video snaps so I can't​comment on them being broken.

[lilbud]

@jdrassa Could Selector Size be added as an element for the selector bar?

[ruckage]

@lilbud
It's already added (the height at least) <selectorScale>. The width is the width of the game list.

[lilbud]

@ruckage Could the width be changed with a separate element?

[jdrassa]

https://ci.appveyor.com/api/buildjobs/q63ax46bxlr37917/artifacts/EmulationStation-Win32.zip

Here is an updated Windows build for anyone interested.

<selectorScale> has been swapped out for `<selectorHeight>' which now functions like other sizes and is a ration of the screen height.

I also updated THEMES.md to document the new options.
https://github.com/jrassa/EmulationStation/blob/gamelist-fixes/THEMES.md#textlist

@ruckage I haven't seen any issues with video scaling.

@lilbud It is certainly possible, but I would need to be convinced it would be worth the effort. If you want the selector image to be wider than the text, you can use horizontalMargin. I can't think of a use case for having the image be narrower, but it could be achieved by having transparent space on the sides of the image.

[Syhles]

@jdrassa
I'll test out the new build later today.

[ruckage]

@jdrassa
Thanks. I tried the new build and <selectorHeight> works perfectly.

Regarding the video scaling, I'm not sure if it's affecting the videos themselves - I'm using Video view but without videos so it shows just an image preview instead.

You can see below, the preview images are squashed vertically, however in the latest standard version of ES it displays normally.

[jdrassa]

@ruckage I was able to reproduce the issue with the image scaling. Looks like it was an existing issue. My branch was a few commits behind the RetroPie repository. I updated it to pull in the latest changes and it is scaling properly now.

[Syhles]

@jdrassa
I haven't checked the build where you added the video fix, but I tried the one before that with all of the bug fixes, seemed to be working without any issues along with the selector image and scale, couldn't get anything else to act incorrectly as I don't have videos.

Do I need to check the video fix build as well? Or was that the only change?

[jdrassa]

@Syhles No need to check. The only change was to sync up with the RetroPie repository.

[Syhles]

@jdrassa
Then everything seems to be in working order from my testing.

[Syhles]

@ruckage
These changes have been merged to main RetroPie branch as of today.

[ruckage]

@Syhles said in Long standing ES bugs:

@ruckage
These changes have been merged to main RetroPie branch as of today.

Thanks, that's great. I'll get my themes updated then.