Please Test: Adding support for "All", "Favorites" and "Last Played" systems

pjft

@Hex Thanks.

On a separate note, I just tested your latest build and I do confirm that the description scrolls, as well as long game names on the game list!

The game names seem to stop at the end, which is the same as in the main ES.

I won't oppose, then, if the description stops at the end as well so you only scroll once, though ideally I'd be supportive of both stopping at the beginning, and not permanently looping. But that can be a separate change.

But we can probably discuss this further on the power savings thread :)

Hex

@pjft Agreed. Congrats on getting this merged.

pjft

~~Redacted~~

It's now available via Update from Binary in RetroPie-Setup. Thanks @BuZz - I had compiled the code earlier in the day and it was still 2.3.2 so I didn't know it was updated to 2.4.0.

Thank you!

pjft

@Hex Thank you! Looking forward to getting yours merged as well :)

BuZz

@pjft Is that build different from main ES master ? ES binaries are up to date (v2.4.0)

pjft

Everyone: it's now available via Update from Binary.

Thanks @BuZz - I had compiled the code earlier in the day and it was still 2.3.2 so I didn't know it was updated to 2.4.0.

I have removed that link - it was the same binary, but before the commit to update the version.

Thank you.

TMNTturtlguy

@pjft I am excited about this new update, i apologize for not being able to help test. I know you are very busy and I plan to read through a bunch of the posts when i have time to find out how everything works, but i was wondering if you have or if you will create a wiki for how to use the new features? No rush on any of this as it will probably be a few weeks before i even get to test this stuff out!

EDIT: Never mind, as i put my shoes on to exit the house i realized this is for Lastplayed/favorites/all games and does not yet include the custom collections :)

pjft

@TMNTturtlguy Well, I really should document that on the Wiki, even if it's only All / Favorites / Last Played. You're right. :)

I also dropped a ball a bit on the video screensaver and OMX Player wiki. I suppose I'll need to get to that.

First let me finish the custom collections bit, and then I'll pick that up.

Thanks!

cyperghost

I just created new thread: Which theme is ready for virtual system (3) and custom-collections (1)
Please help to collect date which theme is ready and which means maintance

red2blue

@pjft as mentioned 3 times earlier, i killed ES.

killall emulationstation in putty

there was something wrong with the source. because it froze numerous times.

red2blue

Glad to see its updated to binary! after hours and hours trying to get this to work with @cyperghost i can finally run latest build

red2blue

Expletive... It wont let me update from Binary. i'm getting git pull error. and its telling me something about theme.xml .....
alt text

pjft

@red2blue Well, ES seems to have updated anyway. You're getting an error updating ES Themes. Did you per chance edit it on your end?

As mentioned, by the way, you'll need either to update to the latest Carbon version via RetroPie-Setup, or use any of the other supported themes.

Best.

red2blue

@pjft yes i manually edited carbon to add ratings in gamelist. i tried bringing it back to normal but no avail. ..... its under /etc/emulatiosntation/themes/carbon correct??? should i just uninstall carbon first? then install? then install binary?

Im also using comic book theme right now and i didnt touch the theme on it so idk whats going on =/

red2blue

Okay uninstalled carbon and reinstalled, and it updated.

Okay now my current problem. im under the gamelists and I cannot press a button to favorite a game.

red2blue

Fixed my error from above.

@pjft Could you possibly make it when we favorite a game it displays a heart next to the favorited game in game list? basically they do this in Kids Mode, and in recalbox. Also all the favorited games in that collection are on the top of the list.

Found bug: When playing a game now, runcommand doesnt show. it takes me to the command line of retropie for about 3 seconds then opens the rom.

red2blue

Another bug found, when I changed sort in gamelist to Ratings Ascended it crashed my pi.....

Why was this released? this is still way too buggy!!

EDIT: after rebooting, runcommand is now showing.

pjft

@red2blue please wait and take some time to actually go through things before calling out that everything is effectively buggy or not at the first sign of something not being as you expect. It'd be somewhat appreciated as there are plenty of people that have been testing it and helping with it for the past several weeks.

Can you please summarize now effectively which bugs are you experiencing so I can troubleshoot? What crashes are you getting, and how can we replicate it?

Any more information would also be helpful, like what message you get from the crash, etc.

In regards to adding a heart, that is not going to happen, at least for now.

It has been discussed quite a few times in the thread as to why not, and what's being done in that regard.

Thanks and happy Sunday.

Edit: as you now know, run command not showing happens if you launch EmulationStation via the command line.

If you can video what you do to crash it, it'd be helpful.

I believe you were using kids mode beforehand? Maybe sharing your previous kids mode gamelist for the system with the game you're having trouble seeing to favorite will help, but this should use the same info from there.

Edit 2: rating ascending wasn't touched in any way, and hasn't been for a while. You may want to share the gamelist for that system, but I bet it's more of a problem with the metadata in the gamelist. Values should be between 0 and 1, and should be numbers.

Is that really your only problem now, just to confirm?

I had received an email claiming things were crashing when you favorited something but I find no more mention of it here... If it's no longer a problem can you tell what happened and/or how you fixed it?

Thanks.

Hex

@red2blue Adding to what @pjft said, I would like to tell you that many of the things you find buggy are because you have done some things and have not shared this information while reporting these bugs. It is like saying that your car is going backwards rather than forwards while omitting to inform us that you shifted to Reverse thinking R was for Racing :P

Also wait for some time, think and try to debug, and document all changes that you are making . This will allow us to determine if its a bug or not and if it is then rectify it.

pjft

Just to add:

I tested sorting by ratings ascending and descending in several of my libraries, and it seemed to work reasonably well. Also, as I said, I don't think that has been touched in ages.

If you do have a system for which this kind of sorting is crashing (or several?), please share the gamelist(s). I'd venture a guess that it is down to the metadata you have there on the ratings, and maybe it's sourced from a specific scraper or source - and that can help narrow it down.

But I'd be surprised if it wasn't crashing before - and you probably can easily test it by re-installing the Kids branch if you'd be so inclined and testing whether that crashes the same way or not.

Do let us know what you're experiencing and what is, effectively, still a problem - we're keen on helping.

Thanks. Happy Sunday.