Please Test: Adding support for "All", "Favorites" and "Last Played" systems

cyperghost

@mediamogul ES can be initated to do a shutdown/restart by outside call :)
Read here
and here

cyperghost

@mediamogul @saddys
The magic to force ES to shutdown/restart is

create a file es-restart or es-shutdown in /tmp folder (we use touch command) take care of user. The file must belong to user:group pi:pi
kill the ES binary process only! (we use pkill or pgrep "/opt/retropie/supplementary/.*/emulationstation([^.]|$)") call to kill or optain ES binaries PID ONLY!!! Never use killall command!

voila ES will shutdown or restart

EDIT:
The modified part is the code block between the both
#End Emulationstation if condition of running binary is true (v1.5) lines

mediamogul

@cyperghost

Very nice! I have a script of my own that would benefit from this. Thanks.

TMNTturtlguy

@cyperghost this looks familiar! :)

cyperghost

@tmntturtlguy Not at all
Since we have tons of mausberry users here they loose favourites and last played list of they push the button. So indeed I exchanged the es-restart file simply with es-shutdown and it works like a charm (That was version 1.2)

But now we ( @meleu and me) want to 100% kill all emulators if you are within a game and press the shutdown button. So we kill the emulators, wait a few seconds so that ES can save XML-files and then shutdown ES with familiar method :)

But we know it was YOU that asked for a "simple" method to restart ES via bash :D

btw. @meleu is working on a new version (1.7) on this script that will asure that really all emulators will be catched up. In 1.5 there might be emulators (ScummVM for ex.) that can't be properly closed.

saddys

@cyperghost Thanks but it seems too much complicated for me, i'm new in this world :) i will use systems quit and amen

cyperghost

@saddys Also a solution but @meleu is a talented code writer and I think he is willing to help you - if you ask.

pjft

@cyperghost if @meleu could be paid for his code in RetroAchievements currency, he'd be all over that :p

saddys

@pjft, thanks for your job, very Thanks!

cyperghost

@pjft One line of code one CheevoPoint? We know @meleu is used to RegEx so one exchanged character one Cheevo?
I'm a bit unware of the currencie calculation

@mediamogul @TMNTturtlguy and @saddys (You will surly learn something of this also)
I updated the PID detector to v1.1
It's a great tool to detect PIDs of running emulators and the ES binary.

To escape ES it's also an easy achivment now. Just kill the binary ES without creating any file (no es-shutdown, no es-restart). That's it!

pjft

@saddys thanks! Hope you have fun with it.

@cyperghost i think that's kind of the current exchange rate, 1 line per cheevo point :)

BigMan1982

When I scroll through my "ALL GAMES" collection in ES it freezes the whole system and I have to pull the plug to reset the system. It always freezes around the game titles that start with "mu". I deleted a game and it still froze on the next one! I noticed that "mu" titles are the approximate center of my list, maybe that has something to do with it. I can scroll past the same bulk of games in my MAME system list with no issues. Any ideas? Anyone else see this?

I am running an overclocked (1.3) Pi3 B+, 5V 3A p/s, with Motion Blue V4, ES V2.4.1RP and Hursty Blue theme.

TMNTturtlguy

@bigman1982 how fast are you scrolling? Maybe ES is running out of memory if you are scrolling to fast? Have you tried to slow down when you get close the area of freezing and then click through the games? What is your VRAM set too?

ohmycommodore

@bigman1982 i've wondered whether All Games would be taxing when trying to navigate through it. there's not a huge use for that collection, in my case at least, compared to the others.

TMNTturtlguy

@ohmycommodore you can turn it off if you don't use it!

pjft

@bigman1982 there shouldn't be any problem, but I'd be keen on learning more. How many games do you have? How are you scrolling (down? R1?)? What video player are you using? VRAM setting? And if you said that you deleted a game and then it crashed on the next one, it seems it's on a very specific game or set of games. What happens if when you get there you jump over those games with R1? What's the last game it works in and the one that it fails? What happens when you scroll to those on their normal gamelists?

Let me know.

EvilDindon

Sorry if it has already been posted.

I came across some bugs regarding the Favorites menu.

Some items (games) disappear from the favorites, for some reason.

But hey, this may be my fault though, not sure, as I often delete some xml files after scraping systems the bad way.

Favorites are listed in an xml file somewher ?

Is it a known bug ?

Cheers.

Forgot to mention that I often change theme, for testing : this might be the cause of the disappearings ?

pjft

@evildindon favorites are indeed metadata from the games, stored in the gamelist files. If you re-scrape or delete those files, they will certainly be deleted.

Also note that metadata only saves on closing of ES, so if it crashes it won't save them.

Could that be what you're going through?

Best.

EvilDindon

Hey thanks, I perfectly understand now.

Re-scrape = bye bye favorites.

Good to know. ;)

BigMan1982

@tmntturtlguy speed does not matter, I have tried slow scrolling too. Thanks.