Please Test: Adding support for "All", "Favorites" and "Last Played" systems

cyperghost

@pjft de nada

TMNTturtlguy

wow, I travel for work for 2 weeks and the world has turned upside-down! This stuff looks incredible, but I just got a setup that is working wonderfully......I guess i better buy another pi and start a fresh build!

cyperghost

@TMNTturtlguy
There is no need for a second PI... The make process runs wonderfull and you can exchange the compiled binary with the binary in /opt/retropie/supplementary/emulationstation/
Don't worry you won't mess up the system :)

I can provide binaries:
https://github.com/crcerror/emulationstation-binary-archive

Hex

Actually this is a great idea to provide compiled binaries on github with proper versions and features.

cyperghost

@Hex That's a bit hard to handle. I think main feature, author and ES version should be enough.
But everybody is free to fork and add the archive :)
I hope the archive will make development faster and more accurate because more users can simply download and try out versions.

In the repo...

If there is no @ in the name then it's a main branch release within RetroPie
authors of the branch are names by adding @name to the file
main features are named within file name

for ex. emulationstation2.1.5RP means main realase of ES from RetroPie in ES version 2.1.5
for ex. emulationstation2.2.4RP PS @hex PowerSavingsmeans ES branch from @hex with PowerSaving feature with ES version 2.2.4

Hex

@cyperghost said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

@Hex That's a bit hard to handle. I think main feature, author and ES version should be enough.
But everybody is free to fork and add the archive :)

I mean for a tester to do and not the developer. The dev cannot keep on sharing the binaries as they are much busy compiling

cyperghost

Added @pjft file to binary archive RPI2/3 only

https://github.com/crcerror/emulationstation-binary-archive

How to:

Copy file from repro and rename it back to emulationstation
Rename file emulationstation in /opt/retropie/supplementary/emulationstation/ maybe emulationstation.org >> That's your backup!
Copy repro file to /opt/retropie/supplementary/emulationstation/
User rights 755 root:root

@Hex I wans't able to merge your Powersaver Patch together with @pjft
I added

https://github.com/hex007/EmulationStation feature-powersaver d2aa4861704e4d93659246c13ecc982a6fd18314 Hex's powersaver patch

to es-patches.txt but I wasn't able to select this patch. Just the Repro was available.

meleu

@Hex hey bro, do you recommend some cross compiling guide? Compiling ES on my raspi1 is very time consuming and on my laptop take 2 or 3 minutes. I compiled the very first version of the @pjft 's PR and it took almos 4 hours on my raspi1. Now I don't have the guts to compile the new changes we are getting (I would like to test/provide feedback about two PRs you submitted too).

cyperghost

@meleu Maybe I uploaded the file you need already.
https://github.com/crcerror/emulationstation-binary-archive

--

Sorry @pjft your branch work wonderfull. I can even favourize the favourites of Little Favourite Launcher and it works flawless ;) Thank you very much I'm looking forward that the next release will be a burner :)

One suggestion. The "Added xxxxx to favourite" beacon is in the middle of the upper screen. May you can set it to right down corner?

Little Bug if you add a Favorite within the auto-favorite then ES will give error message segmentation faultand the binary is killed

Hex

@meleu Thats the beauty i work with. I write all my code on my linux system only. I test it on rasp pi only when i reach a workable copy. skipping make clean should reduce the compile time. The thing is the higheryour changes are in the hierarchy the more files are compiled again. If you have a Pi3 i would suggest compiling on that. It is fast on pi 3. Use 2 or 3 cores only and not all 4 else you will run out of ram.

I do not have a cross compile setup. I never have used one.

Hex

@cyperghost Did you atleast see the patches menu?

 es-dev.sh (version: zeta.2) - manage EmulationStation mods on your RetroPie
 ────────────────────────────────────────────────────────────────────────────

┌─────────────────────────────────────────────────────────────────────────┐
│ Would you like to apply any patches from es-patches.txt or remove all   │  
│ patches applied to this repository?                                     │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
│                                                                         │  
├─────────────────────────────────────────────────────────────────────────┤  
│                       < Yes >            < No  >                        │  
└─────────────────────────────────────────────────────────────────────────┘

cyperghost

No... This windows I had never seen.

I tried manually via the github commands you posted... But then there was an error message about the cherry pick, that I can't commit the file.

git clone --recurse-submodules https://github.com/pjft/EmulationStation -b RetroPie-Virtual-Systems-PR pjft-vs

mkdir pjft-vs/build && cd pjft-vs/build

git  fetch https://github.com/hex007/EmulationStation feature-powersaver
git cherry-pick d2aa4861704e4d93659246c13ecc982a6fd18314

git clone works and downloads pjfts branch
of course works
git fetch also works
did not work

Hex

@cyperghost please post the error that you get.

cyperghost

from git fetch https://github.com/hex007/EmulationStation feature-powersaver

pi@retropie:~/pjft-vs/build $ git  fetch https://github.com/hex007/EmulationStation feature-powersaver
From https://github.com/hex007/EmulationStation
 * branch            feature-powersaver -> FETCH_HEAD

from git cherry-pick d2aa4861704e4d93659246c13ecc982a6fd18314

pi@retropie:~/pjft-vs/build $ git cherry-pick d2aa4861704e4d93659246c13ecc982a6fd18314
error: Your local changes would be overwritten by cherry-pick.
hint: Commit your changes or stash them to proceed.
fatal: cherry-pick failed

Hex

@cyperghost Okay i get what is happening. follow these commands and post on success or failure (post error messages too mate)

git cherry-pick --abort
git reset --hard
git cherry-pick d2aa4861704e4d93659246c13ecc982a6fd18314

lilbud

I updated to the newest version. How do you create game collections?

I see the game collections settings menu, but how does it all work?

cyperghost

@Hex That worked!
Thank you mate ... I had to fill out credentials in git -- git config -- but now the branch is merged!

It works like @Sano already wrote. If there is no action in ES the CPU load on a Raspberry gots down from 15-20% (without PS) to only 0,3% really amazing.

I'll upload to github >> https://github.com/crcerror/emulationstation-binary-archive

pjft

@lilbud Sorry, I wasn't clear.

There are still no custom collections yet - this is still only the same work posted a week or two ago. It received some very timely and reasonable feedback during review, and I have now incorporated most of it here. As such, before it can effectively be merged, I've just posted it here for a new round of testing, to make sure nothing new is broken.

It still only has "All", "Favorites" and "Last Played".

After these are closed, we'll move on to the next stage.

Thanks!

cyperghost

@pjft I have some suggestions/question for improvment (personal note) - most are just cosmetic and some may be out of your scope

Can you make in all-games the systemsname[gb] [nes] [....] look uppercase? I think that looks better (That are my personal experiences in developing an own favourite system)
The "xxxx has been added to favorite"-badge is now popping up in the upper middle screen area - I think making it right down corner may look a bit better
A small bug.... If you press Y if you are already in favourites it will break ES and you are in terminal mode (I know it's still on development. I think in future this will remove favorites)
I think we can reserve the X-button for annother function in carousel (=system select) mode rather than random select for whole system. Random select would be an option if you are in the games list. So you randomly select a game for MegaDrive if you are in MD, for Gameboy if you are in GB.... And you still have the function working like now if you press X in the auto-allgames VS. Why am I asking? I have a lot of ATARI 2600 roms, but just a few of them I really want to random select. So the function for now is a bit weird because I randomly get lot's of ATARI roms :)
Search setting A-Z if you press select in game selection was in older ES version on first place. Why not back to normal?
Thank you again for your straight development - Keep on the good work!

Just my one cent ... Have a nice weekend. I'm on buisness yourney again :(

pjft

@cyperghost Thanks for the detailed post!

Answers inline:

@cyperghost said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

Can you make in all-games the systemsname[gb] [nes] [....] look uppercase? I think that looks better (That are my personal experiences in developing an own favourite system)

Oh. I didn't notice that it wasn't - my theme is indeed in all caps.

I can certainly force it to be all caps - good call.

The "xxxx has been added to favorite"-badge is now popping up in the upper middle screen area - I think making it right down corner may look a bit better

I thought about this - even top right, like traditional popups from your browser or PSN. In the end I deliberately chose to make it show up on top center because different themes will have something in most other locations (bottom right is usually either the description, or the games list for some themes; Top left is usually an icon, system name, or games list; top right same). Top center seems to be the least bad option, and also it's sure to be noticeable by people. Furthermore, it is aligned with the EmulationStation menu, which also shows up aligned at center.

A small bug.... If you press Y if you are already in favourites it will break ES and you are in terminal mode (I know it's still on development. I think in future this will remove favorites)

Huh. It should certainly remove favorites, and in my tests so far it had worked as intended, so that's good to know!

Can you give me some step by step instructions on how to replicate that? I'll try it later as well, as maybe some of the most recent changes made that happen. That is not intended.

Is it when you only have one game in the list?

Thanks for catching it!

I think we can reserve the X-button for annother function in carousel (=system select) mode rather than random select for whole system. Random select would be an option if you are in the games list. So you randomly select a game for MegaDrive if you are in MD, for Gameboy if you are in GB.... And you still have the function working like now if you press X in the auto-allgames VS. Why am I asking? I have a lot of ATARI 2600 roms, but just a few of them I really want to random select. So the function for now is a bit weird because I randomly get lot's of ATARI roms :)

I understand the use case. I will not change the behavior of the Random button in this PR, as that's a separate scope, but while I do use the "Random game for the entire collection" feature quite a bit, at times I have personally also felt the need for a use case where I'd select a random game in the current list only.

@Zigurana is the brain behind that feature and use case, so I won't change that without his feedback. That being said, if we now have an "All Games" collection, I can certainly see how we could restrict the "Random Game" selection to the currently selected system, and if someone would want to select a random game across their entire collection, they can achieve it via pressing "Random" while on the "All Games" list.

But it's not my call here.

Feedback appreciated, though - especially as I have also felt the need for that at times, when I just want randomly explore my Arcade collection, or NES collection.

Search setting A-Z if you press select in game selection was in older ES version on first place. Why not back to normal?

That has been flagged in the past. I believe @dankcushions has just submitted a PR for that, so that should be fixed soon!

Thank you again for your straight development - Keep on the good work!

Not at all, thanks for the feedback.