Removing unused features

Zigurana

@mediamogul I was going to bring up the same thing, as we have the shortcut, there is little use for this menu item.

EctoOne

The only useless thing i can think of is the Thumbnail field from the Metadata section.

cyperghost

@hex @pjft
Can you estimate which functions seems to have heavy weight in source code? I think the removal of the "Surprise me feature!" is nearly effectless.... seems that this are only a few lines of code.

Scraper feature
OMX Player support
Metadata editor

I may worth a look to extract this features out and integrate them in an extra binary that is called within ES. So we call about kind of dll or an ES with advanced APIs

Hex

I think metadata editor is not that important as you can always remove sdcard and edit the MD

Since random game is handled by X removing the corresponding menu item is not a problem.

cyperghost

@Hex Scraping can be resolved by external programm!
You click on one entry in Gameslist and want to scrape this then you give call to external programm >> remove possible

The Scraper itself can also be removed to external program!

TMNTturtlguy

@Hex I disagree, I use the metadata editor frequently. Every now and the I find an error in the scrape, or the games with Multiple versions like Mortal Kobat Mortal Kombat II and Mortal Kombat 3 are listed out of order because of there actual names mix number and letters. I use the meta data editor to make changes on the fly without having to go to my computer. I also like to change game ratings from the editor. This is another example of things that you might think most people don't use, but for those of us that do, it will make us unhappy. Sorry to be negative as I know you are trying hard to come up with a positive fix for us.

Hex

@cyperghost I am of the opinion that scrapper editor should be replaced by scrap this game now option. so it is possible to run scrapper with a single game only

Hex

@TMNTturtlguy This thread is to get your opinions. It doesnt offend me if your opinion contradicts mine.

A Former User

Removing features is a bad idea period. I can't imagine any single feature is leading to code bloat and removing a feature is the slipperiest of slopes.

That's my two cents.

Hex

@LiveFastCyYoung said in Removing unused features:

Removing features is a bad idea period. I can't imagine any single feature is leading to code bloat and removing a feature is the slipperiest of slopes.

That's my two cents.

I am also of the same opinion but there comes a time when things start getting too extensive.

Based on these comments

Random game in menu can be removed as it is duplicated by a key binding.
No feature can be removed
Code must be simplified/optimized somehow (reworked).

cyperghost

@LiveFastCyYoung @TMNTturtlguy
This is just a thread we discuss what is possible and what not.
It's worth to think about. What will really happen nobody knows - but there is need to maintain code.

Zigurana

The trigger for this was mostly the ever increasing amount of RAM neede to compile ES.
Part of this is due to increased code complexity. Another part is due to CLOAD (coding-like-on-a-desktop), while the raspberry-pi cannot deliver the same amount of 'umph' as our big boys.
For example we've recently included another boost library, to enable regexp. We are also rather free with the include scope, and sparse with forward declarations when possible. I feels there is quite a lot to be optimized in that regard, before we even need to start thinking about removing functionality.

Further splitting up the code base into core, app, scraper/MD editor, might help a bit, not sure how much.

Still think we should clean up the menus, and remove the "surprise me" entry, because it's a leftover from a bygone era (before the introduction of the hotkey).

lostless

@mediamogul Just a FYI, On the new 2.4.0 now only randomizes the system you are in. So if you're in NES and hit X, it will randomly select an NES game. The surprise me works like the old random. I guess now you can go to "All games" and then randomize it.

Zigurana

@lostless indeed

Hex

@Zigurana Can yo elaborate why regex was included?

cyperghost

@lostless That's a good case.
The old system made random of full gamelist which - you explained - is still available. But I have 2500 VCS (Atari 2600) games and it was really nasty to randomize and get these games as result. The better usecase is, to choose a system and then randomize the choosen-system gamelist.

lostless

@cyperghost I was just making an observation after I got 2.4.0 running and adding the new theme folders. I would sometimes just randomly close my eyes and start a random game pressing X a bunch of times only to realize it was just randomly changing the carousel. Now if i can only figure out how to make the new folders label Genesis games as "Genesis" and not mega drive. But thats a topic for another thread.

Zigurana

@Hex Apologies, I mis-remembered.
It was boost-string that is now used when parsing comma separated strings in filter expressions, I believe.
In any case, that was not really the point. I think it is possible to optimize ES quite a bit more, if we are really going to make this tuned to the pi. You've shown this already with the power saving you were able to realize!

mediamogul

@lostless

@mediamogul Just a FYI, On the new 2.4.0 now only randomizes the system you are in. So if you're in NES and hit X, it will randomly select an NES game. The surprise me works like the old random. I guess now you can go to "All games" and then randomize it.

I noticed that last night. IMO It's a huge improvement in functionality and I spent well over six hours trying random games, both globally and system-based. Very, very keen and much appreciated.

pjft

@Hex said in Removing unused features:

@LiveFastCyYoung said in Removing unused features:

Removing features is a bad idea period. I can't imagine any single feature is leading to code bloat and removing a feature is the slipperiest of slopes.

That's my two cents.

I am also of the same opinion but there comes a time when things start getting too extensive.

Based on these comments

Random game in menu can be removed as it is duplicated by a key binding.

No feature can be removed

Code must be simplified/optimized somehow (reworked).

Until we have proper analytics in place, I cannot vote for removing anything. We had similar conversations in the past, recently. For any case we can think that we have a workaround as advanced users, several others will suffer. Scraping and Editing Metadata on the Pi is needed because not everyone has SSH access, and not everyone can read a SD card with a EXT4 file system on their computers, for instance.

While there are a few things I can certainly suggest from my lack of use that could be removed, it wouldn't be representative, to be honest.

There are a few minor things that can be done here and there, but the cosmetic things mostly boil down to better UX rather than a significant reduction in code complexity - for better and for worse.

As far as code health goes, there certainly are several improvements that can be done - quite a few refactoring work going on between @Hex, @Zigurana, and @jdrassa 's work, which will certainly yield good results in the long run.

I mean, things that could be removed off the top of my head would be:

The "Surprise Me" button (I'm sorry I left it there in my last change on the Random behavior, but it's mostly a UX thing)
The "MAME name mapper" is questionable, but I'm sure some users still benefit from it. Code complexity is likely minimal.
Refactoring/simplifying the GUIs and Views may yield some interesting results, but I have no evidence of that.

All in all, though, as @BuZz mentions, RetroPie provides builds for the users. If it's a problem for testers, we can provide builds ourselves if needed.

It's not that it wouldn't potentially be helpful, but I wouldn't support removing features blindly. Refactoring or simplifying code, I'm all for that.

Ultimately, if we think about it, this is mostly a pain for us - the developers. I don't think we should have things made necessarily "simpler" for us at the expense of the end user. We should aim to strike a balance, and hopefully maximize both.

My 2 cents! Thanks for bringing it up :)