Versatile C++ game scraper: Skyscraper

AnalogHero

@muldjord Im zipping it right now. Note that the same thing happens for other system too. Tried amiga, same result.

muldjord

@analoghero I think I have a lead now... I think it's related to how I handle platform detection with the screenscraper module in 2.3.0. What I don't quite understand is why it returns the "hack-LINK" game in the first place, that shouldn't happen at all!

I have to go to work now, your help is appreciated. I really want to squash this bug, so I'll be back later to ask more questions if that's ok. In the meantime, can I ask you to keep your dbs's as they are? I would hate for this problem to go away without me knowing what happened. :)

AnalogHero

@muldjord Uploaded it.

Megadrive.zip

hi_im_daft

Japanese-release only PSP title being returned for all scrapes? That's an odd one. :-|

muldjord

@analoghero Thank you so much, I've downloaded it. Could you also do me the favor of running the command "ls -l /home/pi/RetroPie/roms/megadrive >> /home/pi/megadrive_ls.txt" and send me the megadrive_ls.txt it creates? I need as much information as I can get to reproduce this.

muldjord

@analoghero Also, could you try running it with "Skyscraper -p megadrive -s screenscraper --updatedb --region wor" and see if that still returns the ".hack-Link" results?

AnalogHero

@muldjord Ive uploaded to the same folder as before.

Edit: The command above has the same result.

A Former User

https://retropie.org.uk/forum/topic/16059/sselph-scrapper-getting-strange-results

Sselph scraper has the same issue with scraping that .hack//link game.

muldjord

@livefastcyyoung Thank you!!! This is really helpful, it tells me a lot about what is going on. I still don't know why it scrapes ALL games like this for AnalogHero though. I'll investigate this further and provide a fix once I figure out how to do it properly.

For now, if any of you guys are having the same issue, please let me know!

EDIT: It seems to be an error on screenscrapers part, returning faulty results, maybe because of some server issues they are having. So this problem might go away by itself. Still problematic though, as the localdb will be updated with this faulty data, so anyone haveing the issue will have to rescrape with '-s screenscraper --updatedb' once the problem is fixed on their end.

AnalogHero

@muldjord After further tests on my end, i think screenscraper has issues as you said. Even when scraping a single rom it returns .hack-link :(

muldjord

@analoghero yeah, but it doesn't seem to be a general problem. I don't get the errors here. Maybe they have 1 server that causes this. And because they use load-balancing I just happen to reach one of their servers that works fine.

AnalogHero

@muldjord Not your fault ofcourse, but this problem makes 2.3.0 not very usefull atm, because screenscraper has the most images.

muldjord

@analoghero Yes, agreed. But as you say, I can't really fix that unfortunately... I will look into the problem further when I get home though. I'm curious as to what is going on and would like to know why it returns the ".hack-Link" result in the first place... :S

EDIT: And let me just say that I find it quite unfortunate that it had to coincide with my 2.3.0 release. :D I had been testing and testing and to read about such a weird problem seemingly breaking the results for you made me think I had overlooked something really obvious... So I'm "glad" it is seemingly not a problem on my end. Sad that screenscraper is having issues of course, it really is a fantastic source when it works.

A Former User

@screech Might be able to add some suggestion as to what is happening at Screenscraper. Unfortunately it looks like he hasn't been on the forum in the last month.

bleuge

@muldjord many many thanks for the hardwork in this version, as i said, best scraper around.

@analoghero said in Versatile C++ game scraper: Skyscraper:

.hack link

I was getting this a lot other day,
Maybe Skyscraper simple could check if .hack link is returned from screenscraper, and if the file is not .hack link (words in filename), simple skip it?. Better to have nothing that a wrong result?

muldjord

@bleuge Agreed, I would like to filter those out so it doesn't overwrite valuable data in the localdb. Still curious as to why screenscraper returns it in the first place. I hope they know about it and fix it.

AnalogHero

@muldjord I hope that, too. Dont know how to contact them, though.

bleuge

@muldjord confirmed that sselph also does the same. Screenscraper works with hashes in the api? Maybe is some error returning wrong data when no hash is hit

muldjord

I've now implemented a simple check for ".hack-Link" which will simply filter it out. It will be in 2.3.1 soon. I am currently looking into the "players" parsing to make it single digit.

bleuge

@muldjord Great!

Installed new version, i can see ocasionally "libpng error: Read Error" in the texts in screen.

Can i suggest --showlocaldb_stats or something like this?
I'd love to see the total differences in my localdb between runs.
Also per-platform and a total at the end could it be great!

Sorry for asking so much :) ... Could a debug log be enabled? So reporting errors and testing this could be made a lot easier?

Thanks muldjord!