RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login
    Please do not post a support request without first reading and following the advice in https://retropie.org.uk/forum/topic/3/read-this-first

    [SOLVED] lr-px68k not build anymore

    Scheduled Pinned Locked Moved Help and Support
    lr-px68k
    26 Posts 3 Posters 2.3k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • H
      hhromic @DarishZone
      last edited by

      @DarishZone said in lr-px68k not build anymore:

      Yeah man, very similar :o
      There's some temporary fix like lr-scummvm? I can edit .sh file but need some help on your end :D Thx so much

      It is fixed already upstream and in RetroPie :) Just update your RetroPie-Setup script and re-compile lr-scummvm. You also will get a newly added option to adjust the mouse speed when using a real mouse.

      D 1 Reply Last reply Reply Quote 0
      • D
        DarishZone Banned @hhromic
        last edited by

        @hhromic said in lr-px68k not build anymore:

        @DarishZone said in lr-px68k not build anymore:

        Yeah man, very similar :o
        There's some temporary fix like lr-scummvm? I can edit .sh file but need some help on your end :D Thx so much

        It is fixed already upstream and in RetroPie :) Just update your RetroPie-Setup script and re-compile lr-scummvm. You also will get a newly added option to adjust the mouse speed when using a real mouse.

        I explained me bad, i've already fixed lr-scummvm, just asking if there's similar method for lr-px68k, but i guess is a no at moment :p

        mituM H 2 Replies Last reply Reply Quote 0
        • mituM
          mitu Global Moderator @DarishZone
          last edited by mitu

          @DarishZone You'll have to have more patience until it gets fixed.

          D 1 Reply Last reply Reply Quote 0
          • D
            DarishZone Banned @mitu
            last edited by

            @mitu said in lr-px68k not build anymore:

            @DarishZone You'll have to have more patience.

            Fair enough :D most important thing is that the issue is aknowledged

            1 Reply Last reply Reply Quote 0
            • H
              hhromic @DarishZone
              last edited by hhromic

              @DarishZone ah I see. For the moment better is to wait for mitu to find out exactly how to patch the Makefile. Then it probably will be sent as PR upstream.

              What you can do in the meantime is to force compilation iwth the previous commit, before it broke. For this, edit the scriptmodule and change the relevant line to this:

              gitPullOrClone "$md_build" https://github.com/libretro/px68k-libretro.git master c36fafd35094df918f037bea333d7707e656128a

              Don't forget to revert this temporary fix when all is fixed upstream.

              Edit Sorry I made a mistake (put master after the hash). Corrected now.

              D 1 Reply Last reply Reply Quote 0
              • D
                DarishZone Banned
                last edited by DarishZone

                Ive made edit and now Retropie Setup give me an error

                Edit: Saw later the fix! Will try new line

                1 Reply Last reply Reply Quote 0
                • D
                  DarishZone Banned @hhromic
                  last edited by DarishZone

                  @hhromic said in lr-px68k not build anymore:

                  @DarishZone ah I see. For the moment better is to wait for mitu to find out exactly how to patch the Makefile. Then it probably will be sent as PR upstream.

                  What you can do in the meantime is to force compilation iwth the previous commit, before it broke. For this, edit the scriptmodule and change the relevant line to this:

                  gitPullOrClone "$md_build" https://github.com/libretro/px68k-libretro.git master c36fafd35094df918f037bea333d7707e656128a

                  Don't forget to revert this temporary fix when all is fixed upstream.

                  Edit Sorry I made a mistake (put master after the hash). Corrected now.

                  IT WORKS! You're frigging brilliant man, thank you so much :)))

                  H 1 Reply Last reply Reply Quote 0
                  • mituM
                    mitu Global Moderator @hhromic
                    last edited by

                    @hhromic said in lr-px68k not build anymore:

                    I also was wondering the same thing but was confirmed to me that it's not public. You can get access to it in the Libretro Discord dev channel.

                    https://travis-ci.org/libretro/px68k-libretro - it looks like it's failing proper. Either removing the -Wl,--no-undefined or compiling with $(CXX) works.

                    H 1 Reply Last reply Reply Quote 0
                    • H
                      hhromic @DarishZone
                      last edited by

                      @DarishZone I'm glad you got it working for now.
                      Don't forget to revert this change when @mitu reports back a proper solution later, and before updating RetroPie-Setup again.

                      D 1 Reply Last reply Reply Quote 0
                      • D
                        DarishZone Banned @hhromic
                        last edited by

                        @hhromic said in lr-px68k not build anymore:

                        @DarishZone I'm glad you got it working for now.
                        Don't forget to revert this change when @mitu reports back a proper solution later, and before updating RetroPie-Setup again.

                        Thanks man, i already reverted change now, will that make a difference? Im afraid to forget if i do later

                        H 1 Reply Last reply Reply Quote 0
                        • H
                          hhromic @mitu
                          last edited by

                          @mitu said in lr-px68k not build anymore:

                          @hhromic said in lr-px68k not build anymore:

                          I also was wondering the same thing but was confirmed to me that it's not public. You can get access to it in the Libretro Discord dev channel.

                          https://travis-ci.org/libretro/px68k-libretro - it looks like it's failing proper. Either removing the -Wl,--no-undefined or compiling with $(CXX) works.

                          ah good to know how to access their CI! In here a dev told me I needed Discord access. Thanks for the tip.

                          Regarding the candidate fixes, I chose to remove -Wl,--no-undefined (I was setting it in the scriptmodule) together with properly setting LDFLAGS and not rely on re-setting LD. They have been pushing these updates recently to many cores, i.e. standardising to set LD = $(CC) so there are high chances it can get reverted again. So that would be my advice.

                          Their makefile management is def not ideal ...

                          1 Reply Last reply Reply Quote 0
                          • H
                            hhromic @DarishZone
                            last edited by

                            @DarishZone said in lr-px68k not build anymore:

                            @hhromic said in lr-px68k not build anymore:

                            @DarishZone I'm glad you got it working for now.
                            Don't forget to revert this change when @mitu reports back a proper solution later, and before updating RetroPie-Setup again.

                            Thanks man, i already reverted change now, will that make a difference? Im afraid to forget if i do later

                            The only potential problem if you don't revert it will be when you later update the RetroPie-Setup script. You could get local change conflicts and you will have to resolve them manually, kind of nasty.

                            However after the fix is done, you don't really need to recompile the core again as the change doesn't touch the source code. So just revert it now and don't compile the core again until the fix is confirmed upstream.

                            D 1 Reply Last reply Reply Quote 0
                            • D
                              DarishZone Banned @hhromic
                              last edited by

                              @hhromic said in lr-px68k not build anymore:

                              @DarishZone said in lr-px68k not build anymore:

                              @hhromic said in lr-px68k not build anymore:

                              @DarishZone I'm glad you got it working for now.
                              Don't forget to revert this change when @mitu reports back a proper solution later, and before updating RetroPie-Setup again.

                              Thanks man, i already reverted change now, will that make a difference? Im afraid to forget if i do later

                              The only potential problem if you don't revert it will be when you later update the RetroPie-Setup script. You could get local change conflicts and you will have to resolve them manually, kind of nasty.

                              However after the fix is done, you don't really need to recompile the core again as the change doesn't touch the source code. So just revert it now and don't compile the core again until the fix is confirmed upstream.

                              Perfect, thanks man!

                              1 Reply Last reply Reply Quote 0
                              • H
                                hhromic
                                last edited by hhromic

                                @mitu the scummvm core is failing to build in Windows after the commit that made similar changes to this core (px6k). Again with linking problems. The issue is being investigated in upstream so maybe it is best to wait a bit for a conclusion of a proper fix for all platforms to that recent changeset.

                                I have the feeling that indeed properly setting LD to $(CXX) (as my initial guess) is the correct thing to do for mixed C/C++ projects, but we have to see how the Windows build gets fixed first. Will keep updated here too.

                                mituM 1 Reply Last reply Reply Quote 0
                                • mituM
                                  mitu Global Moderator @hhromic
                                  last edited by

                                  @hhromic Thank you for the heads up.
                                  I'm not in a rush, since the build fails for Linux x86 for this core I suppose it's something that's been noted, but the win-build-additions that you mention could be a bigger fish to fry first.
                                  Do you have an issue reference I can look-up for the investigation ?

                                  H 1 Reply Last reply Reply Quote 0
                                  • H
                                    hhromic @mitu
                                    last edited by

                                    @mitu sometimes they don't notice build fails because the buildbot just keeps the latest working builds and report to a big stream of notifications. If maintainers aren't paying attention, these fails go unnoticed. The scummvm core wasn't building for a while for example until we noticed here.

                                    For lr-scummvm, the situation can be followed since this comment in this issue: https://github.com/libretro/scummvm/issues/123#issuecomment-455203092

                                    I'm pretty sure it is not a big issue TBH, just a mismatch in Makeifles due to the big mess libretro has with their handling across cores. The recent update seems to be just a copy-paste from another C-only libretro core.

                                    I would help debug if I had an actual Windows build system in place, but unfortunately I don't at the moment. I'm sure upstream developers with one will sort it out quickly.

                                    1 Reply Last reply Reply Quote 0
                                    • H
                                      hhromic
                                      last edited by

                                      Update

                                      I went to investigate a bit better a suitable solution and indeed the right thing to do is to set LD = $(CXX) for the mixed C/C++ codebase. I already sent a PR upstream now to address the build issue. I tested building on Linux and Windows and is building fine with that fix.

                                      The same approach solves the Windows build for the lr-scummvm core so I also sent a PR upstream to correctly restore LD to $(CXX) and properly solve the issue for Linux and Windows alike.

                                      Once the lr-px68k PR is merged upstream, it will build fine again in RetroPie without any modifications of the scriptmodule.

                                      1 Reply Last reply Reply Quote 1
                                      • H
                                        hhromic
                                        last edited by

                                        Update

                                        So the upstream PR was accepted quite fast :) The build of lr-px68k is working fine now (just tested).

                                        @DarishZone if you reverted the temporary fix to the RetroPie scriptmodule, you may try to recompile now and should work fine. If you are happy, you should mark the topic with [SOLVED] :)

                                        Good Luck!

                                        D 1 Reply Last reply Reply Quote 1
                                        • D
                                          DarishZone Banned @hhromic
                                          last edited by

                                          @hhromic said in lr-px68k not build anymore:

                                          Update

                                          So the upstream PR was accepted quite fast :) The build of lr-px68k is working fine now (just tested).

                                          @DarishZone if you reverted the temporary fix to the RetroPie scriptmodule, you may try to recompile now and should work fine. If you are happy, you should mark the topic with [SOLVED] :)

                                          Good Luck!

                                          More than happy, thanks for all the help u provide to the community (and mitu of course)

                                          1 Reply Last reply Reply Quote 1
                                          • First post
                                            Last post

                                          Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                          Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.