Grid Updates - emulationstation-dev

jdrassa

@sergioad There are no plans to add it back. However, one thing I would like to look into is giving themes more control over animations/transitions. If I ever get to it, it would probably enable themes to recreate something very similar.

sergioad

Cool

paffley

@jdrassa hi, I think I found another bug, only small.

When adding...

<imageSource>image</imageSource>

it still picks up the <image> folder and therefore does not display whats in the marquee tag.

Hope this helps.

jdrassa

@paffley I submitted a PR to fix this. It should be merged in the next few days.

paffley

Thanks @jdrassa i'll keep my eye open and run another test :)

paffley

Hi @jdrassa have you seen this pr - https://github.com/RetroPie/EmulationStation/pull/623

Looks pretty interesting for the grid view :)

jdrassa

@paffley I did. I've been swampped and haven't had much time to look at it. Hoping to get to it over the holidays.

paffley

Thanks @jdrassa your a star :) no rush dude, I know holidays are busy, looks like a good addition tho :)

meleu

just a reminder:
testers can use the tool I mention in this thread to help developers with their work.

Cheers!

paffley

@meleu thank you! I will take a look at this....just to clarify you can test peoples pr's in es-dev with this?

meleu

@paffley
yep, I made the script able to load the list of open PRs in RetroPie's ES repo, and then you can download/compile/test them.

paffley

thats amazing @meleu thank you! great work!!! I'll have a play tomorrow :)

paffley

Couldn't get those pr updates to work at my end, just crashed my sd. Maybe you will have some luck @jdrassa when you get time to have a look. In the meantime im gonna keep trying :)

paffley

Hi @jdrassa any news on the new updates being merged?

I also noticed one little bug with the grid view when updating emu-dev - When entering a system, the md_name vanishes then re-appears when scrolled. Hope this helps. :)

paffley

Hey @jdrassa thanks for merging the new grid updates :)

Found a couple of bugs in the latest version of es-dev

1 - When you go back to the gamelist view 'after exiting a game' md_video does not play, even when you scroll. If you go back to the system view then back to gamelist view the snaps re-appear.

2 - When entering a system, the md_name, md_image, md_video etc vanishes then re-appears after the first scroll.

Now I'm not sure if this is a bug or not but with the latest es-dev update there is a frame rate counter in the top right hand side of the screen when you start a game? I'm not sure how to get rid of this as its not from es menu settings nor can I locate it in retroarch?

Hope this all helps :)

paffley

Any fixes for these as yet please @jdrassa ?

ruckage

Hey @jdrassa , hope you're well.

I've been trying your latest windows build of ES but there seems to be an issue with Grid view where the grid images are squashed after selecting a tile. It looks like they may be being squashed in a way that matches the aspect ratio of the ES window if that helps but I can't be positive. I'm not sure if this is just a windows issue or if its affecting rpi as well.

Here's a video to illustrate the problem:

quicksilver

@ruckage Ive noticed something similar when using "video" as gameslist view. The scraped image will be squashed after running a title after returning to ES or if you press select on the title like you are going to edit the metadata. This is on a raspberry pi btw. I tested on several themes including carbon.

ruckage

@quicksilver
@jdrassa

I've narrowed down the issue now. The bug first appeared in an update on 30 December when marquee, image and video were added to grid view.

What's more it seems to be specifically caused by md_image.

My understanding is that the update added the ability to display md_Image, md_video and md_marquee in the gridview as you can in other views as separate elements.

This works for md_marquee and md_video and behaves as expected.
For example adding the following into the grid View section of a theme will draw the marquee in the top left corner:

<image name="md_marquee">
	<size>0 0.2</size>
	<pos>0 0</pos>
	<origin>0 0</origin>
</image>

However if you try the same with md_image nothing extra is drawn. Instead it affects the way the images are drawn in the grid, this I am sure is a bug and I'm fairly certain will be causing issues in the Rpi version as well (I can't check at the moment as I don't have a spare SD card handy).

It's the size tags specifically which are affecting the grid images. Here are some examples:

<image name="md_image">
	<size>0.2 0.2</size>
</image>

bug 1.jpg

<image name="md_image">
	<size>0.5 0.2</size>
</image>

bug 2.jpg

And this is without adding md_image to the theme so the system uses default values which results in the images being stretched to a square shape.

bug 3.jpg

Currently it can almost be fixed by setting one or both size values to 0, e.g <size>0 0</size> . However the first image in the grid still gets distorted and obviously the md_image still can't be displayed as a separate element.

bug 4.jpg

I hope this helps pinpoint the problem @jdrassa and I hope you're okay as I see you haven't posted for a while (admittedly nor had I) .

jdrassa

@ruckage Sorry for the delayed response. I haven't had much time to dedicate to RetroPie stuff lately. I think you pretty much found the cause. I believe what is happening is that when ES caches the image texture it does so at the size it expects to renderer it. Since md_image is being displayed in 2 different places at 2 different sizes, one size takes precendence over the other, since only one copy of the texture is kept in memory.

I will need to run some more tests, but I just ran a quick test and I was able to get md_image to be drawn as expected. Any way you could share a copy of your theme with me? Or at least just the grid config portion.