Is Yabasanshiro emulator coming on retropie?

Darksavior

I tried to build the latest version from devmiyax's repo. Failed. Ah, well. I don't know what I'm doing, just thought I'd try.

barbudreadmon

@Darksavior said in Is Yabasanshiro emulator coming on retropie?:

I tried to build the latest version from devmiyax's repo. Failed.

i stopped maintaining the port on his repo after https://github.com/devmiyax/yabause/issues/630#issuecomment-547787501 , this conversation kinda pissed me off, especially with him releasing a switch version based on the lakka distro a few weeks later...

mechafatnick

I tried Assault Suit Leynos 2 yesterday and the entire ground is missing. :)

There's definitely some issues on the 2d side of things.

grant2258

@Darksavior seems like there is a end to development on libretro on this port unless someone picks it up on there end. The only way to test would be by using standalone build. If that works well you can just request an update on the github page on libretro for someone to pick it up and hope for the best.

ok ive made a patch not got any saturn roms but it compiles just apply this patch over the repo

git clone https://github.com/devmiyax/yabause.git
cd yabause/
wget https://github.com/grant2258/yabause/raw/master/pi.patch
git apply pi.patch
cd yabause/src/libretro/
make platform=armvneonhardfloat  -j4

then copy the bin over no idea if this is enough just done the basics. I basically repaced the chd code to the libreto one not sure if this will cause issues loading or not hopefully it works

barbudreadmon

@grant2258 said in Is Yabasanshiro emulator coming on retropie?:

If that works well you can just request an update on the github page on libretro for someone to pick it up and hope for the best.

Ultimately i want someone to completely take over that core so that i can stop providing any kind of support for it, sending sync PR my way isn't gonna solve anything, i'll still be the guy getting asked for everything related to that core, including the dozens of regressions version 3.2 introduced.

grant2258

not sending anything your way you have made it clear your not updating this anymore. I just done a diff to his repo to get it to compile. Is just a patch for people to test out. Might not even work worth a try if not then well i tried. Like yourself dont really want to waste any time on it someone needs to maintain it libretro side ideally.

roslof

@grant2258 appreciate the effort here. Understood we're only tinkering.

Compiled for me. Launching a [previously working] .chd yields unsupported image in the logs. Boots, but only to Saturn BIOS screen. I'll try some non .chd files and see what I get.

[libretro ERROR] Yabause: Unsupported CD image!
[libretro ERROR] Yabause: Cannot initialize ISO-File Virtual Drive

FWIW: I just added your patch to Buzz's lr-yabasanshiro script and built it that way:

  isPlatform "rpi4" && applyPatch "$md_data/01_shader_hack_rpi4.diff"
  isPlatform "rpi4" && applyPatch "$md_data/pi.patch"

Not sure if I should have removed Buzz's shader tweak.
No worries though. Will play around more.

grant2258

@roslof using a diff repo dont use the build scripts for this just type the commands at the command prompt. This is using pretty old libretro files its the latest ones mainline though

git clone https://github.com/devmiyax/yabause.git
cd yabause/
wget https://github.com/grant2258/yabause/raw/master/pi.patch
git apply pi.patch
cd yabause/src/libretro/
make platform=armvneonhardfloat  -j4
sudo cp yabasanshiro_libretro.so /opt/retropie/libretrocores/lr-yabause/yabause_libretro.so

I downloaded shinobi gfx are flashing on teh libretro port for some reason but it is running i dont have a pi 4 though

roslof

@grant2258 as expected, that worked. Thank you! Evaluating...

Darksavior

@grant2258 No games seem to work. It boots to the disc menu. I tried a chd and bin\cue that originally worked. The screen is missing all textures. It also says it's version 2.5.1? I thought the new version was 3.2.

[libretro ERROR] Yabause: Unsupported CD image!

[libretro ERROR] Yabause: Cannot initialize ISO-File Virtual Drive

grant2258

@Darksavior remove the directory you have already with rm -rf yabause and try again. The 2.5.1 version displaying is because thats the last version libretro updated it with upstream.

edit fwiw i checked out the latest libretro code merged the latest branch changes the flashing is still there for me on linux64 on shinobi

Darksavior

@grant2258 No change.

grant2258

@Darksavior not sure what your doing different from roslof it working for him.

There seems to be some confusion here in general the libretro port seems up to date you can merge the latest into the yabasanshiro branch on libretro 3.1 something. I get flashing in both though. So you can do it that way if you prefer

roslof

@Darksavior your symptoms mirrored mine when I was using the .sh script. For it to work properly, with a clean build folder, I just followed the directions from grant2258 a few posts back.

Darksavior

@roslof I'm not using the .sh script. That's opening a can of worms and I have no dev experience. I'm using the directions grant posted. I have started over and since he didn't update his patch, my problem did not change. I delete the folder before starting over, obviously..
@grant2258 Does it matter that I'm doing this through ssh?

grant2258

its working for me and roslof so no idea what going wrong your end i would copy and past one line at a time to rule out any issues with that

Darksavior

@grant2258 I am pasting one line at a time. This like the 5th time I've tried. This error has always happened. Is this normal?

root@retropie:/home/pi/yabause# git apply pi.patch
pi.patch:10: trailing whitespace.

pi.patch:153: trailing whitespace.
        // TOC[99] - Point A0 information
pi.patch:768: trailing whitespace.
        if (ccd->dict == NULL)
pi.patch:775: trailing whitespace.
        while (fgets(text, sizeof(text), ccd_fp) != NULL)
pi.patch:782: trailing whitespace.
                if (start[0] == '[')
warning: squelched 12 whitespace errors
warning: 17 lines add whitespace errors.

grant2258

nothing to worry about

Darksavior

@grant2258 Then I give up. It's fine. Just thought I could get 3.2's changes to try since it seems to fix some games according to the youtube update video.

grant2258

@Darksavior I mentioned this before I was under the impression the libretro port wasnt being updated from what was posted before. It is in fact pretty up to date(3.1.0).
It just seems libretro isint sending the updates to mainstream but is taking mainstream updates as they come to keep up to date

you can merge the lastet updates into the libretro yabasanshiro branch if you want to test it that way. All that needed said was we could merge this change to test :).

edit: I compiled the qt standalone shinobi had no flickering issues fwiw really might be wise to test this in standalone mode to see if if its drivers or libretro end issue to get some resolve.

edit another update: the flashing is gone when i updated my retroatch (64 bit intel)