Hope lr-fbneo support kof 97 practice mode(kof97pm.zip)

[ninja]

@barbudreadmon
I have already forked a branch(patch-1) and added my code to d_neogeo.cpp.

And I just replaced spaces by single tabs for indentation, according to your requirement.

[barbudreadmon]

@ninja I guess https://github.com/alifare/FBNeo is your fork of the project. Well, you didn't create any PR to get it merged into official fbneo, and it's unusable in that state anyway since you added the 838 additional commits from the libretro fork (we don't want those in the https://github.com/finalburnneo/FBNeo repo).
Do you prefer i handle the addition of your code myself ?

[ninja]

@barbudreadmon said in Hope lr-fbneo support kof 97 practice mode(kof97pm.zip):

handle

Can you tell me how to get it merged into official fbneo ?

I know it's more convenient and time-saving to let you do it youself. But this is a good opportunity for me to learn new skills, and I am a good student : )

[ninja]

@barbudreadmon
I just "submit review" on github.com, but I am not sure if I did it right.

[barbudreadmon]

@ninja you didn't, as i said you must not submit the 838 additional commits from the fork, only the changes to d_neogeo.cpp

[ninja]

@barbudreadmon So I should have forked only d_neogeo.cpp ?

[barbudreadmon]

@ninja yes

[ninja]

@barbudreadmon Can I delete other files and commits except for d_neogeo.cpp in my fork?
Or do I have to create a new fork?

[barbudreadmon]

@ninja i did some changes to your entry : https://github.com/finalburnneo/FBNeo/commit/0478e029a9012a53c48b172788c7b89ffa583717

• i normalized the formatting
• i tagged it as a hack (it's not a bootleg)
• i added a comment on how to use it (it's not unibios that is needed, it's AES)

[ninja]

@barbudreadmon After testing, I found uni-bios_1_3.rom is a right choice.

If you choose a bios other than unibios, you can still play kof97pm normally, but you can't enter the Practice Mode from the game's menu.

What professional players need is exactly the Practice Mode.

That's the key point.