Hope lr-fbneo support kof 97 practice mode(kof97pm.zip)

ninja

@mitu lr-fbneo recompiled by myself

barbudreadmon

@ninja is there a reason for using a custom init ? it doesn't work if you call NeoInit directly instead of your custom kof97pmInit ? HBMAME is using standard init for that hack.

ninja

@barbudreadmon
Well, I just copied the codes for kof97pla from d_neogeo.cpp and modified them for my kof97pm.

Acutally, I even don't understand what they mean.

barbudreadmon

@ninja said in Hope lr-fbneo support kof 97 practice mode(kof97pm.zip):

Well, I just copied the codes for kof97pla from d_neogeo.cpp and modified them for my kof97pm.

This code is meant to decode sx rom before loading it, it seems to be required for kof97pla (see init_kof97pla at the beginning of https://raw.githubusercontent.com/Robbbert/hbmame/master/src/hbmame/drivers/kof97.cpp), but it doesn't seem to be required for kof97pm (or any other kof97 hack for that matter), see this code around the end of hbmame's kof97.cpp file :

...
HACK( 2003, kof97pla,  kof97,    neogeo_noslot, neogeo, neogeo_state,kof97pla, ROT0, "bootleg", "Kof'97 (Plus)(set 1)", MACHINE_SUPPORTS_SAVE )
HACK( 2003, kof97plc,  kof97,    neogeo_noslot, neogeo, neogeo_state, neogeo,   ROT0, "ZKW", "Kof'97 Plus (Black Edition)", MACHINE_SUPPORTS_SAVE )
HACK( 2006, kof97plus, kof97,    neogeo_noslot, neogeo, neogeo_state, neogeo,   ROT0, "bootleg", "Kof'97 (Plus 2006)", MACHINE_SUPPORTS_SAVE )
HACK( 1997, kof97pm,   kof97,    neogeo_noslot, neogeo, neogeo_state, neogeo,   ROT0, "Kof1996", "Kof'97 (Practice Mode)", MACHINE_SUPPORTS_SAVE )
...

The 7th member is either kof97pla (will trigger the call to the init_kof97pla function at boot) or neogeo (will call the standard neogeo init)

barbudreadmon

@ninja also, if you look at this line in your code :

	{ "232-s1.s1",   0x020000, 0x8514ecf5, 2 | BRF_GRA },          //  2 Text layer tiles

You can see it's about the text layer in the comment, the file is named 232-s1.s1, the .s1 extension means it's one of the sx files you are decoding.

ninja

@barbudreadmon But I cannot find this file in kof97pm.zip, there is only 232pm.p1 in this zip file.

barbudreadmon

@ninja that's probably because you are using split romsets, so 232pm.p1 is loaded from kof97pm.zip and every other files are loaded from parent kof97.zip

ninja

@barbudreadmon Yes, you are right. I am using split romsets. There is a 232.s1 file in the kof97.zip.

So is this file not suitable for playing kof97pm ?

ninja

@ninja
I modified the d_neogeo.cpp again, and now the code for kof97pm is shown below:

static struct BurnRomInfo kof97pmRomDesc[] = {
        { "232pm-p1.p1",   0x100000, 0x34ccabae, 1 | BRF_ESS | BRF_PRG }, //  0 68K code 
        { "232-p2.sp2",   0x400000, 0x158b23f6, 1 | BRF_ESS | BRF_PRG }, //   1

        { "232-s1.s1",   0x020000, 0x8514ecf5, 2 | BRF_GRA },          //  2 Text layer tiles

        { "232-c1.c1",   0x800000, 0x5f8bf0a1, 3 | BRF_GRA },           //  3 Sprite data
        { "232-c2.c2",   0x800000, 0xe4d45c81, 3 | BRF_GRA },           //  4 
        { "232-c3.c3",   0x800000, 0x581d6618, 3 | BRF_GRA },           //  5 
        { "232-c4.c4",   0x800000, 0x49bb1e68, 3 | BRF_GRA },           //  6 
        { "232-c5.c5",   0x400000, 0x34fc4e51, 3 | BRF_GRA },           //  7 
        { "232-c6.c6",   0x400000, 0x4ff4d47b, 3 | BRF_GRA },           //  8 

        { "232-m1.m1",   0x020000, 0x45348747, 4 | BRF_ESS | BRF_PRG }, //  9 Z80 code

        { "232-v1.v1",   0x400000, 0x22a2b5b5, 5 | BRF_SND },           // 10 Sound data
        { "232-v2.v2",   0x400000, 0x2304e744, 5 | BRF_SND },           // 11 
        { "232-v3.v3",   0x400000, 0x759eb954, 5 | BRF_SND },           // 12 
};

STDROMPICKEXT(kof97pm, kof97pm, neogeo)
STD_ROM_FN(kof97pm)

struct BurnDriver BurnDrvKof97pm = {
        "kof97pm", "kof97", "neogeo", NULL, "1997",
        "The King of Fighters '97 (Practice Mode)\0", NULL, "hack", "Neo Geo MVS",
        NULL, NULL, NULL, NULL,
        BDF_GAME_WORKING | BDF_CLONE | BDF_BOOTLEG, 2, HARDWARE_PREFIX_CARTRIDGE | HARDWARE_SNK_NEOGEO, GBF_VSFIGHT, FBF_KOF,
        NULL, kof97pmRomInfo, kof97pmRomName, NULL, NULL, NULL, NULL, neogeoInputInfo, neogeoDIPInfo,
        NeoInit, NeoExit, NeoFrame, NeoRender, NeoScan, &NeoRecalcPalette,
        0x1000, 304, 224, 4, 3
};

Then I re-compiled the fbneo_libretro.so, and now I can play kof97pm with RetroPie on my Raspberry Pi 3.

barbudreadmon

@ninja good work :)

Do you want me to commit it or do you want to send the code to https://github.com/finalburnneo/FBNeo yourself ? If you intend to send a PR yourself, please replace those spaces by single tabs for indentation.

ninja

@barbudreadmon
I have already forked a branch(patch-1) and added my code to d_neogeo.cpp.

And I just replaced spaces by single tabs for indentation, according to your requirement.

barbudreadmon

@ninja I guess https://github.com/alifare/FBNeo is your fork of the project. Well, you didn't create any PR to get it merged into official fbneo, and it's unusable in that state anyway since you added the 838 additional commits from the libretro fork (we don't want those in the https://github.com/finalburnneo/FBNeo repo).
Do you prefer i handle the addition of your code myself ?

ninja

@barbudreadmon said in Hope lr-fbneo support kof 97 practice mode(kof97pm.zip):

handle

Can you tell me how to get it merged into official fbneo ?

I know it's more convenient and time-saving to let you do it youself. But this is a good opportunity for me to learn new skills, and I am a good student : )

ninja

@barbudreadmon
I just "submit review" on github.com, but I am not sure if I did it right.

barbudreadmon

@ninja you didn't, as i said you must not submit the 838 additional commits from the fork, only the changes to d_neogeo.cpp

ninja

@barbudreadmon So I should have forked only d_neogeo.cpp ?

barbudreadmon

@ninja yes

ninja

@barbudreadmon Can I delete other files and commits except for d_neogeo.cpp in my fork?
Or do I have to create a new fork?

barbudreadmon

@ninja i did some changes to your entry : https://github.com/finalburnneo/FBNeo/commit/0478e029a9012a53c48b172788c7b89ffa583717

i normalized the formatting
i tagged it as a hack (it's not a bootleg)
i added a comment on how to use it (it's not unibios that is needed, it's AES)

ninja

@barbudreadmon After testing, I found uni-bios_1_3.rom is a right choice.

If you choose a bios other than unibios, you can still play kof97pm normally, but you can't enter the Practice Mode from the game's menu.

What professional players need is exactly the Practice Mode.

That's the key point.