Streets of Rage Remake 5.2 - add to Ports ?

sleve_mcdichael

Re: system.txt

If the user has 5.1 data, the format is different; we probably shouldn't clobber the whole file in our script module without making sure it's the right one.

Additionally, 5.1 lacks a proper "exit" feature in the menu and requires to press [ESC] on an attached keyboard to exit the game, unless system = PSP; replaces system = PC;.

I propose, instead of overwriting this file in whole, we use sed (stream edit) to modify whichever of the two lines exists in the file, if it exists at all, incorporating both of these fixes at the same time:

function configure_sorr() {
    addPort "bgdi-333" "sorr" "Streets of Rage Remake" "XINIT:pushd $romdir/ports/sorr; $md_inst/bgdi-333 ./SorR.dat; popd"
    [[ "$md_mode" == "remove" ]] && return

    mkRomDir "ports/sorr"
    local config="$romdir/ports/sorr/mod/system.txt"
    if [[ -f "$config" ]]; then
        # set custom "system" for 5.1 (allows proper "exit" from game menu)
        sed -i 's/system = PC/system = PSP/' "$config"
        # set custom "full screen wide" mode for 5.2 (allows "windowed" and "vsync" options)
        sed -i 's/^BORDERLESS_SYNC/AUTO/' "$config"
    fi
}

The ^ line-anchor at the beginning of the "search" string for "BORDERLESS_SYNC" matches "start of line," so it doesn't match and replace the example in the comment, only the functional part. It's not needed in the other line because it matches the whole "system =" part, and therefore won't match the example comment already.

sleve_mcdichael

@Floob, et al, it looks like 5.1 mods can work in 5.2, at least sometimes. I've got "los simpsons arcade [updated for sorrv5.1]" running in 5.2 right now. Just FYI.

quicksilver

@sleve_mcdichael I'm pretty sure that if the game is set to run as PSP mode then it is single player only. Many people may not care about that but it's worth noting.

Floob

@sleve_mcdichael said in Streets of Rage Remake 5.2 - add to Ports ?:

it looks like 5.1 mods can work in 5.2

I'm really tempted to create a compatibility doc. Given the out of date nature of the links on the sorr forum, a compatibility doc could have columns like sorr version, mod version (for which sorr), bgdi version, and possibly install method. (main benefit might simply be to store live links to mods that work)

FWIW I think I saw an issue when installing it via the script maintained by ExarKuniv that it meant savegames and other ingame actions were saved to the sorr binaries folder as opposed to the savegame folder under the roms tree. It confused me when I was trying to get a savegame file to work :)
Also, I dont know if is possible to get the script to create the system.txt file as owner pi instead of root, just to make it that much easier to edit if needed.

sleve_mcdichael

@quicksilver said in Streets of Rage Remake 5.2 - add to Ports ?:

@sleve_mcdichael I'm pretty sure that if the game is set to run as PSP mode then it is single player only. Many people may not care about that but it's worth noting.

Ah, you're right, and I checked all the other modes too, and none of them have both 2-player and an "exit" feature. Looks like it's either/or (or 5.2 has both.)

sleve_mcdichael

@Floob said in Streets of Rage Remake 5.2 - add to Ports ?:

FWIW I think I saw an issue when installing it via the script maintained by ExarKuniv that it meant savegames and other ingame actions were saved to the sorr binaries folder as opposed to the savegame folder under the roms tree. It confused me when I was trying to get a savegame file to work :)

That version, going all the way back to ZeroJay's initial commit uses helper function moveConfigFile on a directory, so I think it ends up making a link to the directory instead of putting a link in the directory, or something like that.

I didn't look too closely at it because in the version that I'm working on, it isn't necessary to link anything, I just pushd into where the data actually is and call the bin remotely, instead of pushing to the bin and then having to link back to the actual data. But I think if you change it to moveConfigDir instead of moveConfigFile, might be all it takes.

Also, I dont know if is possible to get the script to create the system.txt file as owner pi instead of root, just to make it that much easier to edit if needed.

Yeah, you just need to chown $user:$user "<file>" after you create it, in the install script.

@ExarKunIv chose not to do this, because they want the change to persist if the user installs the module first and then copies over their game data. Otherwise, the module would need to be installed (or at least "configured": sudo ~/RetroPie-setup/retropie_packages.sh sorr configure) after the game data is copied, whether or not it was installed once before already.

sleve_mcdichael

New version of sorr.sh merged into the RetroPie-Extra repo. Should work with both 5.1 and 5.2 game datas (not at the same time :p). Please test:

https://github.com/Exarkuniv/RetroPie-Extra

hawkes_84

@Floob @ExarKunIv sup! did we manage to get this to work on the Pi4 at all - as smooth as it does on the pi3? (having all the video options etc)

sleve_mcdichael

@hawkes_84 try it and report back. Seems to run pretty good on my RPi4, but I don't have a 3 to compare with. Some screen tearing here and there, nothing extreme.

hawkes_84

@sleve_mcdichael think I did try it and it was worse than before (ie fewer options to change video and something was missing from gameplay) but was a few weeks back now. I'll take another look and report

sleve_mcdichael

@hawkes_84 some of the options do depend on some of the others. The available "graphic mode" options are different with "widescreen mode" ON than they are with it OFF, for example.

"Display: windowed" seems to always be shifted top-left for me (except when it actually fills the whole screen), while "full screen" is always centered (though, oddly, not always actually full-screen, depending on "widescreen mode".

With "display: full screen" and "widescreen: yes", image is full-screen in all "graphic mode" settings. When I turn to "widescreen: no", then the "normal" graphic mode is shrunken (still centered), and only the "2x" modes are full-size (and 3x is no longer available.)

I haven't touched the video mode settings in ES/runcommand. My display and default framebuffer size are 1280x720.

hawkes_84

@sleve_mcdichael appreciate this info. The version on the Pi3 is pretty much perfect except for some screen tear. You get to use the full array of video options such as scanlines and smoother graphics if you want without having to sacrifice where the picture goes (ie top left) I guess this is the standard Im looking for on the pi4 but guess it's not quite there yet. I did have it near enough perfect before except I wanted the scale to be 4:3 but no options would give me this in ES or else where. I could get it to full screen with some annoying half inch border on the right which annoyed me as you know how the human brain wants symmetry etc. Shame as it's easily the go to SOR game on the Pi

sleve_mcdichael

@hawkes_84 said in Streets of Rage Remake 5.2 - add to Ports ?:

@sleve_mcdichael appreciate this info. The version on the Pi3 is pretty much perfect except for some screen tear. You get to use the full array of video options such as scanlines and smoother graphics if you want without having to sacrifice where the picture goes (ie top left) I guess this is the standard Im looking for on the pi4 but guess it's not quite there yet.

Here's what I've got right now. I can also turn vsync on; it tears either way, to me it seems "smoother" tearing with vsync off than with it on.

(And actually I usually leave the scanlines off, this is just to show it does work. But it's awfully dark on my screen; maybe it would look better on a full 1080 where it could potentially have a higher ratio of lit pixels to the darkened scanlines, but I only have 720 and this looks like over half the image is black.)

I could get it to full screen with some annoying half inch border on the right which annoyed me as you know how the human brain wants symmetry etc.

Have you tried all the (relevant) available video modes through the runcommand menu? I haven't needed to change them, but every display is different, so it might be worth a shot.

hawkes_84

@sleve_mcdichael thanks again. Yes I pretty much tried every aspect ratio ES had to offer with mixed results but others on this thread seemed to be getting different outcomes to me so it's either me or my pi4 (probably me) I'll give this another go and let you know

hawkes_84

@sleve_mcdichael so tried it again and I can't seem to get it down from the top left whichever scale/sizing I choose from the Runcommand. Also "Display" and "VSync" are greyed out on my version. Does this seem right?

sleve_mcdichael

@hawkes_84 said in Streets of Rage Remake 5.2 - add to Ports ?:

Also "Display" and "VSync" are greyed out on my version. Does this seem right?

This sounds like when the SORR v5.2 system.txt hasn't been modified from the distributed version and still has // FULL SCREEN WIDE mode set to BORDERLESS_SYNC instead of AUTO.

(Mine is not shifted off-center when this happens, however, fixing it does open up more options so you may still find a magic bullet.)

Are you using the latest updates from RetroPie-Extra? Did you run the install after your SORR game files were in place? Is your system.txt still root-owned from the previous install versions from a couple months ago?

Can you show the output of:

ls -l ~/RetroPie/roms/ports/sorr/mod/system.txt

...and

cat ~/RetroPie/roms/ports/sorr/mod/system.txt

hawkes_84

@sleve_mcdichael let me pick this back up with you tomorrow as late here in the UK. You were right though my system.txt was set to BORDERLESS SYNC instead of AUTO. Problem now is I changed the emulator.cfg to say XINIT:pushd as mentioned in this thread and the sorr rom won't even start up. Gives an error message about it not being able to remove something or other. Might do a fresh install tomorrow of extras.sh and the sorr package

sleve_mcdichael

@hawkes_84 said in Streets of Rage Remake 5.2 - add to Ports ?:

You were right though my system.txt was set to BORDERLESS SYNC instead of AUTO. Problem now is I changed the emulator.cfg to say XINIT:pushd as mentioned in this thread and the sorr rom won't even start up. Gives an error message about it not being able to remove something or other. Might do a fresh install tomorrow of extras.sh and the sorr package

Ah, I think we are getting somewhere. Without using XINIT:, my picture is pushed off-center.

However, you can't just patch it in the command like that, anymore. It turns out that using XINIT: and pushd together in the command, like that, didn't play nice with each other (actually, it's because of xinit and the semicolons used to put pushd; command; popd all on one line; see here for more info), so we had to break those commands out into a separate "buffer" script and call that with XINIT:.

The current command we are using looks like "XINIT:/opt/retropie/ports/sorr/sorr.sh %ROM%", but you'll need that sorr.sh script in place also. A reinstall with the latest scriptmodule should (hopefully) put everything where it needs to be and get you sorted. If you have any trouble with the system.txt, you can make it user-writable with:

sudo chown pi:pi ~/RetroPie/roms/ports/sorr/mod/system.txt

hawkes_84

@sleve_mcdichael said in Streets of Rage Remake 5.2 - add to Ports ?:

"XINIT:/opt/retropie/ports/sorr/sorr.sh %ROM%"

thanks. So is "XINIT:/opt/retropie/ports/sorr/sorr.sh %ROM%" just another line i need to add in the system.txt?
how would I know if I cant change the system.txt? will it just not let me into it as it let me into it fine before and i just saved it and came back out with no issue but then it wouldn't start up.
Will give this a try today at some point

hawkes_84

@sleve_mcdichael so now my emulator.cfg looks like this

sorr = "XINIT:/opt/retropie/ports/sorr/sorr.sh %ROM%"
default = "sorr"

and my system.txt has been set has been set to AUTO as suggested and the ROM wont start up again. I did a fresh install of the extras script and also a started with freshly downloading/installing the sorr from experimental packages

Any clue where I'm going wrong?