lr-mame/lr-mess source code changes and/or will not compile

mitu

Yes, it seems an upstream change causes the mess subtarget to fail. I haven't had a change to see where this broke, but I'll try to bisect it unless upstream fixes it in the meantime.

Folly

@mitu

Good to know that it's probably an upstream failure.
Again, thanks for looking.

Folly

@mitu said in lr-mess will not compile / 17 may 2023:

change causes the mess subtarget to fail

I removed the subtarget but doesn't make a difference, still not compiling.

Edit :
Seems good :
https://github.com/libretro/mame/tree/cd5f7d077cdab2eac09faf642ddd121d80f3ad1b

So it's a change something in between.

ps :
I did above manually but I want to specify the tree it in the lr-mess module-script.
Is this the correct way of using a specific tree ? (commit ?) :

rp_module_repo="git https://github.com/libretro/mame.git master cd5f7d077cdab2eac09faf642ddd121d80f3ad1b"

mitu

@Folly said in lr-mess will not compile / 17 may 2023:

Is this the correct way of using a specific tree ? :

Yes, it's correct, you specify the branch and the commit (tree ? what's that ?).

Folly

@mitu

Ok, good to know that it's correct, I will test.

(tree ? what's that ?).

Github specifies it as a "tree" in it's url so I guessed it was called like that.
(mame/tree/cd5f7d077cdab2eac09faf642ddd121d80f3ad1b)
Though, calling it commit will do, if we mean the same, no problem.

Folly

@mitu

Opened an issue :
https://github.com/libretro/mame/issues/362

mitu

@Folly You should have waited - the issue may be with the build options set by the Retropie-Setup scriptmodule.

Ashpool

@Folly Seem to be fixed now ;) I just tried again in Ubu 22.04 (VM) and the compile went fine.

Folly

@mitu said in lr-mess will not compile / 17 may 2023:

@Folly You should have waited - the issue may be with the build options set by the Retropie-Setup scriptmodule.

Sorry, sometimes I am a bit too hasty, Will remember next time ;-)

Folly

@Ashpool said in lr-mess will not compile / 17 may 2023:

@Folly Seem to be fixed now ;) I just tried again in Ubu 22.04 (VM) and the compile went fine.

Didn't have time to test it yet.
Nice to hear that the issue has been solved ;-)

Folly

@mitu

I renamed the topic name a bit to :
lr-mame/lr-mess source code changes and/or will not compile
Seems to be more suitable to what is happening to lr-mess/lr-mame these days.

I am doing some tests on the 0255 test branch now.
Latest news about that is that :

for now compiling with SUBTARGET=arcade, SUBTARGET=mess is a thing of the past unless you request it again upstream or to select multiple source files or multiple directories for custom builds
(I have asked adding SUBTARGET=arcade, SUBTARGET=mess again but I doubt it will be honoured)
some fixes aren't yet in the 0255 test branch, like these ones, but should be merged when the test branch merges into the master-branch.
(I have tried to add the Better max geometry fix to the 0255 test branch but for now it will not compile.

I think all in all something to be aware of and slowly discuss.

mitu

Thanks for the updates. When they'll show up in the main branch, we'll tackle them.

As a personal observation, I find it annoying and rude when users comment on a WIP PR/branch - especially to report 'issues' when things are still being tested and worked on.

Folly

@mitu said in lr-mame/lr-mess source code changes and/or will not compile:

Thanks for the updates. When they'll show up in the main branch, we'll tackle them.

Ok very reassuring.

As a personal observation, I find it annoying and rude when users comment on a WIP PR/branch - especially to report 'issues' when things are still being tested and worked on.

I get it.

HoJo215

Keep in mind lr-mame's last official 0.251 is the last one that plays cave's akai katana and dodonpachi saidojou.
These were supposed to be taking out a while back at 0.240 but lr-mame's update progress left them in.
Their officially removed in lr-mame 0.255 coming up.
So you might want to back up 0.251 and have it run
as a secondary option renamed mamearcade_cave_libretro.so

I took a look at the diff's and tried editing them back into 0.255's cv1k.cpp and mame.lst but no dice.
Might be a rendering thing with the newer blitter delay, but the above files are all I see changed.

Folly

@HoJo215

Thanks for the info.

The hope the future of lr-mame/lr-mess will be bright but project seems to be under pressure.
All we can do is wait and see what happens.

Btw .
Do you know why plays cave's akai katana and dodonpachi saidojou ?
Seems very strange removing something that works.
Though I have seen it before with a handheld driver.

Folly

@HoJo215

Seems that today 0.255 test branch got many fixes where we were waiting for.
It's probably time to test it again.

HoJo215

This post is deleted!

HoJo215

@Folly said in lr-mame/lr-mess source code changes and/or will not compile:

@HoJo215

Thanks for the info.

The hope the future of lr-mame/lr-mess will be bright but project seems to be under pressure.
All we can do is wait and see what happens.

Btw .
Do you know why plays cave's akai katana and dodonpachi saidojou ?
Seems very strange removing something that works.
Though I have seen it before with a handheld driver.

It was a c&d from exarcadia who has a license from cave for these two games for they're arcade machine..

Folly

Libretro mame master branch has been updated to 0255.
Compiling for arcade and mess sub-targets has been implemented again.

Hopefully everything will work like it did before.