Emulationstation 2.1.0RP not saving metadata

BuZz

https://github.com/RetroPie/EmulationStation/issues/79

fieldofcows

I'm taking a look but I can't reproduce this at the moment. Can anybody give me any pointers on how to setup a minimum config to trigger this error?

jwcbronski

I can only tell you that the error message "terminate called after throwing an instance of 'std::out_of_range'" is still displayed even when I have deleted all of my gamelists.

fieldofcows

@jwcbronski Ok. Thanks. That's actually very helpful and rules out a fair chunk of the code that could be causing the issue.

fieldofcows

Ok. Got it. It only happens on systems that use folders when checking to see if the metadata for the folder has changed. I know what the problem is and how to fix it.

In fact, @Buzz has already suggested the correct fix in https://github.com/RetroPie/EmulationStation/issues/79. I'll update the issue with the reason the fix works.

Thanks everyone and sorry for causing the issue :(

herb_fargus

@fieldofcows seems the only time bugs show up is when it's actually put in the master :p thanks for the quick response :)

BuZz

This is now fixed - please update ES from binary (or source if you prefer).

hooperre

Really speedy work, y'all!

Any idea why it was only happening to 3 of my systems? Seems weird.

fieldofcows

@hooperre said in Emulationstation 2.1.0RP not saving metadata:

Any idea why it was only happening to 3 of my systems? Seems weird

Do you only have rom subfolders on those 3 systems? That would explain it.

felleg

You guys are an amazing development team. I'm proud to be here!

hooperre

@fieldofcows path for ~~all~~ roms are .\retropie\roms\SYSTEM\FILE

I'll check when I get home from work to make sure this fixed it :X

ETA: WRONG. PC (DosBox) games are in subfolders. Very possible all subsequent systems (which would be PC, PSX, and SNES) are affected.

BuZz

@felleg :-)

Nismo

@fieldofcows Now i remember when ES was crashing for me when I had a subfolder for unlicensed games in my megadrive roms folder. Do you remember that?

It was crashing with lvl1: OptionListComponent too narrow! in the log file on windows...

Thanks for the kick fix, i already applied to the build i'm using for windows from your old fork.

Really guys you are the best.

hooperre

Well done! Happy holidays.