Please Test: Adding support for "All", "Favorites" and "Last Played" systems

Zigurana

@pjft sure, no problem. It's about the functions getting in, not about who does this! ~~You could have a look at how I initially filtered out the 'RetroPie' system from the list, I suspect that can be improved with your other changes in place~~ wait no, it becomes much easier if we only need to consider a single system!

Please have a go at it, I am looking forward to see the proposed changes.

Any idea what to use the free X-button for on SystemView?

pjft

@Zigurana I'll certainly look into that then. I might even move the "get random game" method to the SystemData class. We'll see.

As for the X-button on SystemView, I'm of two minds. I don't like having buttons assigned just for the sake of it, but I am not shocked if it keeps the same functionality as now (which is equivalent to "selecting a random system"). And in the gamelist, it is "select a random game".

Or I can cap it to just effectively select a random system, but stay on the system view.

Your call.

cyperghost

@pjft said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

As for the X-button on SystemView, I'm of two minds. I don't like having buttons assigned just for the sake of it, but I am not shocked if it keeps the same functionality as now (which is equivalent to "selecting a random system"). And in the gamelist, it is "select a random game".

I look to you @pjft ... You may need that to set a pre-cursor to custom-collection. So you press X to move something from system XY to custom-collection and then you are in gamelist in select ROM with press on Y to reroute to collection system.

I can live with that behaviour now but a random selection for emulation system would be much better imho. With the auto-allgames you got the same feature you now have global.

Huh. It should certainly remove favorites, and in my tests so far it had worked as intended, so that's good to know! Can you give me some step by step instructions on how to replicate that? I'll try it later as well, as maybe some of the most recent changes made that happen. That is not intended.

I can reproduce it easily.
I go to auto-favorite and if I press Y on a selected ROM. I got error message segmentation faulton terminal output. After that bash.rc will be loaded ES binary is killed ....

I compiled the binary for two days. Did you made changes to your branch?

Oh. I didn't notice that it wasn't - my theme is indeed in all caps.
I can certainly force it to be all caps - good call.

I use IO it uses lower and upper case fonts... indeed system are written as they are in es_systems.cfg. This does not really looks good as I developed my launching system. I just want to prevent you from small mistakes I already did!

EDIT:

Annother small bug

In auto-lastplayed if you press select and menu with filter will pop up then filtering of "sort games by" is automatically set to "Filename, Ascending"

You will loose setted feature "Last Played, Ascending" even after you leave system and enter it again. Just after restart!

pjft

@cyperghost no, no changes there. Would you be able to take a video of that, for me to see if anything stands out? In particular of the original system gamelist with the ROM, and then on the favorites one.

What happens if you do that to the same ROM in its original system? Will it remove it as intended? Is it in all Roms?

What collections do you have enabled?

Can you tell me where you have the ROM (subfolder? What exact system?).

Are you parsing gamelists? Not?

Sorry for the trouble. That's certainly a problem, and I may end up having to put together a small debug build and send it your way just to get some more logs.

cyperghost

@pjft said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

@cyperghost no, no changes there. Would you be able to take a video of that, for me to see if anything stands out?

Got this!

What happens if you do that to the same ROM in its original system? Will it remove it as intended? Is it in all Roms?

That works, Badge "Removed 'xxxxx' from 'Favorites' appears" and selected ROM will disapper on auto-favorite
The adding and removing works also in all-gamessystem
If I want directly remove from auto-favorites then ES crashes with "segmentataion fault"

What collections do you have enabled?

all three systems

Can you tell me where you have the ROM (subfolder? What exact system?).

I have symlinked FAT32 USB-Stick to ~/RetroPie/roms
There all system are arranged as in original state. The system does not matter if I enter auto-favoriteand press Y then ES is breaked.

Are you parsing gamelists? Not?

No... Parsing is diabled, saving of metadata on exit is enabled

Sorry for the trouble. That's certainly a problem, and I may end up having to put together a small debug build and send it your way just to get some more logs.

But I located the bug!
It is the power saving feature @hex in the older version with the info note!
If it is disabeld it works! enabeld it crashes ES....
I provide the binary in download archive here >> https://github.com/crcerror/emulationstation-binary-archive
Go to PI2/3 section and download Powersaving and Favorite system build. I'm on journey and can't test out now. But as I said it's the older version of @hex mod.
It may be elimanated in newer versions!

I edited my previous post

Annother small bug

In auto-lastplayed if you press select and menu with filter will pop up then filtering of "sort games by" is automatically set to "Filename, Ascending"

You will loose setted feature "Last Played, Ascending" even after you leave system and enter it again. Just after restart!

pjft

@cyperghost Thanks.

That's good to know, and thanks for investigating and narrowing down.

@Hex : is this something you'd be able to debug on your end, as to why we're getting a segmentation fault if we remove an element from the current view? Maybe you'll be able to replicate it if you edit the metadata of a game and choose to delete the file (attention: it will effectively delete a file, so you may want to create test files for that). See if that crashes on your end at the moment, as it seems not to happen without PS enabled.

In regards to the auto-lastplayed filter, yeah, I know... we don't have pre-sets selected in the menu, which sucks. That also happens if you sort any gamelist, and then go back to the menu.

I may leave it at that for now and fix it later, as that's a separate thing, but good catch.

Thanks!

cyperghost

@pjft said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

That's good to know, and thanks for investigating and narrowing down.

Yes, better to catch this in early development state. Maybe it's fixed in later power saving branches but I've no chance to test. Someone must merge yours and @hex branch and test out!

@Hex
ES just breaks if you press Y in auto-favoritesystem
All other systems work as aspected!

In regards to the auto-lastplayed filter, yeah, I know... we don't have pre-sets selected in the menu, which sucks. That also happens if you sort any gamelist, and then go back to the menu.
I may leave it at that for now and fix it later, as that's a separate thing, but good catch.

Can you reload sort mode after entering auto-lastplayed again?

Thanks!

Thank you for debugging instructions!

pjft

So, end of day update:

Added the "caps" to the system name;
Adjusted the "Go to Random Game" functionality to behave as discussed earlier;
Added a "Filter by Favorites" per system, so far. I may add an option to make it global to be closer to the ES-Kids branch at a later stage, but not for now.
(Hopefully) A few fixes to nasty, hidden bugs spotted by @Zigurana (thanks!).
A few other quality of life changes, I suppose, but mostly around the code.

So if nobody runs into issues when testing it, I'm reasonably happy with its current state and hopefully the PR can go into the normal approval flow.

Well, as soon as I rebase it, I imagine.

Thank you all!

If all goes well, next stop: user created collections!

lilbud

@pjft said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

next stop: user created collections

Will they function the same as favorites and lastplayed? Also, how would we create them? would it be done through ES?

pjft

@lilbud The idea is that all will be created via ES.

See here for the concept:

https://retropie.org.uk/forum/post/90376

cyperghost

@pjft
I merged your brach together with powersavings enabeld.
The bug @hex Powersavings is still there :( - I will post this habbit on PowerSavings Thread

Added the "caps" to the system name;

works!

Adjusted the "Go to Random Game" functionality to behave as discussed earlier;

Nice solution. If there is no other urgent need for X then it is a good usecase

Added a "Filter by Favorites" per system, so far. I may add an option to make it global to be closer to the ES-Kids branch at a later stage, but not for now.

Well this works as an filter for auto-lastgames to show only favorite entries.
Why not? At the moment I see no usecase and but no case against this...

(Hopefully) A few fixes to nasty, hidden bugs spotted by @Zigurana (thanks!).

A few other quality of life changes, I suppose, but mostly around the code.

Didn't notice ;)

I upload binary to my github https://github.com/crcerror/emulationstation-binary-archive

pjft

@cyperghost Thanks for testing!

You can, I suppose, filter by favorites the "All Games" list to have the same as favorites, sure. It's just that access to Favorites is a common use case, but yeah, good catch.

I added this morning a sort by system, which is useful on the collections.

I'm still finalizing a bug fix from @Zigurana 's report, as it isn't fixed yet :)

The PS bug will need to be looked into on the PS side of things, as I don't know what's being added there. But hopefully that'll be done in due time.

Thanks for looking into this :)

cyperghost

@pjft @Hex

uploaded binary!
Feel free to test on your mashines
It's called ES 2.3.1 RP merged commit favorites + power saving v2

lilbud

@cyperghost said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

ES 2.3.1 RP merged commit favorites + power saving v2

and Knuckles

cyperghost

@lilbud said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

@cyperghost said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

ES 2.3.1 RP merged commit favorites + power saving v2

and Knuckles

Sorry? - I didn't get you

lilbud

@cyperghost

http://knowyourmeme.com/memes/knuckles

cyperghost

@lilbud
Yes I should use shorter descriptions.
But not really much would download and install the compiled binaries - sadly.
That would speed up debugging a lot!

pjft

Hi all.

Thanks a lot for your hard work and effort in testing this!

It's now been merged to the main repository, so you now have favorites and such provided you're using a supported theme:)

Next stop: custom collections. I'll open a new topic for that when there's something to test!

Thanks and have a great weekend.

meleu

@pjft Huge thanks bro!!

pjft

@meleu not at all, my pleasure!

Go and have fun. :)