Please Test: Adding support for "All", "Favorites" and "Last Played" systems

lilbud

@pjft said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

next stop: user created collections

Will they function the same as favorites and lastplayed? Also, how would we create them? would it be done through ES?

pjft

@lilbud The idea is that all will be created via ES.

See here for the concept:

https://retropie.org.uk/forum/post/90376

cyperghost

@pjft
I merged your brach together with powersavings enabeld.
The bug @hex Powersavings is still there :( - I will post this habbit on PowerSavings Thread

Added the "caps" to the system name;

works!

Adjusted the "Go to Random Game" functionality to behave as discussed earlier;

Nice solution. If there is no other urgent need for X then it is a good usecase

Added a "Filter by Favorites" per system, so far. I may add an option to make it global to be closer to the ES-Kids branch at a later stage, but not for now.

Well this works as an filter for auto-lastgames to show only favorite entries.
Why not? At the moment I see no usecase and but no case against this...

(Hopefully) A few fixes to nasty, hidden bugs spotted by @Zigurana (thanks!).

A few other quality of life changes, I suppose, but mostly around the code.

Didn't notice ;)

I upload binary to my github https://github.com/crcerror/emulationstation-binary-archive

pjft

@cyperghost Thanks for testing!

You can, I suppose, filter by favorites the "All Games" list to have the same as favorites, sure. It's just that access to Favorites is a common use case, but yeah, good catch.

I added this morning a sort by system, which is useful on the collections.

I'm still finalizing a bug fix from @Zigurana 's report, as it isn't fixed yet :)

The PS bug will need to be looked into on the PS side of things, as I don't know what's being added there. But hopefully that'll be done in due time.

Thanks for looking into this :)

cyperghost

@pjft @Hex

uploaded binary!
Feel free to test on your mashines
It's called ES 2.3.1 RP merged commit favorites + power saving v2

lilbud

@cyperghost said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

ES 2.3.1 RP merged commit favorites + power saving v2

and Knuckles

cyperghost

@lilbud said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

@cyperghost said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

ES 2.3.1 RP merged commit favorites + power saving v2

and Knuckles

Sorry? - I didn't get you

lilbud

@cyperghost

http://knowyourmeme.com/memes/knuckles

cyperghost

@lilbud
Yes I should use shorter descriptions.
But not really much would download and install the compiled binaries - sadly.
That would speed up debugging a lot!

pjft

Hi all.

Thanks a lot for your hard work and effort in testing this!

It's now been merged to the main repository, so you now have favorites and such provided you're using a supported theme:)

Next stop: custom collections. I'll open a new topic for that when there's something to test!

Thanks and have a great weekend.

meleu

@pjft Huge thanks bro!!

pjft

@meleu not at all, my pleasure!

Go and have fun. :)

red2blue

@pjft hey man I'm super confused and I don't quite understand github and compiling...

So how do I incorporate your features on to my pi?? I really want the favorites thing and the power saving thing..

Also since we're on the subject how do I grab things from github branches and put it into my pi??? Like when I go under comments for let's say retropie github and people add fixes or features how do I put that onto my pi?

red2blue

@pjft how do I update it to make it do this from main repository

Hex

@red2blue All you have to do is update emulationstation from source in Retropie setup and it will have this feature as it has been incorporated into main repo

red2blue

@Hex oh sweet!! Does it come with your power saving thing as well??

Do i need to take my emulationstayion off kids mode? Which themes are supported?

Also can you help me on loading github requests pulls or whatever it's called onto my pi?

Hex

@red2blue said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

@Hex oh sweet!! Does it come with your power saving thing as well??

No

Do i need to take my emulationstayion off kids mode? Which themes are supported?

I dont have any experiance with kids mode. is it a setting or a different install altogether. @meleu can you answer this

Also can you help me on loading github requests pulls or whatever it's called onto my pi?

Which PR are you interested in? https://github.com/RetroPie/EmulationStation/pulls

red2blue

@Hex Emulation Station Kids Mode is another type of Emulation station you can install, before.. thats what you were suppose to use for the favorites thing.

a PR i would like to install would be yours, haha https://github.com/RetroPie/EmulationStation/pull/172

So how would i do that?

Hex

@red2blue My PR is currently in heavy testing. I would suggest you not use it unless you are confident enough to report and run test code on your system. Also I have not tested it with recently merged PRs so it might have some bugs. You can test out a clean build from my branch feature-powersaver using meleu's script

red2blue

@Hex said in Please Test: Adding support for "All", "Favorites" and "Last Played" systems:

feature-powersaver

can you explain how i can test out the clean version? but you said its still in heavy testing right?