Gamepad buttons stop working in retropie-setup 4.2.12

BuZz

There have been some changes to the way it maps buttons recently. Could be related to changes from @meleu or a recent commit from someone else. Which controllers do you have connected and in which ports etc?

meleu

@buzz the OP says that his setup was working fine in 4.2.7. My changes in joy2key happened in 4.2.3, as we can see browsing the RetroPie-Setup repo at the point of history where my PR was merged.

I see a commit from @psyke83 in joy2key's history, and the diff shows that he/she changed some buttons related code: https://github.com/RetroPie/RetroPie-Setup/commit/96e6efca4649d03e93f1ded04539034a9c8d2353

psyke83

It could be caused by my commit but I don't have a second pad to test. Can someone post their controller .cfg (in /opt/retropie/configs/all/retroarch-joypads/) for the pad that's giving problems?

BuZz

@meleu Yep, that was the other commit I mentioned. Could be that - or could be some kernel related thing to do with joypad order perhaps (although joy2key should handle it).

psyke83

@buzz said in Gamepad buttons stop working in retropie-setup 4.2.12:

@meleu Yep, that was the other commit I mentioned. Could be that - or could be some kernel related thing to do with joypad order perhaps (although joy2key should handle it).

I think it's a problem with my commit, but I need help from someone with one of those pads to share their config file. To be sure it's not the kernel, etc, they could try reverting my commit:
cd RetroPie-Setup
git revert 96e6efca4649d03e93f1ded04539034a9c8d2353

To get back to normal:
cd RetroPie-Setup
git reset --hard origin/master

EvilDindon

Same here.

But i found that pressing "start" instead of "a" during launching works : the launching menu options appear !

psyke83

@evildindon said in Gamepad buttons stop working in retropie-setup 4.2.12:

Same here.

But i found that pressing "start" instead of "a" during launching works : the launching menu options appear !

The runcommand dialog is a bit misleading. I think it means any key ("a" as an article, not the "a" key), so any recognized key might trigger (but I'm not 100% certain). If the problem is my commit, joy2key is not parsing the a/b keys correctly for some reason.

meleu

@psyke83 said in Gamepad buttons stop working in retropie-setup 4.2.12:

I think it means any key ("a" as an article, not the "a" key)

It changed. I posted about it here: https://retropie.org.uk/forum/topic/10321/looking-for-testers-custom-joystick-mappings-for-runcommand-retropie_setup-menus

lostless

@psyke83 said in Gamepad buttons stop working in retropie-setup 4.2.12:

git revert 96e6efca4649d03e93f1ded04539034a9c8d2353

got this error when trying to revert.

error: Your local changes would be overwritten by revert.
hint: Commit your changes or stash them to proceed.
fatal: revert failed

The joystick that is causing issues has 2 controllers with the same name. The second player works. Just player 1 can't select anything, only move around with the dpad.
heres the config.

input_device = "Twin USB Joystick"
input_driver = "udev"
input_r_y_plus_axis = "+2"
input_l3_btn = "10"
input_r_x_minus_axis = "-3"
input_l_btn = "6"
input_load_state_btn = "6"
input_start_btn = "9"
input_exit_emulator_btn = "9"
input_l_y_minus_axis = "-1"
input_up_btn = "h0up"
input_r_y_minus_axis = "-2"
input_a_btn = "1"
input_b_btn = "2"
input_reset_btn = "2"
input_enable_hotkey_btn = "10"
input_down_btn = "h0down"
input_l_x_plus_axis = "+0"
input_l_y_plus_axis = "+1"
input_r_btn = "7"
input_save_state_btn = "7"
input_r2_btn = "5"
input_r3_btn = "11"
input_right_btn = "h0right"
input_state_slot_increase_btn = "h0right"
input_x_btn = "0"
input_menu_toggle_btn = "0"
input_select_btn = "8"
input_l_x_minus_axis = "-0"
input_y_btn = "3"
input_left_btn = "h0left"
input_state_slot_decrease_btn = "h0left"
input_r_x_plus_axis = "+3"
input_l2_btn = "4"

BuZz

@meleu Any mapped button should still trigger the menu - it shouldn't mean the "A button", since any keyboard button should also work (or at least any button that outputs something)

BuZz

@lostless Please use a code block for configs as detailed in the sticky topic - http://commonmark.org/help/ (please edit your post and add the ``` characters above and below the config)

lostless

@buzz sorry to derail the thread, but what key is that? can't find it anywhere on my mac. I had to copy and paste.

BuZz

@lostless backtick

lostless

@buzz LOL thanks. found it on my above my tab. never knew it existed in all the years I've been staring at it. I only ever used the shift tilde.

edmaul69

@psyke83 it didnt work.after running the first git it brings up a nano script about the changes. not sure if i was supposed to edit so i just pressed ctrl + X. here is what it said when i ran the two things:

root@retropie:/home/pi/RetroPie-Setup# git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
[master d0d9715] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)
root@retropie:/home/pi/RetroPie-Setup# git reset --hard origin/master           
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms

edmaul69

@psyke83 also, if only updating retropie-setup caused this could it still be a kernel issue as i only updated retropie-setup and not the kernel?

psyke83

@edmaul69 said in Gamepad buttons stop working in retropie-setup 4.2.12:

@psyke83 it didnt work.after running the first git it brings up a nano script about the changes. not sure if i was supposed to edit so i just pressed ctrl + X. here is what it said when i ran the two things:
root@retropie:/home/pi/RetroPie-Setup# git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
[master d0d9715] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)
root@retropie:/home/pi/RetroPie-Setup# git reset --hard origin/master           
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms

Try again, but keep in mind that you need to test your pad after the revert command. The reset command is to undo those changes after testing (otherwise retropie-setup will fail to update itself correctly).

psyke83

@lostless said in Gamepad buttons stop working in retropie-setup 4.2.12:

@psyke83 said in Gamepad buttons stop working in retropie-setup 4.2.12:

git revert 96e6efca4649d03e93f1ded04539034a9c8d2353

got this error when trying to revert.
error: Your local changes would be overwritten by revert.
hint: Commit your changes or stash them to proceed.
fatal: revert failed

TY, I'll look into it soon. It seems that you have existing changes that are preventing the commit to be reverted.

You can see the changes via "git diff". If you're not aware of having made manual changes to the scripts, then you can use the "git reset" I posted earlier, but it will wipe out your changes, so be careful.

edmaul69

@psyke83 good news. it actually works. i did it with putty as root user. it makes you give an email and user name. after that you have to install runcommand again to get runcommand to work with controller 0

edmaul69

@lostless use putty on windows logging in as root. then after you do what he said, go into retropie-setup and reinstall runcommand. might have to reboot somewhere in there before reinstalling runcommand. it worked in everything else just not runcommand