Gamepad buttons stop working in retropie-setup 4.2.12

BuZz

lostless

@buzz LOL thanks. found it on my above my tab. never knew it existed in all the years I've been staring at it. I only ever used the shift tilde.

edmaul69

@psyke83 it didnt work.after running the first git it brings up a nano script about the changes. not sure if i was supposed to edit so i just pressed ctrl + X. here is what it said when i ran the two things:

root@retropie:/home/pi/RetroPie-Setup# git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
[master d0d9715] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)
root@retropie:/home/pi/RetroPie-Setup# git reset --hard origin/master           
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms

edmaul69

@psyke83 also, if only updating retropie-setup caused this could it still be a kernel issue as i only updated retropie-setup and not the kernel?

psyke83

@edmaul69 said in Gamepad buttons stop working in retropie-setup 4.2.12:

@psyke83 it didnt work.after running the first git it brings up a nano script about the changes. not sure if i was supposed to edit so i just pressed ctrl + X. here is what it said when i ran the two things:
root@retropie:/home/pi/RetroPie-Setup# git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
[master d0d9715] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)
root@retropie:/home/pi/RetroPie-Setup# git reset --hard origin/master           
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms

Try again, but keep in mind that you need to test your pad after the revert command. The reset command is to undo those changes after testing (otherwise retropie-setup will fail to update itself correctly).

psyke83

@lostless said in Gamepad buttons stop working in retropie-setup 4.2.12:

@psyke83 said in Gamepad buttons stop working in retropie-setup 4.2.12:

git revert 96e6efca4649d03e93f1ded04539034a9c8d2353

got this error when trying to revert.
error: Your local changes would be overwritten by revert.
hint: Commit your changes or stash them to proceed.
fatal: revert failed

TY, I'll look into it soon. It seems that you have existing changes that are preventing the commit to be reverted.

You can see the changes via "git diff". If you're not aware of having made manual changes to the scripts, then you can use the "git reset" I posted earlier, but it will wipe out your changes, so be careful.

edmaul69

@psyke83 good news. it actually works. i did it with putty as root user. it makes you give an email and user name. after that you have to install runcommand again to get runcommand to work with controller 0

edmaul69

@lostless use putty on windows logging in as root. then after you do what he said, go into retropie-setup and reinstall runcommand. might have to reboot somewhere in there before reinstalling runcommand. it worked in everything else just not runcommand

edmaul69

@psyke83 you cant do it logged in as pi is @lostless ' problem. root user on putty works as i dont know how to login as root on the pi itself.

psyke83

It's not a good idea to run as root. Use pi@retropie or pie@<ip address> from a client such as putty. Use sudo selectively if temporary administrator privileges are needed for a command.

MrPotato

Thanks all for chiming in. Home now -- will run the requested tests.

To answer a few things first off:

If looking at the USB ports, I am using the left-most ports, one on top and one on bottom. I typically use that upper left port as the primary.
The controllers are USB iBuffalo SNES controllers. On both controllers Pressing "start" during ROM launch does nothing. Pressing "a" on both controllers does nothing.
Here is my "USB-axis 8-button gamepad.cfg" file. Note that, in my brief troubleshooting, I did try to remap the controller while in EmulationStation, so not sure if that affects this.

input_device = "USB,2-axis 8-button gamepad  "
input_driver = "udev"
input_l_btn = "4"
input_load_state_btn = "4"
input_start_btn = "7"
input_exit_emulator_btn = "7"
input_up_axis = "-1"
input_a_btn = "0"
input_b_btn = "1"
input_reset_btn = "1"
input_down_axis = "+1"
input_r_btn = "5"
input_save_state_btn = "5"
input_right_axis = "+0"
input_state_slot_increase_axis = "+0"
input_x_btn = "2"
input_menu_toggle_btn = "2"
input_select_btn = "6"
input_y_btn = "3"
input_left_axis = "-0"
input_state_slot_decrease_axis = "-0"
input_enable_hotkey_btn = "6"

Will try the rollback next. Stay tuned.

MrPotato

My output. I haven't made any special changes, so not sure why it does this. Will try the reset thing next, then try this again.

pi@retropie:~ $ cd RetroPie-Setup
pi@retropie:~/RetroPie-Setup $ git revert 96e6efca4649d03e93f1ded04539034a9c8d2353

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <pi@retropie.(none)>) not allowed

pi@retropie:~/RetroPie-Setup $ sudo git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
error: Your local changes would be overwritten by revert.
hint: Commit your changes or stash them to proceed.
fatal: revert failed

MrPotato

When resetting:

pi@retropie:~/RetroPie-Setup $ git diff
pi@retropie:~/RetroPie-Setup $ sudo git diff
pi@retropie:~/RetroPie-Setup $ git reset
Unstaged changes after reset:
M       scriptmodules/helpers.sh
M       scriptmodules/supplementary/runcommand/joy2key.py
pi@retropie:~/RetroPie-Setup $ sudo git reset
Unstaged changes after reset:
M       scriptmodules/helpers.sh
M       scriptmodules/supplementary/runcommand/joy2key.py

rebooted, and then...

pi@retropie:~ $ git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
fatal: Not a git repository (or any of the parent directories): .git
pi@retropie:~ $ sudo git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
fatal: Not a git repository (or any of the parent directories): .git

So, not sure where to go from here.

MrPotato

Tried to edit posts, but the "spam blocker" keeps disallowing me.
Helps if I'm in the RetroPie-Setup directory. :)
But still not getting as expected. Can't copy/paste the whole thing because of "Akismet":

error: Your local changes to the following files would be overwritten by merge:
        scriptmodules/helpers.sh
        scriptmodules/supplementary/runcommand/joy2key.py
Please, commit your changes or stash them before you can merge.
Aborting

Same with sudo.

So, I'm not entirely sure what's happened, but in testing now:

I can now use the controller in menus once again.
But I still can't press a key when launching a game to bring up the options.

After testing:

pi@retropie:~/RetroPie-Setup $ git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms

Rebooted.

Back to no function in menus.

So, I think you're on to something here.

psyke83

You made a few mistakes. Try this

cd RetroPie-Setup
sudo git reset --hard origin/master

This should reset everything back to normal.

To revert the faulty patch:

cd RetroPie-Setup
sudo git revert 96e6efca4649d03e93f1ded04539034a9c8d2353

(Yes, press ctrl+x to complete the revert)

Once you've reverted a commit, you will have trouble updating the script, so re-run the same "reset --hard ..." command once more to undo the revert.

It's not necessary to perform a reboot -- just make sure you're not already in the RetroPie-Setup script's menu in another terminal or via the ES interface. If you are, just quit and relaunch the script.

MrPotato

Bombed on the first part.

pi@retropie:~ $ cd RetroPie-Setup
pi@retropie:~/RetroPie-Setup $ sudo git reset --hard upstream/master
fatal: ambiguous argument 'upstream/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

psyke83

@mrpotato said in Gamepad buttons stop working in retropie-setup 4.2.12:

Bombed on the first part.

Damn, sorry. Refresh the post (was supposed to be origin/master just as I wrote in the earlier post).

MrPotato

:) I thought maybe so. :)

Ok. Bombed on second part. :) Guessing I need to "set my identity" with those commands? (Cannot paste full input string for the revert command.. "Akismet" blocks it)

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <string here>

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'root@retropie.(none)')

MrPotato

Ok.

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <long string here... removed because of filter>
[master b4bf393] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)

Testing. Reset same as when I did the "reset".

Works in menus.
Still doesn't work when launching ROMs.

psyke83

@mrpotato said in Gamepad buttons stop working in retropie-setup 4.2.12:

Ok.

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <long string here... removed because of filter>
[master b4bf393] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)

Testing. Reset same as when I did the "reset".

Works in menus.
Still doesn't work when launching ROMs.

So I think we can surmise that the button mappings don't work correctly because of my patch, but the runcommand issue is not related to my patch.