Gamepad buttons stop working in retropie-setup 4.2.12

MrPotato

:) I thought maybe so. :)

Ok. Bombed on second part. :) Guessing I need to "set my identity" with those commands? (Cannot paste full input string for the revert command.. "Akismet" blocks it)

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <string here>

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'root@retropie.(none)')

MrPotato

Ok.

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <long string here... removed because of filter>
[master b4bf393] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)

Testing. Reset same as when I did the "reset".

Works in menus.
Still doesn't work when launching ROMs.

psyke83

@mrpotato said in Gamepad buttons stop working in retropie-setup 4.2.12:

Ok.

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <long string here... removed because of filter>
[master b4bf393] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)

Testing. Reset same as when I did the "reset".

Works in menus.
Still doesn't work when launching ROMs.

So I think we can surmise that the button mappings don't work correctly because of my patch, but the runcommand issue is not related to my patch.

MrPotato

Well, edmaul69 did say he had to reinstall runcommand after the revert. No idea what is affecting that, but it worked fine prior to the setup script update. :\

MrPotato

Went back to "normal" with sudo git reset --hard origin/master.
Then went into setup and did an 'update from binary' on runcommand.
Then rebooted.
Ugh.. pressing a key when launching a game still isn't working. (though, it does work on 2nd controller. :P)
Seems I am not in a good place. :(

Darksavior

I can't run the git revert in either putty or real terminal. Putty says some crap about inputting my email with root and real terminal just flat out tells me revert failed.

MrPotato

@darksavior said in Gamepad buttons stop working in retropie-setup 4.2.12:

I can't run the git revert in either putty or real terminal. Putty says some crap about inputting my email with root and real terminal just flat out tells me revert failed.

Use the config commands to set your email/name and those get resolved. :)

obsidianspider

For what it's worth, I am having the same issue, I think.I'm on 4.2.12 on my SFC pi with a raphnet USB SNES controller adapter.

I was trying to install lr-snes9x tonight and while I can use the D pad in retropie-setup, I can't confirm anything or exit out of it. I tried plugging in my second controller, but no dice. The controllers work just fine in emulationstation and in games.

I also cannot get the runcommand menu to come up when a game is loading. I used to press A but no action buttons are triggering it.

Darksavior

@mrpotato I'll keep at it. so far it's not seeing the email address I put in. This is just ridiculous that I have to do this at all. Still getting revert failed.
Edit: actually, I give up since there's not much else to do. I'll wait for 4.2.13 or whatever officially fixes it.
Edit2: for whatever I was doing, seems the problem is fixed despite getting revert failed.

obsidianspider

Considering @Darksavior having a bit of success, I updated to the newest revision of 4.1.2, which as of right now is (bda4718) and the problem is still present.

MrPotato

I've unplugged one controller. With a single controller, I have most functionality. Obviously won't work long term since we use both regularly, but at least I can rock it solo for now.

psyke83

Can someone with the controller issue please test this modified script?

Enter the retropie-setup folder:

cd RetroPie-Setup

Undo any changes if you followed my prior steps to revert the commit:

git reset --hard origin/master

Fetch and apply the patch:

wget https://gist.githubusercontent.com/psyke83/9a0b31bcd8f43d16d081462363741f35/raw/4ce063642e9088c3faa541d965d439d50c951101/joy2key.patch
patch -p1 <joy2key.patch

If everything goes as expected, you should see:

patching file scriptmodules/supplementary/runcommand/joy2key.py

If there are no further messages/errors, then the patch was applied and is ready to test.

Slightly OT: guys & gals, try not to complain too much. The Pi itself is supposed to be a hobbyist board to encourage people to learn Linux & programming. That may not be your intended purpose, but keep an open mind. If you don't want to go near a terminal, leave it to someone else to test & and wait for the inevitable fix to be merged. The problem was my fault, but I don't have a second pad available so it's difficult for me to reproduce the issue.

Darksavior

@psyke83 I'm using a backup I made last month and with just updating the script to 4.2.12 to introduce the bug, I ran the patcher and did nothing.

psyke83

@darksavior You mean it didn't fix the problem?

Once the patch is applied you still need to enter the retropie-setup menu yourself.

Darksavior

@psyke83 Yea, that's what I meant. The patcher did do the patching, but it did not fix the problem.

psyke83

Please try the second patch:

cd RetroPie-Setup
git reset --hard origin/master
wget -N https://gist.githubusercontent.com/psyke83/9a0b31bcd8f43d16d081462363741f35/raw/89fae3f4a7a6309fd7cc5863ed62f245f84c729f/joy2key.patch
patch -p1 <joy2key.patch

Darksavior

@psyke83 That works. Many thanks.
I also retested it again from my old backup. I update script to 4.2.12, bug introduced, exit retropie-setup, added your patch, re-enter retropie-setup and controls work again.

psyke83

TY. I've submitted the patch via PR #2059.

Keep using the patch until the PR has been accepted & merged. When it's merged, you'll need to do a hard reset to clear the local changes or else the script update will fail.

cd RetroPie-Setup
git reset --hard origin/master

Darksavior

@psyke83 bit offtopic, but I want to try your gamecon fix if you can provide the instructions. I've been stuck on 4.4 kernel because of that.

MrPotato

Had signed off last night so just seeing the updates.
I'm back in reset normal mode -- I think I'll plan to wait for merge and verify everything comes through then. I can live with the nuances until then without much issue, and it will give another datapoint just in case.
Thanks, psyke83!