Favorites for EmulationStation

pjft

@DarkWolf it might have been written at s time when only the Pi 1 was around. But either way, under promising and over delivering is better than the other way around:)

DarkWolf

One thing I noticed is that if I want to shutdown/restart the system it only closes emulationstation and leaves me with a console left

pjft

@DarkWolf that's normal when you're calling emulationstation from the terminal. :)

DarkWolf

@pjft Like I said before I installed it over an existing emulationstation (or retropie to be exact)... I just switched the emulationstation files

pjft

@DarkWolf oh, apologies. And did you launch it by restarting the system? Does that happen when you restart the system?

DarkWolf

@pjft
It automaticly launches on boot... If I than want to shut the pi down or reboot it, it closes es and thats it

pjft

@DarkWolf I see. Thanks for catching it then, as I doubt it would have been caught by many. Hopefully it'll help tracking it down.

Still, that's a very specific part of the code to have been messed with, and very much unrelated to this development, so I'm intrigued by what's causing it.

DarkWolf

I found another thing... When I want to add a second game to favorites (in one system, but not every one... for example in atari5200/7800) emulationstation crashes with following error message:

/opt/retropie/configs/all/autostart.sh line1: 930 Segmentation fault
emulationstation

EDIT:
Seems like it happens on all systems with scraped data..
(Don't know if this helps, but my gamelist.xml's are in the rom folders)

pjft

@DarkWolf does that mean it crashes when you make a second game a favorite?

How are you adding it? In the gamelist, manually? Via the metadata editor in ES? Do you have any filters active when it crashes (I.e. are you filtering by favorites)? When exactly does it crash? What are the exact step by step instructions to make that happen?

There are quite a few new things here so it can be reasonably anything - either the favorites logic to the filtering or indexing. Let us know some more details, so we can investigate further. :)

Edit: also, if you want to share a gamelist that crashes, that'd be handy!

mattrixk

Jeez I go to sleep and then work for a few hours and I miss all the fun stuff.

@pjft:

you'd want to have a bit more control over the position of the folder icon

I hadn't thought of that. I guess I was just expecting it to go inline with the text, but you can't really expect an image to behave the same way / use the same properties as the text element.

@Zigurana: I was thinking about gamelist icons before falling asleep last night, and I wondered if Font Icons would be a feasible solution. I use Font Awesome on every site I make at work and I love it. With nearly 800 icons there should be something for most use cases.

For anyone curious, you can see the full list of Font Awesome icons on their Cheatsheet.

I can think of these elements of the <gamelist> that might need their own icon:

folder
favourite
kids
hidden

They can each have a default icon built into the system that a Theme Maker can override in their XML, like:

<icon name="md_favorite">
  <name>fa-heart</name>
</icon>

They could go at the end of the game name like this:

Imgur

That way the names are still all left aligned, except the folder which would stand out a bit from the rest.

TMNTturtlguy

@mattrixk hmmmm....interesting, but what you are showing is the icon still being a part of the text element and this would limit a lot of options for placing text in themes. Every theme would need to have their text left aligned in order to make this appear correctly. In themes like my comic book theme, or even more significant, in themes like @ruckage is working on where he lines the text up in outlined boxes, this would really limit the creativity.

I do like the icons, and the simplicity of it, but I wonder if there is a way to allow more flexibility?

mattrixk

@TMNTturtlguy Maybe have them right after the name, instead of right aligned? But then if the name is too long, then the icons would be off the page...

It's a dilly of a noodle-scratcher isn't it?

DarkWolf

@pjft Exactly, it is a per system thing...

How are you adding it? - I'am adding it through the Y Button ("Toggle favorites")
Do you have any filters active when it crashes (I.e. are you filtering by favorites) - No filters
When exactly does it crash? - When I press the Y button on my controller
What are the exact step by step instructions to make that happen? - Boot retropie, go into a system with roms and scraped data (no matter where the gamelist.xml files are), add one game to favorites (Y), add another game to favorites (Y)

Gamelist.xml:
Download
Located at: /home/pi/RetroPie/roms/atari5200/
Scraped with: UXS (Screenscraper)

Hopefully that doesn't have to do with me being stupid, but, yeah,...

pjft

@DarkWolf thanks, that should be useful for troubleshooting!

DarkWolf

@DarkWolf I found the problem right here. I guess I was just stupid and used sudo make install and killed the files/install with that! Switching the emulationstation file only works then

The segmentation error is still there sadly

pjft

@DarkWolf Just to confirm, what problem did you find and solve with this one - the crash on double favorites, or the shutdown one?

DarkWolf

@pjft The shutdown one, edited my previous answer

DarkWolf

I looked into the code a bit and I have to say:
Wow, my skills aren't enough for that...

I think there is something wrong with accessing variables/memory (got Segmentation Faults in one of my earlier tries..). In this particular case it seems, that non existing or gamelists generated by emulationstation are working but pre generated ones doesn't.

I don't know how much you guys know, but I guess @Zigurana knows a lot more about this than I do, but I'm just saying :-)
Hopefully I'm not spaming some unnecessary stuff

pjft

@DarkWolf No, not at all. It's also good to help others get into the code :)

I have not had the chance to test this yet, alas, but hopefully with your details @Zigurana will replicate it easily and debug it.

DarkWolf

Seems like I was able to track down the problem a bit:
I tested some different themes and view modes and it seems like the problem only occurs if the video view is activated!
Also the code that adds the favorite tag seems to work (debuged and added some log entries, code located in /es-app/src/view/gamelist/ISimpleGameListView.cpp), but the tag doesn't appear in the gamelist.xml (even the ones that worked)