Please Test: Adding support for "All", "Favorites" and "Last Played" systems

pjft

Yeah, it is stalling at 100% in my case. Will probably submit either a bug, or update the script with a bigger rpSwap.

Thanks.

Zigurana

Here you go, i'm mobile only, so sorry for the pic.
0_1499524849325_IMG_20170708_163915723(1).jpg

cyperghost

@Zigurana Thx... I think I missed a make clean before. Or we have different compilers :(. Our checksums differ. I think there is no time to hurry in the next few days a binary would be provided ...
@pjft Why we are still on version 2.3.2RP?

jdrassa

@cyperghost I believe the version number is only updated when a new binary is generated.

Hex

@cyperghost There is no guarantee that two binaries compiled on different machines with same sourcecode will have same hash. This is due to compiler selecting different approaches to optimize which results in entropy.

TMNTturtlguy

@pjft i saw you posted to the github pull request regarding the swap settings, but i thought it would be better for me to ask my questions here since i am so far out of the loop on the last 2 weeks of development.

My question to everyone is what do we think we are doing to ES that is causing this issue in the first place? It appears that the more we develop, the more issues we are having with the compiling/installation from source. When I first started working with retropie, i never needed to exit ES to update from source. Then a few months back we both found we were stalling out and @BuZz informed us we should always exit ES and update from source from command line. That worked for us, now after a lot more development, we have once again pushed the envelope that even installing from command line causes us to time out.

Hex

@TMNTturtlguy As more code is added to ES the compiler has to keep that many references in memory while linking. The pi is already at its limit with rpSwap 512. This causes slower sd cards to take a long time to compile and results in unnecessary writes to SD. There is nothing that can be done other that thinning the functionality of ES or discarding features which are not required. I am sure many would oppose this but it will be necessary soon as more code gets added to ES.

pjft

@TMNTturtlguy hi! I know, I hope you're not overly busy with work and can at least have some time off every now and then.

@Hex kind of summarized it already, though there's a separate factor here which seems to be that compiling via RetroPie-Setup is optimized for speed, and will start two compiler processes in parallel. While that will speed things up, it will also increase memory by 2x - meaning that for each necessary increase in memory to compile ES, by running two processes at the same time that's double the amount.

So right now there are two options - either increasing the swap, or making it not parallel. When we compile manually via git clone and make, it will succeed.

Hex

@pjft Do you mean 2X for Pi zero too? It makes sense to have it for Pi3 though

pjft

@Hex I don't know, sorry. I wasn't reading the code, just profiling processes and memory usage on my Pi3.

Hex

@pjft I did this in my script


# Find how may processors we can spare for compilation. If running on faster than dual core use 2 less
proc=$(( `nproc` >= 4 ? `nproc`-2 : 1 ))

make -j $proc

pjft

@Hex Thanks.

On a separate note, I just tested your latest build and I do confirm that the description scrolls, as well as long game names on the game list!

The game names seem to stop at the end, which is the same as in the main ES.

I won't oppose, then, if the description stops at the end as well so you only scroll once, though ideally I'd be supportive of both stopping at the beginning, and not permanently looping. But that can be a separate change.

But we can probably discuss this further on the power savings thread :)

Hex

@pjft Agreed. Congrats on getting this merged.

pjft

~~Redacted~~

It's now available via Update from Binary in RetroPie-Setup. Thanks @BuZz - I had compiled the code earlier in the day and it was still 2.3.2 so I didn't know it was updated to 2.4.0.

Thank you!

pjft

@Hex Thank you! Looking forward to getting yours merged as well :)

BuZz

@pjft Is that build different from main ES master ? ES binaries are up to date (v2.4.0)

pjft

Everyone: it's now available via Update from Binary.

Thanks @BuZz - I had compiled the code earlier in the day and it was still 2.3.2 so I didn't know it was updated to 2.4.0.

I have removed that link - it was the same binary, but before the commit to update the version.

Thank you.

TMNTturtlguy

@pjft I am excited about this new update, i apologize for not being able to help test. I know you are very busy and I plan to read through a bunch of the posts when i have time to find out how everything works, but i was wondering if you have or if you will create a wiki for how to use the new features? No rush on any of this as it will probably be a few weeks before i even get to test this stuff out!

EDIT: Never mind, as i put my shoes on to exit the house i realized this is for Lastplayed/favorites/all games and does not yet include the custom collections :)

pjft

@TMNTturtlguy Well, I really should document that on the Wiki, even if it's only All / Favorites / Last Played. You're right. :)

I also dropped a ball a bit on the video screensaver and OMX Player wiki. I suppose I'll need to get to that.

First let me finish the custom collections bit, and then I'll pick that up.

Thanks!

cyperghost

I just created new thread: Which theme is ready for virtual system (3) and custom-collections (1)
Please help to collect date which theme is ready and which means maintance