lr-mame2003 driver improvement and backport

Riverstorm

@gamez-fan said in lr-mame2003 driver improvement and backport:

@riverstorm

As per the driver these are the samples you now need for Donkey Kong and Donkey Kong Jr.

static const char *dkong_sample_names[] =
{
"run01.wav",
"run02.wav",
"run03.wav",
"jump.wav",
"dkstomp.wav",
};

static const char *dkongjr_sample_names[] =
{
"jump.wav",
"land.wav",
"roar.wav",
"climb0.wav",
"climb1.wav",
"climb2.wav",
"death.wav",
"drop.wav",
"walk0.wav",
"walk1.wav",
"walk2.wav",
"snapjaw.wav",
};

@gamez-fan Do you have a list of changed ROMs for the updates you implemented by chance? I think you said it wasn't many. I can update the DAT if you do. I updated the main DAT so it rebuilds with the correct Donkey Kong and Donkey Kong Jr. samples and has the correct merge information for clones, bootlegs, etc.

The other sets like "mame2003-lr-working-no-clones" look they used RomLister and all the merge information has been stripped. It also seems more games were removed than should be. It doesn't contain games like Donkey Kong and Donkey Kong Jr. for example which I believe are Nintendo.

Donkey Kong:
1 Parent
6 Clones

Donkey Kong Jr:
1 Parent
6 Clones

markwkidd

If you do update the DAT, could you please start with the official MAME 2003 DAT? If you don't already have it, you can download it here: https://github.com/libretro/mame2003-libretro/tree/master/metadata

In the long term I'm interested in either merging the new DAT info into the existing XML DAT, or creating a secondary "hacks" DAT that only incorporates the changes. Anything you can do will be welcome progress though! I don't expect to have time to work on this personally until next month.

Riverstorm

@markwkidd said in lr-mame2003 driver improvement and backport:

If you do update the DAT, could you please start with the official MAME 2003 DAT? If you don't already have it, you can download it here:

Thanks Mark I grabbed the one from the RetroPie docs but I'll grab the one posted in the repository due to the off chance they are different.

Samples are pretty straight forward (name and sampleof) but to update the ROM information I would need the name, size (in bytes), CRC hash & SHA1 hash. It looks like the merge tags are correct so converting between say ClrMamePro and ROMVault should work fine, as well as, parent/clone relationships. I do have the current MAME and rollback romset so really I just need to know which files are changing or like an existing file that's being renamed, shared, etc.

Riverstorm

@markwkidd - I merged the new samples for Donkey Kong & Donkey Kong Jr and added 'hack' to the end of the file name. You have a place to upload it?

I don't know if there's any value to knowing exactly which sets are using the samples. but possibly to check for any errors. Such as Radar Scope uses the same samples as Donkey Kong or Street Heat - Cardinal Amusements uses the same sample set as Donkey Kong Jr.

If the update didn't take these "other" games into account they will break or I can just update the samples for the changed games if there's a more specific list of exact games/clones updated. Leaving the existing samples intact for the "other" games.

For example if Radar Scope is looking for effect00.wav (a file in the original dkong.zip
sample) it will not work as Radar scope's parent for samples is dkong and it's been completely removed from all sets with the new samples.

Unless of course all clone games have incorporated the new sample changes. Which some of the "other" games might not even use the new samples. The two examples mentioned above are actually parent games using samples from other parent/clone games. Hopefully that makes sense.

darknior

https://github.com/libretro/mame2003-libretro/pull/228
https://github.com/libretro/mame2003-libretro/pull/229

0.88u7: BUT added sample support to Sasuke' (hit.wav, boss_start.wav, shot.wav, boss_attack.wav).
0.88u7: BUT added speech sample support to Fantasy' (ft_voi-0 - ft_voi-b.wav).
0.88u7: BUT added speech sample support to Vanguard' (vg_voi-0 to vg_voi-f.wav).
0.88u7: MAME32 Improved sample support for Rockola driver HD38880 speech by samples.
0.81u5: Curt Coder added Vanguard SHOTB sound effect.
0.81u4: Curt Coder hooked up SN76477 sound in Fantasy, Nibbler, Pioneer Balloon, Sasuke and Vanguard

@gamez-fan Fully tested no Roms have changed but to take advantage of the full range of
sound improvements new samples are needed for Fantasy, Sasuke and Vanguard
these are easily obtained from the old samples folder on Twistys site.

arcadez2003

@riverstorm said in lr-mame2003 driver improvement and backport:

@markwkidd - I merged the new samples for Donkey Kong & Donkey Kong Jr and added 'hack' to the end of the file name. You have a place to upload it?

I don't know if there's any value to knowing exactly which sets are using the samples. but possibly to check for any errors. Such as Radar Scope uses the same samples as Donkey Kong or Street Heat - Cardinal Amusements uses the same sample set as Donkey Kong Jr.

If the update didn't take these "other" games into account they will break or I can just update the samples for the changed games if there's a more specific list of exact games/clones updated. Leaving the existing samples intact for the "other" games.

For example if Radar Scope is looking for effect00.wav (a file in the original dkong.zip
sample) it will not work as Radar scope's parent for samples is dkong and it's been completely removed from all sets with the new samples.

Unless of course all clone games have incorporated the new sample changes. Which some of the "other" games might not even use the new samples. The two examples mentioned above are actually parent games using samples from other parent/clone games. Hopefully that makes sense.

All the games that use the dkong and dkongjr samples are just sharing the same code, the update to the samples should be fine for all the games

Regards.

arcadez2003

A final breakdown of the changes............

New games now supported in no particular order

Hyper Street Fighter II
Puzz Loop 2
Title Fight
Air Rescue
Baryon
Cute Fighters
Dream World
Gaia : The Last Choice Of Earth
Rolling Crush
FixEight (bootleg)
Hyper Crash
Gunbarich
Power Instinct Legends
Counter Run
Dyna Gears
Vasara 2
Sonic Boom
Bang Bang Busters
Ghost Loop
Choutetsu Brikin'ger - iron clad
Sengoku 3
Zupapa
King Of Fighters 2001
King Of Fighters 2002
King Of Fighters 2003
Metal Slug 4
Metal Slug 5
Rage Of The Dragons
Power Instinct Matrimelee
Pochi & Nyaa
Snk Vs Capcom : Svc Chaos
Samurai Shodown V
Samurai Shodown V Special
Zintrick
Crossed Swords 2
The Last Hope
Cabal (Joystick version with extra button 3 )
Asura Buster
Rock'n Tread 2
Rock'n 3
rock'n 4

Games fixed and or now working

Avenging Spirit
DJ Boy
Driftout 94
Fire Barrel
Monster Slider
Snowboard Championship
Street Fighter (with Added Speedup)
Twin Eagle 2

Games now with sound and or sound improvements

Cosmic Alien
Fire Shark
Vimana
Donkey Kong
Donkey Kong JR
Asura Buster
Asura Blade
Rock'n Tread 1 and 2
Rock'n 3 and 4
Fire Barrel
Sasuke Vs Commander
Fantasy
Nibbler
Pioneer Balloon
Vanguard

Improvements

Added sound support to Asura Blade / Asura Buster
Added sound support to Fire Shark and Vimana
Added sound support for Cosmic Alien
Added sound support for the Rock,n games
Added BritneysPAIRS sound sample improvements for Donkey Kong and Donkey Kong JR
New and improved sample support for Sasuke, Fantasy, Pioneer Balloon and Vanguard
Enabled single screen hack for Lode Runner The Dig Fight
Fixed end of game crash in Double Dragon
Fixed random crashes in Rampage World Tour
Added protection simulation for Snowboard Championship
Added dsp handling for Driftout 94 and Twin Eagle 2 both games now playable
Fixed incorrect game logic in Monster Slider game now playable
Fixed bad graphics and added sound to Fire Barrel game now playable

gamezfan with code additions via iq_132 and BritneysPAIRS.

Riverstorm

@gamez-fan said in lr-mame2003 driver improvement and backport:

New games now supported in no particular order...

Holy smokes, now that's a list! Nice work! I am not very good at navigating which source drivers belong to which games to retrieve names and hashes to build out the DAT so I might need help to locate the correct files.

All the games that use the dkong and dkongjr samples are just sharing the same code, the update to the samples should be fine for all the games

Thanks I've updated the dkong & dkongjr samples and clones. 2 down... :)

arcadez2003

Hyper Street Fighter II cps2.c
Puzz Loop 2 cps2.c
Title Fight multi32.c
Air Rescue system32.c
Baryon dreamwld.c
Cute Fighters dreamwld.c
Dream World dreamwld.c
Gaia : The Last Choice Of Earth dreamworld.c
Rolling Crush dreamwld.c
FixEight (bootleg) toaplan2.c
DJ Boy djboy.c
Hyper Crash nemesis.c
Gunbarich psikyosh.c
Power Instinct Legends cave.c
Counter Run freekick.c
Dyna Gears ssv.c
Vasara 2 ssv.c
Sonic Boom system16.c
Bang Bang Busters neogeo.c
Ghost Loop neogeo.c
Choutetsu Brikin'ger - iron clad neogeo.c
Sengoku 3 neogeo.c
Zupapa neogeo.c
King Of Fighters 2001 neogeo.c
King Of Fighters 2002 neogeo.c
King Of Fighters 2003 neogeo.c
Metal Slug 4 neogeo.c
Metal Slug 5 neogeo.c
Rage Of The Dragons neogeo.c
Power Instinct Matrimelee neogeo.c
Pochi & Nyaa neogeo.c
Snk Vs Capcom : Svc Chaos neogeo.c
Samurai Shodown V neogeo.c
Samurai Shodown V Special neogeo.c
Zintrick neogeo.c
Crossed Swords 2 neogeo.c
The Last Hope neogeo.c
Cabal (Joystick version with extra button 3 ) cabal.c
Asura Buster fuukifg3.c
Rock'n Tread 2 tetrisp2.c
Rock'n 3 tetrisp2.c
rock'n 4 tetrisp2.c

Games fixed and or now working

Avenging Spirit megasys1.c
Driftout 94 ssv.c
Fire Barrel m107.c
Monster Slider ssv.c
Snowboard Championship gaelco2.c
Street Fighter (with Added Speedup) sf1.c
Twin Eagle 2 ssv.c

Games now with sound and or sound improvements

Cosmic Alien cosmic.c
Fire Shark toaplan1.c
Vimana toaplan1.c
Donkey Kong dkong.c
Donkey Kong JR dkong.c
Asura Buster fuukifg3.c
Asura Blade fuukifg3.c
Rock'n Tread 1 and 2 tetrisp2.c
Rock'n 3 and 4 tetrisp2.c
Fire Barrel m107.c
Sasuke Vs Commander rockola.c
Fantasy rockola.c
Nibbler rockola.c
Pioneer Balloon rockola.c
Vanguard rockola.c

Riverstorm

@gamez-fan said in lr-mame2003 driver improvement and backport:

Hyper Street Fighter II cps2.c

Just using this one as an example. The ROM is hfs2a.zip for game "Hyper Street Fighter II: The Anniversary Edition (Asia 040202)"

arcadez2003

@riverstorm said in lr-mame2003 driver improvement and backport:

@gamez-fan said in lr-mame2003 driver improvement and backport:

Hyper Street Fighter II cps2.c

Just using this one as an example. The ROM is hfs2a.zip for game "Hyper Street Fighter II: The Anniversary Edition (Asia 040202)"

Yip spot on

maxbeanz

@riverstorm Hi, could you also make a separate DAT with only the new/changed ROMs and samples (like @markwkidd said) ? I have already set up my Mame2003 with primarily Parent and working ROMs only, if I run this new merged DAT I will have no idea of the specific new versions needed etc. And if you gather all the new only samples into a DAT we will know the exact versions needed from Twistys site.

Riverstorm

@maxbeanz said in lr-mame2003 driver improvement and backport:

Hi, could you also make a separate DAT with only the new/changed ROMs and samples (like @markwkidd said) ?

Yeah that shouldn't be a big issue. To do something like that it would require replacing them in your source directory.

It might take some time to work through the list being around the holidays and it's quite a bit larger than I originally had thought. I thought maybe a dozen or so games but the more updates the better! :)

markwkidd

Nice! Once the 'hacks' DAT is ready for use I would like to see it get added to the MAME 2003 github repository in the same metadata folder as the 'standard' MAME 2003 DAT I linked above.

Riverstorm

@gamez-fan said in lr-mame2003 driver improvement and backport:

Hyper Crash nemesis.c
Counter Run freekick.c

@gamez-fan - Which version or both work for Hyper Crash (C and D)? Also Counter Run has 3 but 2 show as not working.

Also this one:
Vasara 2 ssv.c (Set 1 and Set 2)

arcadez2003

@riverstorm said in lr-mame2003 driver improvement and backport:

@gamez-fan said in lr-mame2003 driver improvement and backport:

Hyper Crash nemesis.c
Counter Run freekick.c

@gamez-fan - Which version or both work for Hyper Crash (C and D)? Also Counter Run has 3 but 2 show as not working.

Also this one:
Vasara 2 ssv.c (Set 1 and Set 2)

All sets of Hyper Crash and Vasara 2 will be playable, as for Counter Run only this version works.............

GAME( 1988, countrnb, countrun, freekckb, countrun, 0, ROT0, "bootleg", "Counter Run (bootleg set 1)" )

Riverstorm

@riverstorm said in lr-mame2003 driver improvement and backport:

@gamez-fan said in lr-mame2003 driver improvement and backport:

Hyper Crash nemesis.c
Counter Run freekick.c

@gamez-fan - Which version or both work for Hyper Crash (C and D)? Also Counter Run has 3 but 2 show as not working.

Also this one:
Vasara 2 ssv.c (Set 1 and Set 2)

Thanks, that's how I added then thought I should verify. One more question quick question I am not seeing the neogeo.c source.

arcadez2003

@riverstorm said in lr-mame2003 driver improvement and backport:

Thanks, that's how I added then thought I should verify. One more question quick question I am not seeing the neogeo.c source.

look inside drivers folder.

Riverstorm

@gamez-fan said in lr-mame2003 driver improvement and backport:

look inside drivers folder.

Ah, ok thanks! :)

darknior

Denjin Makai WIP https://github.com/libretro/mame2003-libretro/pull/230 ... 238
Detail : https://github.com/libretro/mame2003-libretro/pull/230

@gamez-fan Denjin Makai needs a couple of changes here so the sound will work this will also benefit SD Gundam Psycho, Salamander no Kyoui no other Seibu games will be affected
The game wont pan the sound via the two speakers by default for some reason so let's make it so