mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support

Brigane

WeirdH

arcadez2003

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@arcadez2003 Good to know it wasn't just me. I got the game running on mame2010, but that one always has messy keyboard controls. It won't give me functioning buttons on my cab for player 2 coin and start, and even if I use a keyboard, the player 2 screen is always up side down, with no way to flip it. Oh well, it's running at least.

Your talking about Space Launcher i assume.?? i've added the n8080.c driver but not yet submitted it to MAME2003+ core as i've ran into a issue with one game namely
Heli Fire it's locking up on boot, but all the other games look lovely now they're all in colour with their special graphical effects and the sound is good now also.............

Bandito / Sheriff

Space Fever

Space Fever High Splitter

Space Launcher

WeirdH

@arcadez2003 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@arcadez2003 Good to know it wasn't just me. I got the game running on mame2010, but that one always has messy keyboard controls. It won't give me functioning buttons on my cab for player 2 coin and start, and even if I use a keyboard, the player 2 screen is always up side down, with no way to flip it. Oh well, it's running at least.

Your talking about Space Launcher i assume.?? i've added the n8080.c driver but not yet submitted it to MAME2003+ core as i've ran into a issue with one game namely
Heli Fire it's locking up on boot, but all the other games look lovely now they're all in colour with their special graphical effects and the sound is good now also.............

Yes, I was. Awesome that you got it to work! Shame about Heli Fire though. I really have no idea what goes on in coding an emulator, so I consider you a miracle worker either way.

That 'Sheriff' screenshot gives me WarioWare flashbacks, even though it was presented in white there as well!

UDb23

@arcadez2003 Great you added Sheriff, thanks! Was only playable in mame2010.
For all those that may be interested an overlay and info on how to setup controls can be found here.

arcadez2003

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@arcadez2003 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@arcadez2003 Good to know it wasn't just me. I got the game running on mame2010, but that one always has messy keyboard controls. It won't give me functioning buttons on my cab for player 2 coin and start, and even if I use a keyboard, the player 2 screen is always up side down, with no way to flip it. Oh well, it's running at least.

Your talking about Space Launcher i assume.?? i've added the n8080.c driver but not yet submitted it to MAME2003+ core as i've ran into a issue with one game namely
Heli Fire it's locking up on boot, but all the other games look lovely now they're all in colour with their special graphical effects and the sound is good now also.............

Yes, I was. Awesome that you got it to work! Shame about Heli Fire though. I really have no idea what goes on in coding an emulator, so I consider you a miracle worker either way.

That 'Sheriff' screenshot gives me WarioWare flashbacks, even though it was presented in white there as well!

Heli Fire may work in this core i've had similar issues previously with games not working in my MAME72 test core but they're fine in this one Virtua Fighter for example.
anyway i have now pushed my n8080 backport improvements to MAME2003+ the roms needed to change but for ease of use i've updated em to latest MAME more or
less.

Please give Heli Fire a whirl and lemmie know if it plays or not

arcadez2003

@UDb23 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@arcadez2003 Great you added Sheriff, thanks! Was only playable in mame2010.
For all those that may be interested an overlay and info on how to setup controls can be found here.

Hmmm i seen some faked overlay code in the video file for Bandito / Sheriff which was removed as part of the update, although the game is all in colour as i added support
for the missing gfx prom via a later MAME build.

grant2258

I wonder if this could be causing the issue in the older cores never seen it set to null before.

https://github.com/mamedev/historic-mame/blob/dd2571a8c38e799cb50fb30f928fac293566e30c/src/drivers/n8080.c#L211

might be unrelated its complying about using memory after its been freed.

edit
strange does not happen when i put retroarch logging on(1.7.8) would need more looking into

UDb23

@arcadez2003 That overlay is a retroarch one, so it should not be related to any issue of the game code/driver.

arcadez2003

@grant2258 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

I wonder if this could be causing the issue in the older cores never seen it set to null before.

https://github.com/mamedev/historic-mame/blob/dd2571a8c38e799cb50fb30f928fac293566e30c/src/drivers/n8080.c#L211

might be unrelated its complying about using memory after its been freed.

edit
strange does not happen when i put retroarch logging on(1.7.8) would need more looking into

@grant2258 Thanks for taking a look, it seems that palette_init_n8080(NULL, NULL); is just telling the game not to use the n8080 palette by looks it serves no other purpose
removing it makes no difference but it was worth a try at anyrate.

grant2258

i had some time to look through some code and managed to start the game 10 times without crashing could can you try this on your test build and let me know how you get on mate. https://github.com/grant2258/mame2003-plus-barcade/commit/bfc7bfb3d1212b5110c5e05dfd77ac0a22e60ea3. PS ive only tested this on 64 bit could be a 64 bit issue will get the pi out when im off work will let you know if it works on that.

arcadez2003

@grant2258 said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

i had some time to look through some code and managed to start the game 10 times without crashing could can you try this on your test build and let me know how you get on mate. https://github.com/grant2258/mame2003-plus-barcade/commit/bfc7bfb3d1212b5110c5e05dfd77ac0a22e60ea3. PS ive only tested this on 64 bit could be a 64 bit issue will get the pi out when im off work will let you know if it works on that

Nah no joy, but it's as you suspected a problem with the palette rather than the CPU's where my attention was focused, you'd think the compiler would have spat out
a warning or two about this or the game would have booted with messed up gfx rather than stalling on boot which made me think it was a CPU communication problem.

Anyway good job hopefully it'll work with your changes on the platforms that use this core.

EDIT
i checked out the core gfx in MAME72 vs 84 where Heli Fire actually works and apart from the palette handling it's on a par more or less in both builds, anyway outta
curiosity i updated the palette code to MAME84 and whatya know the game still wont boot, i think there's more going on here than just the palette code in the driver
causing issues in MAME78 if you can sort this you'll deserve a medal :)

grant2258

It was very tempremental worked sometimes and not others. Just mark it not working for now seems like a good idea until its fixed. If I manage to find anything ill post and let you know dont want to fill up the posts here with it. It might naw be the palette just was the first thing i noticed time will tell.

darknior

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@darknior Link

Many thanks, i have take it i will try to make me a good rom pack :)

And thanks too @arcadez2003 to update it too ;)
https://github.com/libretro/mame2003-plus-libretro/blob/fbdc5f482355a7e2eb7b6c7f01d7d1bdf7d9b61a/metadata/mame2003-plus.xml

WeirdH

@grant2258 Is it possible that palette changes also affected colors in other games?

Because I might be imagining things, but since the update some effects in Storm Blade have been multi colored where they didn't use to be (shockwave before enemies explode and apparently some shadows). At least to the best of my recollection. Again, I might be remembering wrong, was just wondering about it, because I noticed it yesterday.

arcadez2003

And thanks too @arcadez2003 to update it too ;)
https://github.com/libretro/mame2003-plus-libretro/blob/fbdc5f482355a7e2eb7b6c7f01d7d1bdf7d9b61a/metadata/mame2003-plus.xml

@grant2258 did all the graft i just copied and ported across his xml :)

arcadez2003

@WeirdH said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

@grant2258 Is it possible that palette changes also affected colors in other games?

Because I might be imagining things, but since the update some effects in Storm Blade have been multi colored where they didn't use to be (shockwave before enemies explode and apparently some shadows). At least to the best of my recollection. Again, I might be remembering wrong, was just wondering about it, because I noticed it yesterday.

A year or so back we ported some video changes from later MAME for Storm Blade and Ultra X Weapons to fix the colours and graphical problems............

https://github.com/libretro/mame2003-plus-libretro/commit/dcab429899470b1d893a0b3f660fbc7f4211eda8#diff-e19b55627b841d35ec504da4089655c4

akafox

I am correct that not all games have been optimized or for this core..yet every game that runs on the mame 2003 core should work on the mame plus core?

I ask because I was running LibreELEC (kodi) on my pi 3 and using retroplayer within kodi and Advanced Emulator Launcher..I loaded DK (dkong.zip) and it ran poorly with the plus core..but just fine with the standard core.

(yes I mentioned that on the kodi forums already. Just the gaming community is much larger here.)
(I will admit I have not had much use of the plus core...yet...)

Riverstorm

@akafox - Their are actually around a dozen "B" games that only exist in mame2003 but for the most part the ROM sets are identical (minus the m3plus exclusives) and should all work fine in either core. I mainly use m3plus and as far as I know dkong was running fine as of the last commit at around 60 FPS. Both cores use the same ROM set and I believe the same driver code. I've never tried Kodi so I don't know if that could be part of the issue.

arcadez2003

@akafox said in mame2003-plus: hundreds of new games, improved input, features, new bugs - now with runahead support:

I am correct that not all games have been optimized or for this core..yet every game that runs on the mame 2003 core should work on the mame plus core?

I ask because I was running LibreELEC (kodi) on my pi 3 and using retroplayer within kodi and Advanced Emulator Launcher..I loaded DK (dkong.zip) and it ran poorly with the plus core..but just fine with the standard core.

(yes I mentioned that on the kodi forums already. Just the gaming community is much larger here.)
(I will admit I have not had much use of the plus core...yet...)

The only difference with Donkey Kong in this core over MAME2003 is that it uses newer and improved samples, and @grant2258 made a small fix for the gfx decoding
that's it more or less and i seriously doubt that would cause a drop in the performance dept.