Joy2key causing controller issues

cyperghost

@bizzar721 Thejoy2key.py file should be just a small text file and it wasn't updated the last 5 months. You can see it here on Github

Annother question? What is runcommandjoy2key.pyc? And why it looks so strange encoded in your screenshot? Did you compiled it?

I also wanted to add in that when I renamed runcommandjoy2key.pyc to [OLD]runcommandjoy2key.pyc, but did not replace the file, joy2key was still working in runcommand, still staying open as well.

That's feasible because you seem to edit the wrong file. The script filename is joy2key.py it's located in same directory as runcommand.sh

BiZzAr721

@cyperghost

That's weird. This file was there on a clean build from the official RetroPie image. I assumed it was needed to run joy2key.py. It is located in the same folder as joy2key.py & runcommand.sh. That's why I thought it was so odd for it running without that file.

Joy2key.py matches the official joy2key.py. The last post is the only time I really looked into or mentioned joy2key.pyc. I was using WinMerge to compare the 2 files. Here is joy2key.pyc from the fresh install.

Inside of retropie-4.4-rpi2_rpi3.img

cyperghost

@bizzar721 Okay, I see
I think it's better to tag @BuZz maybe he can solve the question

Why is in the Image a compiled joy2key python script? Is this needed since RetroPie 4.4?
If I compare the github then the runcommand and the joy2key python-script were not updated since month.
It seems that @BiZzAr721 gots issues with a not terminated joy2key instance during emulator call.
This ends in a terminated OpenBOR session, because left DPAD seems to work as ESCAPE key which is so far an issue only with this emulator but it ocours also with others.
If you have any idea, than thanks for your feedback.

BiZzAr721

I spent a little time this evening trying to get this sorted out. I loaded up the "debug" image where I copied over only the contents of the folders available in samba (config, roms, bios). I went to enter a command in terminal and realized my keyboard wasn't set up for English US when I went to enter ~ command. I entered config and changed the keyboard type to Generic 101 key PC and AltGr as `default for this keyboard layout' .

I have not been able to replicate the joy2key bug yet.

Over on my complete image, I already had keyboard set, but I went ahead and reset the keyboard to the exact same options as mentioned above. This did not fix the problem.

Is there a way/is it safe to update retropie from source? I'm wondering if getting keyboard settings back to square one will help any. Maybe there are files I can try manually replacing?

I will try to recreate the bug in the "debug" image again....and again...and again...... and hopefully I will not see it reappear. Then I can slowly reintroduce system files. Any recommendations for which files should be introduced first?

BiZzAr721

Another update....
I've been using RetroPie for a couple of weeks now without the issue reappearing. I got it happening again. Installing Pixel Desktop to ports and some metadata edits through ES menu are the only things I can think that I have done besides playing games . Like usual, hard reboots didn't clear it. I created a new backup the bugged image. I then restored that very image and so far it hasn't happened yet. I can't imagine it is gone but I haven't had it return yet.
Technically I would assume the very first boot would have the same issue since that is the state I backed it up in.

BiZzAr721

I restored a backup that wasn't noticeably having the joy2key issue, and upon first boot, first try I was had the issue. I reinstalled ES from source but no change. Is there a possibility this specific SD card is causing the issue? I don't see how, but literally all I did was backup and restore to this SD.

cyperghost

@bizzar721 I believe it has something to do with your controller config. I suggest to manually check if instance of joy2key is running, or to use my delay kill script.

I sadly can not reproduce any of your issues maybe other users can

BiZzAr721

@cyperghost My controller config only consists of the 1 SNES clone (This build I never added any additional controllers EXCEPT the logitech wireless dongle for my keyboard/touchpad combo)

I turned of joypad support for runcommand and I have no issues since joy2key never starts. I still have joy2key support with your OpenBOR game selector AND it kills joy2key properly.

The Joy2Key on_start scripts you wrote up never worked (which must have something to do why runcommand will not kill it) Somehow joy2key has infinite lives!

EDIT
Pressing buttons on loading screen I received a message on bottom left of screen
readonly mode, sorry [start with --edit?]

Edit 2

Resetting ownership/permissions of /home/pi/RetroPie/roms
That seems to be tied to that specific error

Edit 3
Restoring permissions did not help. I have been checking manually. I have done ps -a countless times. It's normal practice for me to run ps -a when ANY game is loaded lol

cyperghost

@bizzar721 I know that these SNES controllers behave a bit unusual. I used your controller config for openbor and it worked also with mine so I assume that mine got the same chip set.

So what is unusual of these? The DPAD is mapped as analog input - that is really the last thing I can think your issues are affected from this. Does this happen with a keyboard connected only?
Why do you think your file permission is wrong?

BiZzAr721

@cyperghost It happens no matter what is plugged in. This last time I reset controllers, then when I got the controller screen I setup a keyboard as controller and still have the issue. Even without keyboard plugged have the issue. I can tell when the issue is back because SNES will have a delay before the loading screen.

The reason I reset permissions was that searching for the error shown on loading screen let to a post where resetting permissions cleared the error.

BiZzAr721

While I was messing with the latest & greatest OpenBOR, while hitting keys on the controller I could get the console under the game to show (flash) so I recorded it, so I could replay it and pause when it flashed on screen. I don't know if this is anything substantial. Below is what is shown.

0_1537718414282_VideoCapture_20180923-112812.jpg

Traceback (most recent call last):
     File "/opt/retropie/supplementary/runcommand/joy2key.py", line 227, in <module>
          chars = get_hex_chars(arg)
     File "/opt/retropie/supplementary/runcommand/joy2key.py", line 139, in get_hex_chars
          return key_str[2:].decode('hex')
     File "/usr/lib/python2.7/encodings/_init_.py", line 100, in search_function
          level=0)
     File "/usr/lib/python2.7/encodings/hex_codec.py", line 52, in <module>
          class IncrementalEncoder(codecs.IncrementalEncoder):
     File "/opt/retropie/supplementary/runcommand/joy2key.py", line 134, in signal_handler
           close_fds(js_fds)
MameError: global name 'js_fds' is not defined

fds may be Famicon Disk System which I have installed. MameError - I am certain I did not open/play any mame games between boot and this error. This error may be totally unrelated but it is too much of a coincidence to not post.

I am curious how many people have this joy2key issue but are unaware since most games play just fine with it present. It seems OpenBOR is the only program to show ill effect from it.

cyperghost

@BiZzAr721 there is a progress in resolving this issue. It would be nice to give report if the patch is ready and merged (PR#2654)
@psyke83 is working on your issues related to joy2key (=kryptonite agony)

BiZzAr721

@psyke83 This is great news! I have been restoring backups, and switching sd cards to get rid of it. At this moment I haven't noticed having the issue, but I will look to see if I have my abandoned sd card with the issue. When I recreate the issue, how do I use your remedy?

@cyperghost Thanks for thinking of me. I'd sure like some piece of mind on this issue haha

BuZz

@BiZzAr721 the fix is now merged into retropie. Just update retropie-setup (can do just a script update in this case) and you should get the fix.

BiZzAr721

Awesome news! Thank you!