moonlight: request for comments and testing

WarC0zes

pi@retropie:~ $ ls -la /opt/retropie/configs/all/moonlight
total 32
drwxr-xr-x 2 pi pi 4096 févr. 24 06:21 .
drwxr-xr-x 5 pi pi 4096 févr. 24 04:50 ..
-rw-r--r-- 1 pi pi 2430 févr. 20 16:57 client.p12
-rw-r--r-- 1 pi pi 1082 févr. 20 16:57 client.pem
-rw-r--r-- 1 pi pi  107 févr. 24 06:21 global.conf
-rw-r--r-- 1 pi pi 1704 févr. 20 16:57 key.pem
-rw-r--r-- 1 pi pi   35 févr. 20 16:56 scriptmodule.cfg
-rw-r--r-- 1 pi pi   16 févr. 20 16:57 uniqueid.dat

hhromic

@WarC0zes umm.

Can you try executing it from the console intead of EmulationStation typing this directly:

/opt/retropie/supplementary/moonlight/moonlight.sh stream -config "/home/pi/RetroPie/roms/steam/Steam.ml"

WarC0zes

@hhromic

pi@retropie:~ $ /opt/retropie/supplementary/moonlight/moonlight.sh stream -config "/home/pi/RetroPie/roms/steam/Steam.ml"
Can't open configuration file: /opt/retropie/configs/all/moonlight/global.conf

hhromic

@WarC0zes very puzzling... let's try something more simple:

/opt/retropie/supplementary/moonlight/moonlight.sh stream -config /opt/retropie/configs/all/moonlight/global.conf

Can you also try typing it manually instead of copy/pasting, just in case?

WarC0zes

@hhromic

/opt/retropie/supplementary/moonlight/moonlight.sh stream -config /opt/retropie/configs/all/moonlight/global.conf

it works like that ^^

hhromic

@WarC0zes a-ha ! so we have a clue now.
Did you manually create the Steam.ml file in your $romdir/steam folder?
And if you did, you used your local computer and uploaded it there?

WarC0zes

@hhromic
Yes, i have manually create the Steam.ml file in my $romdir/steam folder.

hhromic

@WarC0zes ok as I thought :)

The problem are the line endings of the file you created. You must make sure your editor saves the file using unix line endings (\n) and not Windows nor Mac. Some editors such as notepad++ allow you to configure this.

An easy alternative is to create the files using nano in the same RetroPie console to ensure they have the proper unix line endings. You can also use the remote apps config file autogenerator included in the scriptmodule.

Let me know if that solved your issue.

WarC0zes

@hhromic
it was a space problem, you're right. Thanks

hhromic

@WarC0zes thanks for the feedback. I will be submitting this scriptmodule soon to official RetroPie :)

llamadestroyer

Here with a feedback. If you have a xbox one v1708 wireless controller and cant mapping it just remove xpad driver from retropie setup/manage packages/driver. Then install xpadneo driver from https://github.com/atar-axis/xpadneo/. Now u can remap your controller using
sudo ./retropie_packages.sh moonlight exec map -input /dev/input/event2
command. Also this will solves same problem in kodi for me. I can use my controller correcctly now.

hhromic

@llamadestroyer thanks for the feedback!

The xpadneo driver doesn't seem to be part of RetroPie at the moment. It is the only way to use an XBox One controler on the Raspberry Pi?

llamadestroyer

@hhromic for the model 1708 (latest party includes bluetooth by default) first of all must disable ertm via editing autostart.sh. after that pairing succes but can't use properly. I noticed this on the kodi. may u know kodi uses xbox input by dafault. when i try the use my gamepad any button doesnt make any thing. after playin witcher 3 via moonlight i had some error again. after i tried to remap it via your guide and when it says for example press x i pressed x but noting happened. it came to me like a typical driver problem, searched for xpad and i saw xpadneo... you know after that it worked perfectly even in kodi.

MightyHandy

Looks like it went live! Congrats @hhromic! This is awesome.
https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/supplementary/moonlight.sh

muldjord

Tried this yesterday and it worked pretty well - great work! I had a bit of trouble with the config generation and I had to re-pair once for the streaming to start working (no idea why, it just didn't work the first time around even though it paired just fine with the pin).

Concerning the script generation, It worked well the first time I initiated it. But when I tried to regenerate them, it just froze and I had to ctrl+c it to get back to the menu. I then had to reboot the system, then remove the pairing and redo the pairing in order to be able to regenerate them again it seemed. Or maybe it just needed to be rebooted (I did both since I couldn't get it to start anything, just got a blank screen). I had trouble getting things to start on my Steam computer. It wasn't until I paired it for the second time it would launch Steam for me when I chose the Steam ml script.

Another note: Skyscraper now supports the steam platform and the *.ml for all platforms in case people want to scrape these scripts. It's in Skyscraper 3.1.2.

Silent

Hey,

it's been a while but the DualShock 3 issue I reported a long while ago was now solved in SDL2 itself:
https://github.com/gabomdq/SDL_GameControllerDB/issues/247#issuecomment-473724813

So do you think using this database as a source of gamecontrollerdb.txt instead of having one included in the scriptmodule can work? Last time you said it's an OK idea.

MightyHandy

@Silent to do that wouldn’t you have to modify moonlight-embedded?
https://github.com/irtimmer/moonlight-embedded/blob/master/gamecontrollerdb.txt

Silent

Not sure how legit it is, but yesterday this message showed up on Moonlight Discord in #embed-dev:

EDIT:
Seems to be legitimate, since repository is now archived.

hhromic

Hey all ! sorry for the long delay replying in this topic. I've been a bit busy nowadays :(

@MightyHandy thanks for the congrats on going live! Hope we can keep improving the scriptmodule with your feedback.

@muldjord thanks for testing the scriptmodule!
When regenerating the game files you should not need to reboot the device in any case. However, it depends on Moonlight connecting to your remote computer to get the list of available games. So what you were experiencing might be some connectivity issue or perhaps an NVIDIA GeForce Experience issue in your host. GFE is notorious for breaking things between updates :/
Thanks for adding support for the .mlfiles in Skyscraper! Appreciated.

@Silent great to hear you persevered until you got the controller mapping merged upstream!
I do think that sourcing a fresh copy of gamecontrollerdb.txt is a good idea. I even think it would be more beneficial if it could be handled by RetroPie (for example as a supplementary module) for this and other scriptmodules using SDL game controller databases to have a common file. However this would be needed to be discussed with @BuZz.

Regarding the recent news, I also just read in Discord that irtimmer abandoned the moonlight embedded repository and seems to be for real :/. Sad news indeed as this project is very practical in my opinion. I like that moonlight embedded is pretty small and lightweight, no Xorg stuff required.

I think this could be a good opportunity for the main/larger moonlight-stream project to adopt it and support it more officially. Let's see what happens.

hhromic

Update

So, irtimmer reconsidered and restored the moonlight repository now. He won't be doing major changes himself and instead he encourages others to contribute fixes and enhancements. This is good news for moonlight embedded as the project (for the moment) won't be strictly dead.

Recently, a github user fixed the initial rumble implementation and should be working now! I haven't tested it myself yet, but if you give it a try and report, that would be nice. Rumble works automatically, just launch a game that supports rumble and you should get your controller vibrating via moonlight.