Grid Updates - emulationstation-dev

paffley

Any fixes for these as yet please @jdrassa ?

ruckage

Hey @jdrassa , hope you're well.

I've been trying your latest windows build of ES but there seems to be an issue with Grid view where the grid images are squashed after selecting a tile. It looks like they may be being squashed in a way that matches the aspect ratio of the ES window if that helps but I can't be positive. I'm not sure if this is just a windows issue or if its affecting rpi as well.

Here's a video to illustrate the problem:

quicksilver

@ruckage Ive noticed something similar when using "video" as gameslist view. The scraped image will be squashed after running a title after returning to ES or if you press select on the title like you are going to edit the metadata. This is on a raspberry pi btw. I tested on several themes including carbon.

ruckage

@quicksilver
@jdrassa

I've narrowed down the issue now. The bug first appeared in an update on 30 December when marquee, image and video were added to grid view.

What's more it seems to be specifically caused by md_image.

My understanding is that the update added the ability to display md_Image, md_video and md_marquee in the gridview as you can in other views as separate elements.

This works for md_marquee and md_video and behaves as expected.
For example adding the following into the grid View section of a theme will draw the marquee in the top left corner:

<image name="md_marquee">
	<size>0 0.2</size>
	<pos>0 0</pos>
	<origin>0 0</origin>
</image>

However if you try the same with md_image nothing extra is drawn. Instead it affects the way the images are drawn in the grid, this I am sure is a bug and I'm fairly certain will be causing issues in the Rpi version as well (I can't check at the moment as I don't have a spare SD card handy).

It's the size tags specifically which are affecting the grid images. Here are some examples:

<image name="md_image">
	<size>0.2 0.2</size>
</image>

bug 1.jpg

<image name="md_image">
	<size>0.5 0.2</size>
</image>

bug 2.jpg

And this is without adding md_image to the theme so the system uses default values which results in the images being stretched to a square shape.

bug 3.jpg

Currently it can almost be fixed by setting one or both size values to 0, e.g <size>0 0</size> . However the first image in the grid still gets distorted and obviously the md_image still can't be displayed as a separate element.

bug 4.jpg

I hope this helps pinpoint the problem @jdrassa and I hope you're okay as I see you haven't posted for a while (admittedly nor had I) .

jdrassa

@ruckage Sorry for the delayed response. I haven't had much time to dedicate to RetroPie stuff lately. I think you pretty much found the cause. I believe what is happening is that when ES caches the image texture it does so at the size it expects to renderer it. Since md_image is being displayed in 2 different places at 2 different sizes, one size takes precendence over the other, since only one copy of the texture is kept in memory.

I will need to run some more tests, but I just ran a quick test and I was able to get md_image to be drawn as expected. Any way you could share a copy of your theme with me? Or at least just the grid config portion.

ruckage

Hi @jdrassa,

It's good to hear from you, glad you're okay. Thanks for looking into this, you've put a lot of work into ES already and I appreciate you only have a limited amount of spare time - and sometimes you just need a break .

I've just managed to get md_image to show. It was being drawn behind the background image so it was just a case of setting the zIndex - I just didn't think of trying that earlier.
If you still need the theme to check I can find somewhere to upload it.

So it's almost behaving correctly now (providing md_image is set up) other than the first tile in the grid being distorted regardless of how md_image is set and in my case md_image not showing when first entering a system. I'm guessing for the first tile the default md_image settings are being applied before the md_image tags are read from the xml.

ruckage

@jdrassa
Bugs aside, I'm really pleased with the new grid view additions and extra options. The auto grid layout is very helpful and having the option to loop and centre the grid as well as animate it are all very welcome. And being able to finish it all off with video previews etc. is great :) . All combined it offers some great new theming possibilities.

mega mini theme new.jpg

lilbud

@ruckage Wait, when did all this stuff get added? Video previews and looping single row grid

Guess I can finally make a full and complete switch theme

HurricaneFan

Are all of these grid features in the default version of emulationstation provided by the RetroPie image file? Or is this only available in special windows build?

Second question, do we have to resize all our box art images to make them work with grid view?

jdrassa

@ruckage said in Grid Updates - emulationstation-dev:

So it's almost behaving correctly now (providing md_image is set up) other than the first tile in the grid being distorted regardless of how md_image is set and in my case md_image not showing when first entering a system. I'm guessing for the first tile the default md_image settings are being applied before the md_image tags are read from the xml.

I haven't been able to reproduce the distortion of the first tile, but I think I did reproduce md_image not showing when first entering a system. In my case, it actually does show for a split second and then disapears (along with the rest of the metadata). I need to dig some more, but hopefully should be able to come up with a fix.

If you still need the theme to check I can find somewhere to upload it.

No need to upload, if you could just provide the grid config, that should be enough.

<imagegrid name="gamegrid">...</imagegrid>
<gridtile name="default">...</gridtile>
<gridtile name="selected">...</gridtile>

@HurricaneFan said in Grid Updates - emulationstation-dev:

Are all of these grid features in the default version of emulationstation provided by the RetroPie image file?

All the features @ruckage is using are available in RetroPie, but I am not sure if they are all available in the latest image. To get the latest version of ES, you can install the emulationstation-dev module in RetroPie-Setup.

mitu

@jdrassa said in Grid Updates - emulationstation-dev:

All the features @ruckage is using are available in RetroPie, but I am not sure if they are all available in the latest image. To get the latest version of ES, you can install the emulationstation-dev module in RetroPie-Setup.

They should be available in RetroPie also, updating the normal EmulationStation package would get the lastest from the stable branch, which is more or less on-par with the dev branch right now. The grid view addition was part of the last year's version bump (Feb 2019), so it should be available in the 4.5.1 image.

jdrassa

@mitu There have been additional updates to grid view since Feb 2019. I believe most of it is in stable, but the ability to use marquees and video with grid view was just added last month and I don't think has made it to stable yet.

paffley

Everything works on stable apart from md_marquee and md_video in grid view. @jdrassa I posted some bugs in my previous post on these latest es-dev updates.

ruckage

@paffley said in Grid Updates - emulationstation-dev:

Hey @jdrassa thanks for merging the new grid updates :)

Found a couple of bugs in the latest version of es-dev

1 - When you go back to the gamelist view 'after exiting a game' md_video does not play, even when you scroll. If you go back to the system view then back to gamelist view the snaps re-appear.**

2 - When entering a system, the md_name, md_image, md_video etc vanishes then re-appears after the first scroll.

Now I'm not sure if this is a bug or not but with the latest es-dev update there is a frame rate counter in the top right hand side of the screen when you start a game? I'm not sure how to get rid of this as its not from es menu settings nor can I locate it in retroarch?

Hope this all helps :)

Hi @paffley. I've just installed the latest ES dev build on rpi to check and can confirm I'm also seeing these exact issues. Plus I've also noticed a bug when using omx player specifically. Sorry @jdrassa , looks like it's a few more bugs to add to list I'm afraid.

Just to confirm:

No video plays once exciting a game unless you return to the system select first. I've confirmed on both windows and Rpi.
No metadata at all is displayed for the first tile/game when first entering a system (including text,images, video) .
On Rpi if you have OMX player switched on the video fills the entire screen rather than being displayed at the size specified in the theme.xml unless both axis are defined.
eg. <size>0 0.2</size> fails and just fills the whole screen but <size>0.2 0.2</size> works correctly

@jdrassa As requested below is the contents of the grid setup I'm using - I think there are probably a lot of redundant things included as I've started using autolayout and have been experimenting quite a bit so it could do with cleaning up.

                <imagegrid name="gamegrid">
			<pos>-0.05 0.565</pos>
			<size>1.1 0.276</size>
			<autoLayout>9 1</autoLayout>
			<autoLayoutSelectedZoom>1</autoLayoutSelectedZoom>
			<margin>0.00625 0.006</margin>
			<centerSelection>true</centerSelection>
			<scrollLoop>true</scrollLoop>
			<animate>false</animate>
			<scrollDirection>horizontal</scrollDirection>
			<folderImage>./art/${style}/folder.png</folderImage>
			<imageSource>thumbnail</imageSource>
		</imagegrid>

		<gridtile name="default">
			<size>0.134 0.322</size>
			<padding>18 18</padding>
			<backgroundImage>./art/${style}/tile.png</backgroundImage>
			<backgroundCornerSize>64 64</backgroundCornerSize>
			<backgroundColor>ffffff</backgroundColor>
			<imageColor>ffffff</imageColor>
		</gridtile>

		<gridtile name="selected">
			<size>0.134 0.322</size>
			<backgroundImage>./art/${style}/tile-selected.png</backgroundImage>
			<backgroundColor>ffffff</backgroundColor>
		</gridtile>

paffley

Hey @ruckage mate, hope ya well dude. Yeh I agree on the oxm player. I only use Rpi for my builds. The new features are cool aint they! used correct you can get some cool layouts. I use one on my nes/snes mini build where the 'selected' bgimage goes left and right, not quiet as far left and right as the original nes/snes mini but pretty close, I reckon with a few more tweaks I may be able to replicate it fully. Im still having a few issues with sizing the imagegrid tho with the bgimages, sometimes they look perfect but when you scroll up or down it kind of goes 'off' a little with the boxart, only minor but my ocd kicks in haha so im gonna have to investigate that further as the imagegrid seems to have little issues with specific sizing to the points (0.252 etc).

If these little minor issues can be cleaned up I believe the only thing needed for the grid view is an option of scrollSound, possibly adding on to the md_name tag I would assume.

Its all cracking tho and @jdrassa has done some awesome work on it over the months/weeks. salute to him!

I'm a big fan of hyperspin, so im just converting a theme at the moment with the new features and its spot on! works great!

Love your above layout by the way, very slick! Good work!

jdrassa

@paffley @ruckage I have a PR in to fix 1 and 2 from the list above.
As for 3, after looking over the code, I suspect this has probably always been a bug with OMX player. The OMX player component doesn't have the same size calculation logic that image and VLC do.

paffley

@jdrassa said in Grid Updates - emulationstation-dev:

@paffley @ruckage I have a PR in to fix 1 and 2 from the list above.
As for 3, after looking over the code, I suspect this has probably always been a bug with OMX player. The OMX player component doesn't have the same size calculation logic that image and VLC do.

Thanks @jdrassa Yes I agree on number 3, I have found numerous issues with omx.

FYI, number 2 is an issue in the stable branch also, just thought id let you know.

paffley

@ruckage any chance you could upload the font you are using for the md_name please? its for my personal build. I have the regular OCR font but cannot find the outlined one.

ruckage

@jdrassa said in Grid Updates - emulationstation-dev:

@paffley @ruckage I have a PR in to fix 1 and 2 from the list above.
As for 3, after looking over the code, I suspect this has probably always been a bug with OMX player. The OMX player component doesn't have the same size calculation logic that image and VLC do.

That's great @jdrassa , I look forward to trying it - you're a real star :D .

Regarding OMX player you may be right, I normally tend to explicitly set both axis for video size or use <maxsize> so I just haven't noticed it before.

ruckage

@paffley said in Grid Updates - emulationstation-dev:

I have the regular OCR font but cannot find the outlined one.

That's because it didn't exist until I made ;)
Regarding sharing I'm not sure as it's an edited version of the original OCR font and as far as I'm aware it's not an open source font. For my own personal use it's obviously fine but I'd prefer to find an open source alternative to OCR if possible.