Grid Updates - emulationstation-dev

[jdrassa]

@ruckage for bug fix PRs like this, I usually give it a couple days just to make sure no one has any objections, before I will merge it myself.

[quicksilver]

@jdrassa Thanks for looking into this. Although I think the issue I brought up may be somewhat different to issue that @ruckage was having. The issue I noticed is when the gameslist view is set to "video" and "showSnapshotNoVideo" is set to true, the screenshots appear at the proper size except after you launch a game and return to emulation station the screenshot of the game you just launched is "squashed" for lack of a better word. So not exactly a grid view issue but still a problem. Is there any chance you could take a look into that as well? Or will your PR also address this? Sorry to be a bother, thanks again!

[ruckage]

@quicksilver said in Grid Updates - emulationstation-dev:

The issue I noticed is when the gameslist view is set to "video" and "showSnapshotNoVideo" is set to true, the screenshots appear at the proper size except after you launch a game and return to emulation station the screenshot of the game you just launched is "squashed" for lack of a better word...

What theme are you seeing this as an issue as I can't reproduce it myself (at least not on windows).

[quicksilver]

@ruckage Ive been using nostalgia but it also happens on carbon

[ruckage]

@quicksilver
Is it on the pi or windows that you're seeing the issue? If it's the pi are you using the OMX player to play videos? (there should be an otion to enable/disable OMX player).

[quicksilver]

@ruckage it's on my pi. I'm not using videos, just using video gameslist view to get the marquees to show up.

[ruckage]

@quicksilver
Just tried the Nostalgic theme and I see what you mean. I'm just going to check the theme.xml to if there are any problems.

[ruckage]

@quicksilver Yeah, looks like another bug, the theme.xml itself seems fine.

[quicksilver]

@ruckage thanks for confirming it. I also noticed that if I use skyscraper to resize any of my scraped images, the last game I played will not resize correctly and stays squashed. I have to run a different game and then regenerate my gameslist.xml again. I'm guessing its probably a related issue.

[ruckage]

@jdrassa
This is the problem that @quicksilver is talking about, It looks very similar to what's happening to the first game image in grid view but it could just be a coincidence:

Video View

The image displays correctly before launching the game:

But once you return back to ES it gets stretched:

Grid View

This is how the first game image is displayed when first going into a system:

But if you scroll through the games and then go back it's displayed correctly:

[HurricaneFan]

Looks like @jdrassa pushed the fixes from earlier. Thanks!

[ruckage]

@jdrassa
I've tested the latest update on windows and pi and the metadata is now being displayed at all times and no disappearing videos, thanks for getting that fixed :) .

[gugue]

Hi every one.
In dev ES retropie with Grid mode , video are enabled ?

[gugue]

This post is deleted!

[ruckage]

@gugue said in Grid Updates - emulationstation-dev:

Hi every one.
In dev ES retropie with Grid mode , video are enabled ?

Yes they are, you may have to install it from source though.

[paffley]

Hi @jdrassa do you think you could please update stable with the current fixes? especially the disappearing meta data. Thank you :)

[gugue]

@ruckage did the last update from @jdrassa fix your cover size after scroll in grid view.. I always have te same issue on raspberry.

[paffley]

Hi @jdrassa hope you are well and keeping safe!

Just a little update on some bugs I've found in the latest 'stable' build with gridview if you are not aware of them already.

1 - There seems to be a bug with 'image' sizes when scrolling through the game grid. This was not on the previous stable build.

It seems like its picking up a form of max-size for all sided of the image, I noticed that if I made my images square (nes boxart, with padding at either side of the image in photoshop) it displays correct. Please see screenshot below (the rectangle images are what they are supposed to be displayed like)…

It's kind of doing the opposite to what @ruckage was having issues with previously.

2 - some boxart on certain systems disappear when scrolling through the grid. I noticed this on my sfc system gamelist. Again this didn't happen in the previous stable release.

3 - md_video auto displays on <grid> and no way of removing it, even if you position it to 1 1 it still plays the audio, even when the md_video is not used in the <grid> section of the xml. also noticed this with md_image but that can be displayed to 1 1 to remove from the view, but again even when its not added to the <grid> section in the xml.

Hope this all helps, if you let me know I will test more if you find any solutions. :)

UPDATE: testing on pi 3b+

[jdrassa]

@paffley I'll take a look and see what I can do. For #3, there is now a visible theme element that can be used. This works better than rendering off screen and, in the case of video, should prevent the video from playing.

[paffley]

Thanks @jdrassa that would be great :)

Not sure if the element <visible>false</visible> has been added to stable yet but I just tried it and the video still shows. It doesn't throw any errors though.