Favorites for EmulationStation

pjft

@TMNTturtlguy Not necessarily here - I think here was more about how to best render the "star" icon for the favorites that @Zigurana was trying to implement in this "Favorites" change :)

Nonetheless, all your change requests sound reasonable. I believe there's a massive thread where like-minded theme creators are having those conversations. @Zigurana , @mattrixk - is this the latest thread where those requests and conversations are being added and discussed? Or is there a running Google doc?

Definitely echo these there, as I'm sure they'll benefit from the discussion and design conversations :)

Thanks!

herb_fargus

Personally I'm not keen on requiring specific fonts for rendering folder icons, but them again I don't know if I have a better solution than what's been proposed either. Also I don't use folders so my opinion doesn't count much at that rate!

Zigurana

Some inspiration :
The guys over at the Recalbox branch of ES have just committed a change that hardcodes a specific glyph to be used as a fav icon for each system.
These glyphs are pulled from the large web awesome font collection, which can cater to a large number of icon related use-cases.

DarkWolf

I think I'am missing something here (I kinda feel stupid right now):
So I tryed to install your es build but it doesn't seam to change anything...
I followed the steps to make the emulationstation file and installed it (over an existing emulationstation build). But I don't see a change at all...
The emulationstation version is now V2.1.4 RP which is correct I think.. Do I have to do something now?

pjft

@Zigurana ...a favicon? Do you mean a favorites icon per system?

I imagine that's good overall, but without seeing it in action, I struggle to grasp the full extent of that change for the users and for the theme makers :/ Is there a video or set of images I could reference to better understand what we're considering?

Anyway, to avoid scope creep, maybe we could break down the "implementing favorites with the old metadata icon in the theme data", for feature parity with ES Kids, and then maybe "customizing games list and theme with further icons for folders and favorites"?

Just a thought, as I don't want you to lose momentum here :)

Zigurana

@DarkWolf you sure you got the favorites dev branch, and not the master branch?
The version# should be "2.1.8rp".

DarkWolf

@Zigurana Oh, well, that's embarassing...
Not using github that much, so I thought https://github.com/zigurana/EmulationStation.git would be the correct link to clone it... Isn't it? Ok, no it isn't... wow...
I got it now, I think, thanks for answering

Zigurana

@pjft good point, scope creep is my arch-nemesis!
So, the current plan:

I'll revert the cosmetic changes i've made to the gamelist entries, and
re-introduce the themable favorites Icon which is toggled when the selected item is a favorite or not.

Sounds ok?

Zigurana

@DarkWolf no worries, thank you for testing this!

Syhles

@Zigurana
My personal opinion is that the favorites icon and folder icon should be handled like the help icons, there should be a default icon built in to EmulationStation for them, but you should be able to point to new images in the theme to replace them.

I'm not sure how feasible that is, but this way it wouldn't break any themes and we would also keep easy themeablilty.

DarkWolf

@Syhles That sounds like a good solution if you ask me

TMNTturtlguy

@Syhles agreed!

DarkWolf

@Zigurana SO now I cloned it with
git clone -b Favorites https://github.com/zigurana/EmulationStation.git
The problem is that the cmake -DCMAKE_CXX_COMPILER=g++-4.7 . fails with

/home/pi/EmulationStation/external/pugixml does not contain a CMakeLists.txt file.

Any thoughts on that one?

pjft

@DarkWolf a recent change meant that we need to initialize the submodules the first time around. Run:

git submodule update --init

DarkWolf

@pjft Wow, that was easy, thanks!
I have to learn more things about git obviously

pjft

@Zigurana I think that's a wise way to break things up. Especially as, at least the way I see it, some themes may opt to keep the icons in the per game metadata section like in your branch, either exclusively (I.e. not having it in the games list) or in conjunction with this change.

But either way, it can be tackled later. :)

Do let me know if/how I can help!

DarkWolf

@Zigurana Omg that is so awesome! I was waiting for something like this for quite some time now. It's way better than the kids mode!
Keep up that great work, works like a charm!

OT: The emulationstation developers are a bit overdramatic

make
This will take a very, very long time (multiple hours).

Literally took 15mins

pjft

@DarkWolf it might have been written at s time when only the Pi 1 was around. But either way, under promising and over delivering is better than the other way around:)

DarkWolf

One thing I noticed is that if I want to shutdown/restart the system it only closes emulationstation and leaves me with a console left

pjft

@DarkWolf that's normal when you're calling emulationstation from the terminal. :)