Gamepad buttons stop working in retropie-setup 4.2.12

MrPotato

Thanks all for chiming in. Home now -- will run the requested tests.

To answer a few things first off:

If looking at the USB ports, I am using the left-most ports, one on top and one on bottom. I typically use that upper left port as the primary.
The controllers are USB iBuffalo SNES controllers. On both controllers Pressing "start" during ROM launch does nothing. Pressing "a" on both controllers does nothing.
Here is my "USB-axis 8-button gamepad.cfg" file. Note that, in my brief troubleshooting, I did try to remap the controller while in EmulationStation, so not sure if that affects this.

input_device = "USB,2-axis 8-button gamepad  "
input_driver = "udev"
input_l_btn = "4"
input_load_state_btn = "4"
input_start_btn = "7"
input_exit_emulator_btn = "7"
input_up_axis = "-1"
input_a_btn = "0"
input_b_btn = "1"
input_reset_btn = "1"
input_down_axis = "+1"
input_r_btn = "5"
input_save_state_btn = "5"
input_right_axis = "+0"
input_state_slot_increase_axis = "+0"
input_x_btn = "2"
input_menu_toggle_btn = "2"
input_select_btn = "6"
input_y_btn = "3"
input_left_axis = "-0"
input_state_slot_decrease_axis = "-0"
input_enable_hotkey_btn = "6"

Will try the rollback next. Stay tuned.

MrPotato

My output. I haven't made any special changes, so not sure why it does this. Will try the reset thing next, then try this again.

pi@retropie:~ $ cd RetroPie-Setup
pi@retropie:~/RetroPie-Setup $ git revert 96e6efca4649d03e93f1ded04539034a9c8d2353

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <pi@retropie.(none)>) not allowed

pi@retropie:~/RetroPie-Setup $ sudo git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
error: Your local changes would be overwritten by revert.
hint: Commit your changes or stash them to proceed.
fatal: revert failed

MrPotato

When resetting:

pi@retropie:~/RetroPie-Setup $ git diff
pi@retropie:~/RetroPie-Setup $ sudo git diff
pi@retropie:~/RetroPie-Setup $ git reset
Unstaged changes after reset:
M       scriptmodules/helpers.sh
M       scriptmodules/supplementary/runcommand/joy2key.py
pi@retropie:~/RetroPie-Setup $ sudo git reset
Unstaged changes after reset:
M       scriptmodules/helpers.sh
M       scriptmodules/supplementary/runcommand/joy2key.py

rebooted, and then...

pi@retropie:~ $ git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
fatal: Not a git repository (or any of the parent directories): .git
pi@retropie:~ $ sudo git revert 96e6efca4649d03e93f1ded04539034a9c8d2353
fatal: Not a git repository (or any of the parent directories): .git

So, not sure where to go from here.

MrPotato

Tried to edit posts, but the "spam blocker" keeps disallowing me.
Helps if I'm in the RetroPie-Setup directory. :)
But still not getting as expected. Can't copy/paste the whole thing because of "Akismet":

error: Your local changes to the following files would be overwritten by merge:
        scriptmodules/helpers.sh
        scriptmodules/supplementary/runcommand/joy2key.py
Please, commit your changes or stash them before you can merge.
Aborting

Same with sudo.

So, I'm not entirely sure what's happened, but in testing now:

I can now use the controller in menus once again.
But I still can't press a key when launching a game to bring up the options.

After testing:

pi@retropie:~/RetroPie-Setup $ git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms

Rebooted.

Back to no function in menus.

So, I think you're on to something here.

psyke83

You made a few mistakes. Try this

cd RetroPie-Setup
sudo git reset --hard origin/master

This should reset everything back to normal.

To revert the faulty patch:

cd RetroPie-Setup
sudo git revert 96e6efca4649d03e93f1ded04539034a9c8d2353

(Yes, press ctrl+x to complete the revert)

Once you've reverted a commit, you will have trouble updating the script, so re-run the same "reset --hard ..." command once more to undo the revert.

It's not necessary to perform a reboot -- just make sure you're not already in the RetroPie-Setup script's menu in another terminal or via the ES interface. If you are, just quit and relaunch the script.

MrPotato

Bombed on the first part.

pi@retropie:~ $ cd RetroPie-Setup
pi@retropie:~/RetroPie-Setup $ sudo git reset --hard upstream/master
fatal: ambiguous argument 'upstream/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

psyke83

@mrpotato said in Gamepad buttons stop working in retropie-setup 4.2.12:

Bombed on the first part.

Damn, sorry. Refresh the post (was supposed to be origin/master just as I wrote in the earlier post).

MrPotato

:) I thought maybe so. :)

Ok. Bombed on second part. :) Guessing I need to "set my identity" with those commands? (Cannot paste full input string for the revert command.. "Akismet" blocks it)

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <string here>

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'root@retropie.(none)')

MrPotato

Ok.

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <long string here... removed because of filter>
[master b4bf393] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)

Testing. Reset same as when I did the "reset".

Works in menus.
Still doesn't work when launching ROMs.

psyke83

@mrpotato said in Gamepad buttons stop working in retropie-setup 4.2.12:

Ok.

pi@retropie:~/RetroPie-Setup $ sudo git reset --hard origin/master
HEAD is now at 8abaf6a usbromservice - remove -ue from bash script - fixes script stopping after copying roms
pi@retropie:~/RetroPie-Setup $ sudo git revert <long string here... removed because of filter>
[master b4bf393] Revert "joy2key: implement key verification & dpad support"
 2 files changed, 9 insertions(+), 13 deletions(-)

Testing. Reset same as when I did the "reset".

Works in menus.
Still doesn't work when launching ROMs.

So I think we can surmise that the button mappings don't work correctly because of my patch, but the runcommand issue is not related to my patch.

MrPotato

Well, edmaul69 did say he had to reinstall runcommand after the revert. No idea what is affecting that, but it worked fine prior to the setup script update. :\

MrPotato

Went back to "normal" with sudo git reset --hard origin/master.
Then went into setup and did an 'update from binary' on runcommand.
Then rebooted.
Ugh.. pressing a key when launching a game still isn't working. (though, it does work on 2nd controller. :P)
Seems I am not in a good place. :(

Darksavior

I can't run the git revert in either putty or real terminal. Putty says some crap about inputting my email with root and real terminal just flat out tells me revert failed.

MrPotato

@darksavior said in Gamepad buttons stop working in retropie-setup 4.2.12:

I can't run the git revert in either putty or real terminal. Putty says some crap about inputting my email with root and real terminal just flat out tells me revert failed.

Use the config commands to set your email/name and those get resolved. :)

obsidianspider

For what it's worth, I am having the same issue, I think.I'm on 4.2.12 on my SFC pi with a raphnet USB SNES controller adapter.

I was trying to install lr-snes9x tonight and while I can use the D pad in retropie-setup, I can't confirm anything or exit out of it. I tried plugging in my second controller, but no dice. The controllers work just fine in emulationstation and in games.

I also cannot get the runcommand menu to come up when a game is loading. I used to press A but no action buttons are triggering it.

Darksavior

@mrpotato I'll keep at it. so far it's not seeing the email address I put in. This is just ridiculous that I have to do this at all. Still getting revert failed.
Edit: actually, I give up since there's not much else to do. I'll wait for 4.2.13 or whatever officially fixes it.
Edit2: for whatever I was doing, seems the problem is fixed despite getting revert failed.

obsidianspider

Considering @Darksavior having a bit of success, I updated to the newest revision of 4.1.2, which as of right now is (bda4718) and the problem is still present.

MrPotato

I've unplugged one controller. With a single controller, I have most functionality. Obviously won't work long term since we use both regularly, but at least I can rock it solo for now.

psyke83

Can someone with the controller issue please test this modified script?

Enter the retropie-setup folder:

cd RetroPie-Setup

Undo any changes if you followed my prior steps to revert the commit:

git reset --hard origin/master

Fetch and apply the patch:

wget https://gist.githubusercontent.com/psyke83/9a0b31bcd8f43d16d081462363741f35/raw/4ce063642e9088c3faa541d965d439d50c951101/joy2key.patch
patch -p1 <joy2key.patch

If everything goes as expected, you should see:

patching file scriptmodules/supplementary/runcommand/joy2key.py

If there are no further messages/errors, then the patch was applied and is ready to test.

Slightly OT: guys & gals, try not to complain too much. The Pi itself is supposed to be a hobbyist board to encourage people to learn Linux & programming. That may not be your intended purpose, but keep an open mind. If you don't want to go near a terminal, leave it to someone else to test & and wait for the inevitable fix to be merged. The problem was my fault, but I don't have a second pad available so it's difficult for me to reproduce the issue.

Darksavior

@psyke83 I'm using a backup I made last month and with just updating the script to 4.2.12 to introduce the bug, I ran the patcher and did nothing.