Carousel Enhancements

paffley

@jdrassa will this be merged into the official repo?

lilbud

@jdrassa So, origin for the carousel will decide which logo stands out?

jdrassa

@paffley that is the plan.

@lilbud origin just affects positioning of the carousel.

herb_fargus

@ruckage I don't want to derail this thread and take away from the hard work our friend is doing but to put it simply hyperspin reeks of everything I hate about the emulation community: greed, wanting full sets of everything complete with all videos, packaging it all up for a profit and a bunch of yokels on YouTube bastardising all our hard work by perpetuating these builds all the while slowly killing the project they are profiting off of.

twd

@herb_fargus Hit the nail on the head...... Fanatical Clapping

ruckage

@herb_fargus
Thanks for the reply. So it's more the Hyperspin community you dislike than the software itself?
I'm sure there are bad elements but my limited experience with members there was positive with people being helpful and polite (I've uploaded a few image packs there in the past). I guess there will always be bad apples in any community and people taking advantage (especially as the community grows). Sadly, as we know, it happens with Retropie as well - the number of ebay auctions profiting from it and people on youtube gaining masses of subs/views by providing 'fully loaded images' is quite depressing at times and discourages people from contributing to the project.

Apologies @jdrasa for going off topic, it was just something I was really curious about as I had heard several people mention that they hated Hyperspin and I wanted to understand why.

herb_fargus

@ruckage well I also don't like the majority of the styles. I prefer a slim modern interface rather than the bloated themes and wheels but anyways I digress. Carry on @jdrassa .

jdrassa

One additional question for the theme makers. The unselected logos have their opacity set to 0x80. I am also going to allow this value to be set by themes. Any preference on whether it is set as a hex value as above or as a decimal value?
i.e.
0x00 vs 0
0x80 vs. .5
0xFF vs 1

lilbud

@jdrassa Probably keep it as decimal values, keep it inline with everything else.

mattrixk

@jdrassa: I think I'm with @lilbud on this one. It's probably best to keep everything the same.

On a related note, are we going to able to colour the individual logos on the System View?

Eg: in nes/theme.xml having the code

<image name="logo">
  <path>./logo.png</path>
  <color>FF0000FF</color>
</image>

Would turn the NES logo red (if it were a white image). We can still use FF000080 to make it transparent.

ruckage

@jdrassa
This would be a great addition and something I was hoping for.

I'm with @mattrixk. Having it as Hex and part of a color option would make the most sense as that's the way it's handled for every other element. Plus it then gives us the bonus of colouring the logos as we can with other elements.

So perhaps we could borrow a tag used in textlist for uniformity?

<Color>ABABAB00<Color>  *** Used to set color & alpha for all unselected logos
<selectedColor>ABABAB00</selectedColor> *** Used to set color & alpha for the selected logo

EctoOne

@mattrixk Isn't that already possible? I did that when I modified your IO theme and was able to delete all of the white system.svg (I had to keep the dark logos because that was before the carousel was themable) you had and used the color tag to change the color of the logos in detailed, basic view.
Oh, but if I remember right I tried that with png files and it did not work. So maybe it only works on svg.

mattrixk

@ectoone I can't remember the exact details, but I think that while it worked okay in Basic and Detailed, it didn't really carry over to the System View.

EctoOne

@mattrixk Oh yeah stupid me. I even said that I tried it before the carousel was themable. So I'm not sure if I ever tried it with png or svg.

jdrassa

@mattrixk said in Carousel Enhancements:

On a related note, are we going to able to colour the individual logos on the System View?

Eg: in nes/theme.xml having the code
<image name="logo">
  <path>./logo.png</path>
  <color>FF0000FF</color>
</image>

You should be able to do this now. I added this when I implemented theme variables.

@ruckage said in Carousel Enhancements:

So perhaps we could borrow a tag used in textlist for uniformity?
<selectedColor>ABABAB00</selectedColor> *** Used to set color & alpha for the selected logo

The problem with this approach is that the logo color can be set per system. I may just hold off and implement the opacity changes separately, so I can think about it more and try out a few approaches.

EctoOne

@jdrassa said in Carousel Enhancements:

@mattrixk said in Carousel Enhancements:
On a related note, are we going to able to colour the individual logos on the System View?

Eg: in nes/theme.xml having the code
<image name="logo">
  <path>./logo.png</path>
  <color>FF0000FF</color>
</image>
You should be able to do this now. I added this when I implemented theme variables.

Ok, tried that and it only works for svg files, not png.

Edit: Scratch that. The color only covers white pixels. So to make use of it, we need to use images which are as white as possible. Although it might be possible to create some special effects if multicolored images are used.
I only had the issues that I had a pure black logo.png and compared it with a mostly white svg.

EctoOne

Am I stupid or is horizontal_view not an option!? Because it's kinda confusing to use Up/Down while browsing on this carousel.
alt text

lilbud

@ectoone Okay, that is friggin cool looking

jdrassa

@ectoone It is not currently, I had intended ask if there was demand for it, but forgot. I will get it added in the near future.

EctoOne

@jdrassa OK good, thought I had missed something again.