Fbneo does not save ghost 'n goblins hiscores

dankcushions

hi score support has to be enabled in the driver on a per game basis. not all support it, but many can if it’s enabled in the driver, and then PR’d to the main fbneo git repo. if you know C you can figure it out. if not, i’m afraid you’ll have to wait for someone who can!

mitu

Hm, it seems the hiscore is not saved indeed. The gng ROM seems to have hiscore support (https://github.com/finalburnneo/FBNeo/blob/834bbf29a93251d75b0c96426a197952e29ba814/src/burn/drv/pre90s/d_gng.cpp#L829) and I remember at one point (18 months ago ?) I reported a bug with hiscore not saving, which was promptly fixed.

I can't remember if I played the gng ROM or gngt (USA version). I see the gng driver got some changes recently, maybe that affected the hiscores.

Also, I see there's a bootleg with increased difficulty - WHO WOULD WANT THAT ?

EDIT: I'll try with gngt later to see if's working.

barbudreadmon

@mitu said in Fbneo does not save ghost 'n goblins hiscores:

Also, I see there's a bootleg with increased difficulty - WHO WOULD WANT THAT ?

Superhuman dink (FBNeo dev) can 1up gng consistently.

This is a bit of a weird issue, i can confirm the stuff for hiscores is properly implemented in those 2 drivers.
Someone can confirm it's also broken in ghouls ? Actually it's a cps1 game and i remember implementing and testing hiscores in this driver myself.

mitu

@barbudreadmon Hm, looking at your other post in a recent topic, I see that 3 July is a bad day for lr-fbneo - this is when the binary was built. I'll try to update from source and check out also ghouls while re-testing gng.

barbudreadmon

gng's hiscores are fixed.
Maybe the bug from 3 of July could explain the issue with ghouls, it was a bug with my arm's custom m68k intf (https://github.com/finalburnneo/FBNeo/issues/62) : i haven't tried scoring with this one, but at the very least it's properly creating ghouls.hi. Considering the number of games using m68k, i recommend to bump your binary to latest commit asap.

mitu

@barbudreadmon I re-install from source earlier this morning and the scores didn't save, but now if I try to update from source I get an error during compilation

[...]
../../burn/drv/konami/d_moo.o: In function `DrvDraw()':
d_moo.cpp:(.text+0xb38): undefined reference to `counter'
../../burn/drv/konami/d_moo.o: In function `DrvFrame()':
d_moo.cpp:(.text+0x3fd0): undefined reference to `counter'
collect2: error: ld returned 1 exit status
Makefile:683: recipe for target 'fbneo_libretro.so' failed

I noticed also that ghouls.hi is created inside $CONTENT_DIR/fbneo, I didn't manage to get a hiscore yet :).

barbudreadmon

@mitu sorry about that, the build issue should be fixed

ballboff

I don't think ghosts n goblins needs that emulator, it works perfectly fine on mame2003. In which case it just saves the files into the hi folder.

barbudreadmon

@ballboff idk how gng fares in mame2003, but it is a known fact that FBNeo is generally more accurate than old MAME cores, maybe that's what @kmi is seeking.

mitu

@barbudreadmon I'll give it a shot this evening, thank you !
@kmi Can you try updating from source now the lr-fbneo package and check if your hiscores are saved ?

mitu

All fixed now, thanks @barbudreadmon. Hiscores are saved ok.

kmi

Thank you very much @barbudreadmon and @mitu the game now creates the gng.hi and correctly saves the hiscores.