Ok, thanks

as always, you solved the problem. Thank you @mitu

I had the same problem and was pulling my hair out. At least for me it turned out to be something else which was quite silly. Under "other settings", there's a an option called "save metadata on exit". Changing it to on allowed the favourites to be saved again. Just wanted to provide one more data point in case it helped someone else. Cheers.