Please post your system details as asked in https://retropie.org.uk/forum/topic/3/read-this-first.
Are you rebooting/shutting down your system from the EmulationStation menu ? If EmulationStation is not cleanly shut down, the favorite information is not properly saved.